Commit graph

153 commits

Author SHA1 Message Date
Colin Kuskie
e5e9cd9b51 add tests for scratch users and migrate getUsers,isInGroup to use it 2006-04-07 20:42:36 +00:00
Colin Kuskie
f3404c319a beginnings of Session testbench 2006-04-06 23:19:59 +00:00
Colin Kuskie
f9b8582426 Scratch filter tests in prep for WebGUI::Group->getScratchUsers
Small tweaks for User.pm scratch and Group.pm POD
Update scratchFilter docs to show how to place multiple name and value pairs
2006-04-06 22:02:54 +00:00
Colin Kuskie
3e179fa4ad Group.t: group karma tests, better clean-up at end
User.t: better clean-up at end
Scratch.t: no newlines in test output
Session/Scratch.pm: convert to use placeholders
Ad.pm: Add missing line of POD.
Group.pm: add method to get all users in a group by karma.
User.pm: isInGroup to use getKarmaUsers.
2006-04-06 16:52:34 +00:00
Colin Kuskie
510c1f5ca5 Modify User.pm and Group.pm to consider external means of defining users,
such as a dbQuery.  This would happened coincidently before, but required
doing a User->isInGroup and only added members who were searched for rather
than all members.
Modify Group.t to test this.
Update POD in SQL.pm.
2006-04-05 18:35:26 +00:00
Colin Kuskie
54573e6bb2 Add tests to Stow to show that the ->set method is only really
useful when creating the Stow'ed variable.
When you ->get a Stow variable, you get a reference if you've
stowed an array or hash.  So when you modify what you got, it
changes the original inside Stow and you don't need to do a ->set.

This wouldn't work for scalars, unless it was a scalar reference.

This also means that if you modify the variable you stowed (and you
stowed a reference) after you stowed it then the stow will change
as well.
2006-04-04 17:42:25 +00:00
Colin Kuskie
8bbae90c4e remove debugging tests 2006-04-03 23:19:21 +00:00
Colin Kuskie
7b60bc8fef test that while a user can be in a group they may not be in the list of users 2006-04-03 19:13:09 +00:00
Colin Kuskie
2f65790a74 Annotate recursive versus non-recursive test
Clean-up the crowd and the mab
2006-04-03 18:17:38 +00:00
Colin Kuskie
c802e4ddad Add tests for database defined groups to Group.t
Clear cache on set of databaseLinkId or dbQuery in WebGUI::Group.pm.
Fix typos, missing module use lines and extra variables in WebGUI::User.pm.
2006-04-03 18:07:09 +00:00
Colin Kuskie
03c79ce1d0 comment out debugging output 2006-04-03 16:00:33 +00:00
Colin Kuskie
910e191fb4 Add note to DatabaseLink->new that id 0 is reserved for WebGUI database.
Build SQL table to be used in Group membership test
2006-04-03 05:36:27 +00:00
Colin Kuskie
c2fdde2635 Fix POD doc for getUsers.
Add baseline tests for changing sql method of group membership.
2006-04-03 05:14:03 +00:00
Colin Kuskie
d992111ac1 test for the profileEnabled flag in all forms reported by FieldType. Also place in 1 location the list of Forms which are NOT allowed to be profileEnabled 2006-04-02 23:31:05 +00:00
Colin Kuskie
dc2ec6bbdd Remove disabled check from all tests because it gives inconsistent
results.  Some forms were returning undef, some were returning 0.

Added a Radio button test.
Added a test to Checkbox that sees if the value (which is displayed to the
user) can be only whitespace.
2006-04-02 19:25:01 +00:00
Colin Kuskie
29635395cf Add Checkbox form test
Completely rework output postprocessing to make it more flexible
and added a test for duplicate test keys.
2006-03-31 23:04:14 +00:00
Colin Kuskie
833e5238eb fix typos in testBlock keys 2006-03-31 18:36:54 +00:00
Colin Kuskie
84342ea69c tests for single select list type forms 2006-03-31 18:27:29 +00:00
Colin Kuskie
6a035e44b0 Remove debugging output from Password test
SelectList test is finalized.
Extect auto_check to handle array and scalar accesses to the Form data post processors
2006-03-30 23:34:08 +00:00
Colin Kuskie
50452e71df refinements 2006-03-29 23:57:47 +00:00
Colin Kuskie
9b7d160a7a first cut at Form test with multiple selects 2006-03-29 01:09:52 +00:00
Colin Kuskie
1ad61ac861 Fix a bug in TimeField.
Add support for Brazilian phone numbers and extensions to Phone
2006-03-27 23:22:35 +00:00
Colin Kuskie
c772fa0d3a add Hidden test 2006-03-27 23:17:29 +00:00
Colin Kuskie
c64ebee60f Add Phone test, it needs more test cases
modify Phone.pm and Float.pm to require digits.
update Float.t to test for at least a digit to pass.
2006-03-27 22:08:27 +00:00
Colin Kuskie
556ab65f5e second batch of test automation done 2006-03-27 21:18:58 +00:00
Colin Kuskie
c8c7b78ee1 add Password test, fix bug in Password with maxlength 2006-03-27 20:42:08 +00:00
Colin Kuskie
16a6c2cc00 Form auto checker 2006-03-27 20:30:55 +00:00
Colin Kuskie
29ee2c313d first batch of test automation for getValueFromPost checking 2006-03-27 19:41:18 +00:00
Colin Kuskie
1ac514982f modify validation regexp for Float.
Add Float test
Add new Integer test
2006-03-27 00:29:03 +00:00
Colin Kuskie
efb6e82140 Added Integer test.
Change integer validation to reject strings like 123-456
2006-03-26 23:09:19 +00:00
Colin Kuskie
9ddea59a79 zipcode test 2006-03-25 19:54:22 +00:00
JT Smith
de20e89c98 fixed errors reported by smoke tests 2006-03-25 19:50:46 +00:00
Colin Kuskie
689eb47e10 adding Url test 2006-03-25 17:58:09 +00:00
Colin Kuskie
d4880b300e Add tests for Password and Email.
Updated comments appropriately.
2006-03-25 17:41:39 +00:00
Colin Kuskie
178a8cbd0f textarea test 2006-03-25 06:17:17 +00:00
Colin Kuskie
289f88a0eb post processing tests, remove HTMLForm as a requirement 2006-03-25 06:12:41 +00:00
Colin Kuskie
be57f039b0 add post processing tests 2006-03-25 05:03:20 +00:00
Colin Kuskie
5c46fc7f56 first of individual Form element tests 2006-03-25 01:00:24 +00:00
Colin Kuskie
fb066d9a9a typo in upgrade script, MessageLog => messageLog 2006-03-23 18:54:48 +00:00
Colin Kuskie
abfa6ed1ac make isUserAdmin do what the POD says (returns 0, 1), and clarify it
(deliberately passed null string or undef causes query instead of set).
Add tests to Group.t to check that behavior.
2006-03-19 06:10:44 +00:00
Colin Kuskie
0eb6ec7b01 Group test for user expiration inside a group.
1 POD tweak, more placeholder work.
2006-03-19 04:09:45 +00:00
Colin Kuskie
0cda78d536 bad test nomenclature 2006-03-19 00:24:40 +00:00
Colin Kuskie
9711a237de Finally figured out how to become a group admin, and set a test for it.
Updated Secondary Admin docs to include all details for that.
More placeholder conversions, all backed by test code.
2006-03-18 06:07:01 +00:00
Colin Kuskie
e8a364f526 New user and group tests for caching and membership and default group settings.
Cache busting in User.pm.
Allow Visitor to be formally added to groups 2 and 7.
More placeholder work.
Update Help for Secondary Admins.
2006-03-18 05:36:04 +00:00
Colin Kuskie
5ec8690e53 More user testing, for addToGroup. Also, make sure that the test for ipFilter
always cleans up after itself.

Fix a bug where Operation::User::_submenu was still using form->process.  Switched
to using stow instead.

If the uid is "new", links for delete and become user are not shown anymore.
2006-03-18 00:18:31 +00:00
Colin Kuskie
b0e0cec9aa add tests to deleting groups and try to create a loop 2006-03-17 06:08:25 +00:00
Colin Kuskie
0197f6f1bd Cleaned up Group.t so that diagnostics when failing are correct.
Fixed two bugs in Group.pm
1) If recursive was set, and no recursive cache was present but a
direct cache was available, it would be returned.  That's wrong.
2) Added a check in addGroups so that self cannot be added to itself.
2006-03-15 06:27:47 +00:00
Colin Kuskie
c6b0d9b8d5 Remove debug code from Group.t
Force uniqueness check inside isInGroups to prevent multiple group
definitions from being returned.  This should cut the size of
the in-memory Group cache by 50%, since group id #3 is returned for _every_
group.
2006-03-14 05:54:42 +00:00
Colin Kuskie
8b80268013 check in code to expose bugs 2006-03-14 04:57:27 +00:00
Colin Kuskie
248f77f3a9 Added more test in preparation for changing Group SQL query work.
Update documentation in User.pm and Group.pm.
Refactor Group.pm to use placholders.
Fix typo in getGroupsIn where wrong key in hash was accessed.
2006-03-13 04:43:05 +00:00