Commit graph

2958 commits

Author SHA1 Message Date
Patrick Donelan
b5186bfbab fixed #10565: Survey: add question doing double-create 2009-06-22 07:08:08 +00:00
Patrick Donelan
3fccab7743 Minor bugfixes/tweaks to Survey 2009-06-22 07:07:41 +00:00
Colin Kuskie
3b94bad76d Fix a typo in user output. 2009-06-20 00:02:20 +00:00
Patrick Donelan
cbc308c55a SurveyJSON size reduction/optimization
SurveyJSON was storing a lot of redundant information (every setting on
every single section/question/answer, which, in most cases, will simply
take on the default values). This was bloating the surveyJSON property in
the db, and equally as importantly, slowing down Survey because it had to
do a lot of JSON parsing on the serialised surveyJSON object.

We now factor out and store the current section/question/answer defaults
along with the surveyJSON data itself, which means that we only needs to
store properties that differ from the defaults. This results is a massive
reduction in the size of the serialized surveyJSON stored in the database,
as well as a speed-up in json parsing time.

The compression/uncompression happens transparently to the rest of Survey.
2009-06-19 08:07:18 +00:00
Martin Kamerbeek
65bdea5f3c fixed a bug in Thingy where in some cases the style template was not processed after editing a Thing. 2009-06-17 12:23:06 +00:00
Patrick Donelan
e44c7bae2e Small survey bug fix to Survey::persistResponseJSON 2009-06-17 07:21:35 +00:00
Colin Kuskie
d09015502e Better comment for why ads are being reprocessed. 2009-06-16 18:00:31 +00:00
Patrick Donelan
d820d43760 Fixed #10520 - Survey responses get confused if survey structure modified
Survey responses are now revision-aware.
The survey structure gets revisioned automatically as necessary when changes
are made on the Edit Survey screen (as necessary ~~ a response exists
for the current revision)
2009-06-16 06:25:38 +00:00
Colin Kuskie
bcd39ab098 Fix missing i18n in the shortcut. 2009-06-11 19:14:46 +00:00
Colin Kuskie
c95ea52978 Reverting Thingy RFE commit. 2009-06-11 16:38:39 +00:00
Eric Kennedy
381219a4c0 rfe #10423: Provide a way to access the instance of the thing that was added, modified, or deleted via workflow. (Eric Kennedy) 2009-06-11 03:04:45 +00:00
Yung Han Khoe
be430dfdd2 fixed #9953: Matrix 2.0 - Not enough tests 2009-06-10 18:46:15 +00:00
Colin Kuskie
52b8143707 Fix date handling by the search form in the Gallery. 2009-06-10 17:14:37 +00:00
Patrick Donelan
9004e5d711 Survey cleanup and minor bug fixes
Cleaned up edit page tabs
Improved API docs
Added noCreate option to responseId so that it doesn't create unnecessary responses
Added groupToTakeSurvey priv check to takeSurvey
2009-06-09 03:27:06 +00:00
Patrick Donelan
977be654cc Fixed bug in privs check for Survey::www_showFeedback 2009-06-09 03:26:44 +00:00
Patrick Donelan
cdc44a1bfb Made Survey Preview a little less brutal 2009-06-09 03:26:24 +00:00
Colin Kuskie
fcad3a112d Fix a bug in the Story when handling images of different sizes. Add a
photoWidth property to the StoryArchive, and resize all newly uploaded pictures
to a Story.
2009-06-08 21:51:33 +00:00
Colin Kuskie
8a683d1aef Better template diagnostics on failure. It now also includes the template URL, and templateId
in both the onscreen and logged output.
2009-06-08 16:53:53 +00:00
Doug Bell
1de7439056 fixed issue with getSortOrder and rating 2009-06-05 17:31:39 +00:00
Colin Kuskie
0cf94b4c32 Fix a syntax warning in Survey.pm 2009-06-04 21:45:13 +00:00
Colin Kuskie
957c0bc2fe 6 bugs fixed in Shortcut.
Added missing POD and i18n'ed some error messages.
Set the UI level on a tab to work with the form elements it contains.
Change the title bar ajax edit form so that people can't accidently change Visitor's profile.
Remove overrides caching if admin mode is on.
Have caching consider the user's last updated time to check if profile settings are updated, too.
2009-06-04 19:48:42 +00:00
Colin Kuskie
f9f5a8b12a Remove patch temporary file. 2009-06-04 16:24:37 +00:00
Patrick Donelan
d3f5c9ecfd Survey - differentiated between endDate and endDateEpoch. 2009-06-04 07:22:48 +00:00
JT Smith
9381fd02d8 Insufficient filtering in javascript filter (#10001) 2009-06-03 15:53:55 +00:00
Martin Kamerbeek
bb31750e7c Fixed: Calendar: Weekly re-occurence function not working properly (#10228) 2009-06-03 14:28:11 +00:00
Yung Han Khoe
15b197976e Adding Matrix tests 2009-06-03 13:22:32 +00:00
Patrick Donelan
3ffb76ef7f Fixed Survey testsuite handling of Tagged question type 2009-06-03 07:16:14 +00:00
Patrick Donelan
5acade845a Fixed Survey test suite 'tagged' check to work with nested data 2009-06-03 07:15:52 +00:00
Patrick Donelan
9702ffcaac Fixed Survey section-level branch precedence bug
For Sections with questions spread out over multiple pages, branch
expressions should only happen on the last page of the Section.
Added explicit test.
2009-06-03 02:12:00 +00:00
Patrick Donelan
da595da89e Remove bloat from Survey response record to reduce json serialisation time 2009-06-03 02:11:31 +00:00
Patrick Donelan
216a48580a Fixed #9927 Survey - verbatim
Fixed inconsistencies between answer 'comment' and 'verbatim'.
Updated tests.
Made minor changes to reporting methods but they still need some love.
2009-06-03 00:29:29 +00:00
Colin Kuskie
6ac30bb2ea Add noFormPost to packed content in the asset tables to prevent them
from overwriting the data that has been packed from the filter function.
Rerun the upgrade script to repack all areas that use packing.
2009-06-02 20:30:48 +00:00
Colin Kuskie
80dfb9ffd0 Throw an exception in all wobjects if the main template (used by view)
has been deleted.
2009-06-02 19:34:18 +00:00
Patrick Donelan
084a0c3105 Fixed naff Survey::takenCount bug, added explicit test for it 2009-06-02 02:42:37 +00:00
Patrick Donelan
7faa9c3e9d Fixed Survey Date question type server-side validation, and made
all validation messages generate debug output
2009-06-02 01:48:41 +00:00
Colin Kuskie
45d1791876 Remove multiple delete buttons for photos in the Story. Ala GalleryFile/Photo. 2009-06-02 01:39:22 +00:00
Colin Kuskie
5fd74af21e Don't make a 2nd i18n object. 2009-06-01 20:47:06 +00:00
Colin Kuskie
96af6ed2ce Fix POD, and remove dead label/hoverhelp code which isn't used. 2009-06-01 20:15:21 +00:00
Colin Kuskie
fcb884a410 Fix Project Manager calling wrong method on right object. www_viewScreen now
uses mobile template if so enabled via calling processStyle.
2009-06-01 20:00:16 +00:00
Colin Kuskie
8f09dc062d Add edit and delete icons to the Story Topic. Update tests. Adjust both
sets of templates.  Use the correct privileges for displaying the icons.
Help and i18n.
2009-06-01 16:53:22 +00:00
Colin Kuskie
6844ef4559 Add missing edit story and delete story icons in the view method of the Story Archive. 2009-06-01 16:27:49 +00:00
Colin Kuskie
76b9f01e77 Prevent head tags from appearing twice in wobjects.
prepareView sets the extra head tags.  Have all wobjects, in their www_view method,
tell processStyle not to set the extra head tags again.
2009-06-01 02:03:05 +00:00
Colin Kuskie
20a333cde8 Change caching on the SQLReport to be set by its cacheTimeout, even
when viewed standalone, and not part of a page.
2009-05-30 18:01:59 +00:00
Colin Kuskie
d9e2590623 Internationalize the shortcut no longer exists message. 2009-05-30 15:28:59 +00:00
Yung Han Khoe
398f5203f4 making all Matrix datatables templatable 2009-05-30 14:43:41 +00:00
Colin Kuskie
b0a1e20053 Refactor processStyle so there's no duplicated code. Make Wobject call
SUPER.  Add an option to skip adding getExtraHeadTags, so that Shortcut
doesn't add them an extra time.  Remove the subclassed getExtraHeadTags,
since prepareView will add them, which prevents adding them a 3rd time.
2009-05-29 23:30:04 +00:00
Graham Knop
66843db604 string evals are evil 2009-05-29 21:41:52 +00:00
Graham Knop
c0d7357429 fixed: Template parser cannot be set 2009-05-29 20:22:08 +00:00
Colin Kuskie
0bf47be7f4 Add a basic test for the Poll, adding votes and making a graph.
Add POD to Poll for setVote, and use placeholders in there.
2009-05-29 18:54:26 +00:00
Colin Kuskie
2daa6c6c99 fix list type form data in Shortcut, too 2009-05-29 15:51:47 +00:00