Commit graph

13 commits

Author SHA1 Message Date
Amir Plivatsky
50954c333f Fixed #12191. 2011-07-12 19:47:27 +03:00
ampli
5ea09092ad Fixed the following jslint warnings:
Lint at line 5 character 16: 'WebGUI' was used before it was defined.
var WebGUI = {};

Lint at line 53 character 86: Missing '()' invoking a constructor.
data[ columns[ i ].key ] = columns[i].formatter == "date" ? new Date : "";

Lint at line 89 character 21: 'i' is already defined.
for ( var i = 0; i < cols.length; i++ ) {

Lint at line 612 character 25: 'col' is already defined.
var col     = this.dataTable.getColumn( oldKey );

Lint at line 661 character 63: Missing '()' invoking a constructor.
allRecords[j].setData(newKey, new Date);
2011-06-29 04:55:59 +03:00
ampli
8e7beabaf0 Fix #12179.
In WebKit browsers, when a schema is saved, existing column
field types are reset to "Text". This is not a bug in WebKit, and
will happen in any browser that implements Option() as documented.

Option() is not supposed to have an immediate action if only the
default selection is updated on a newly added select object.
See: http://download.oracle.com/docs/cd/E19957-01/816-6408-10/option.htm .

Repeat-By:
1. New Content->basic->Datatable
2. data
3. Edit Schema
4. col1, Number, Add Column
5. col2, E-mail, Add Column
6. col3, URL, Add Column
7. Edit Schema (note that the field types got reset to "Text")
8  Save (now the field types incorrectly got overwritten in the DataTable)

Fixed by adding 4th arguments to actually make the new selection to be
equal to the default one.
2011-06-29 04:12:02 +03:00
ampli
ed0c400440 Columns in DataTable may be "randomly" deleted. This happens in updateSchema(), because both the column update loop and the row update loop use the same variable "i". Since variable scope in JS is by function and not block, the column loop variable gets overwritten.
Repeat-by:
1. New Content->Basic->DataTable
2. data
3. Edit Schema
4. col1, add Column
5. col2, add Column
6. col3, Save
7. Edit Schema

Note that col2 is missing.

Fix:
Change the name of the variable in the row loop.
2011-06-29 03:01:15 +03:00
Doug Bell
625da8bb41 fix 11432 DataTable date input 2010-08-10 14:05:35 -05:00
Colin Kuskie
0fb7a60917 Fix DataForms with dates. 2010-02-23 20:59:49 -08:00
Colin Kuskie
83395fbe95 Fix Date handling by the DataTable, again... Now it uses a custom date parser to take the ISO date format. Fixes bug #11428. 2010-02-23 12:56:00 -08:00
Colin Kuskie
9d14e8b420 Fix rendering of initial DataTable in IE7, IE8. Fixes bug #11205.
Added TR, TD tags to table containing the DataTable.  Also,
ran dataTable.js through jslint and fixed many issues.
2009-11-09 16:51:38 -08:00
Paul Driver
7e51ddd3b2 Making sure focus is set properly when tabbing through fields in the datatable editor 2009-06-03 15:36:57 +00:00
David Delikat
571c824ad1 fixed bug #9629: override stringify date format to use java default format. 2009-02-10 04:03:27 +00:00
Doug Bell
9f58115cac fixed #9150: Edit Data Table - Cannot add column (David Delikat) 2008-12-11 00:27:54 +00:00
Doug Bell
d224376d02 added: Delete columns in DataTable
fixed: Now more than one DataTable can be on a page
2008-11-07 03:32:18 +00:00
Doug Bell
3e1f66a0e7 added: DataTable asset 2008-10-28 22:27:17 +00:00