Commit graph

11640 commits

Author SHA1 Message Date
Patrick Donelan
d9316f47c4 Made perlcritic a little less grumpy about Survey.pm 2009-02-11 09:28:16 +00:00
Patrick Donelan
5a2f514a5a Added Delete Responses back into Survey template (with i18n) 2009-02-11 09:27:54 +00:00
Patrick Donelan
7128a3d07c More Survey.pm refactoring
Turned getResponseId into a lazy-loading responseId mutator
Added responseIdCookies flag as a workaround for WebGUI::Test::getPage's
lack of cookie support
2009-02-11 09:27:31 +00:00
Patrick Donelan
16c87b9cba Made Survey's responseJSON property lazy-load so that you don't have to
call loadResponseJSON and/or loadBothJSON everywhere
2009-02-11 09:27:10 +00:00
Patrick Donelan
e139136d08 Made Survey->surveyJSON lazy-load so that you don't have to call
loadSurveyJSON() everywhere.
2009-02-11 09:26:50 +00:00
Patrick Donelan
8d7599d781 Moved Survey.pm's "survey" and "response" properties to private hash
vars and added accessors.

So that you don't end up with mind-bending code that looks like:
$survey->survey->{survey}
2009-02-11 09:26:27 +00:00
Patrick Donelan
316d133a02 Improved Survey.pm documentation 2009-02-11 09:26:05 +00:00
Patrick Donelan
d882181fd1 Started refactoring the Survey.pm Wobject class
Refactored www_jumpTo and added tests
Added Params::Validate
Improved docs
Made call to SurveyJSON->createSurveyOrder() unnecessary
Turned ResponseJSON->nextResponse a mutator
2009-02-11 09:25:42 +00:00
Patrick Donelan
ba6764065b Added Survey Template i18n and hoverhelp 2009-02-11 09:25:17 +00:00
Patrick Donelan
99b19aa180 Removed unused responseTemplate from Survey 2009-02-11 09:24:57 +00:00
Patrick Donelan
25a6fc5e76 Added 'max responses per user' i18n and hoverhelp 2009-02-11 09:24:39 +00:00
Patrick Donelan
3601dfe89e Re-applied Survey cancel button fix from merge 2009-02-11 09:24:19 +00:00
Patrick Donelan
03be723535 Added note about Params::Validate to gotcha.txt 2009-02-11 09:24:00 +00:00
Patrick Donelan
2f04648cf7 Added doAfterTimeLimit column to Survey table 2009-02-11 09:23:45 +00:00
Patrick Donelan
c7b5fa366a Added Params::Validate to testEnvironment.pl 2009-02-11 09:23:27 +00:00
Colin Kuskie
0fa1ec4901 In the AssetManager, do not show the Edit link in the More menu if the asset is locked. 2009-02-11 04:42:15 +00:00
Graham Knop
1edc66367e Spectre tests shouldn't need WRE to run 2009-02-10 22:54:54 +00:00
Graham Knop
462b85e4e7 preparing for 7.6.12 dev 2009-02-10 22:53:07 +00:00
Colin Kuskie
6aa9185c1c Fix a sequencing issue in the ITransact postback routine, where it uses
an object before it is validated.
2009-02-10 22:46:50 +00:00
Graham Knop
9924eead58 preparing for 7.5.11 release 2009-02-10 21:42:16 +00:00
Graham Knop
04382640b8 fixed: Asset Manager can generate URLs that are too long 2009-02-10 21:42:02 +00:00
Graham Knop
fd48c81e76 fixing placement of head tags in widgets 2009-02-10 21:41:53 +00:00
Graham Knop
a8dab0ac03 fix exif test 2009-02-10 21:41:48 +00:00
Graham Knop
bf9bd2f0d2 use proper JSON encoding/decoding 2009-02-10 21:41:36 +00:00
Graham Knop
7023683b48 fix for matrix test 2009-02-10 21:41:27 +00:00
Graham Knop
b088299eb0 capcha control now has reCAPTCHA mode 2009-02-10 21:41:19 +00:00
Colin Kuskie
5d8ede926c use PseudoRequest to stop some test warnings 2009-02-10 20:24:34 +00:00
Colin Kuskie
2482c0f89f Remove tests from FetchMimeType that just were setup to help Fedora pass. 2009-02-10 17:26:29 +00:00
Patrick Donelan
73c02b6803 Part-way through merging Survey features from trunk
Cleaned up Survey Edit screen, hover help, layout etc..
Added "jump to" AutoComplete box on Section Edit dialog (as per Answer
Edit dialog)
N.B. "take survey" is currently broken, but will be easy to fix
2009-02-10 08:00:18 +00:00
Patrick Donelan
b0c5c09461 Merge branch 'master' into survey
* master: (127 commits)
  Prefill in the email address in the ITransact credentials form from the user's Shop address.
  fixed Matrix best/worst rated lists
  Fix bad form variable for phone number in EMS Badge address info.
  - Added a switch to allow the use of non-WebGUI objects with the Workflow
  fixing a problem with previous survey fix
  fixed #9671: Survey - breaks admin bar
  fixed a Matrix sql problem
  i18n the image labels and title for the asset manager, manage screen.
  Prevent an imported package from changing the a current asset's status from pending to anything else.
  Remove trailing comma in Shop/Transaction JS so IE6 works.
  fixed documentation
  fixed a bug when a matrix listing didn't have a forum attached
  small char encoding fix to merged upgrade
  fix small issue in addChild
  adding merge point
  Fix a problem with purging an EMS.
  Update this template so that it passes the template i18n test.
  Fix a broken i18n label in answer edit template for the Survey.
  Unify all Survey CSS into 1 file, and use it.
  Adding/fixing Survey i18n and Help
  ...

Conflicts:
	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/ResponseJSON.pm
	lib/WebGUI/i18n/English/Asset_Survey.pm
	www/extras/wobject/Survey/editsurvey/object.js
2009-02-10 07:57:42 +00:00
David Delikat
571c824ad1 fixed bug #9629: override stringify date format to use java default format. 2009-02-10 04:03:27 +00:00
Yung Han Khoe
66e4b23e7f improving matrix performance 2009-02-10 02:17:42 +00:00
Colin Kuskie
6a1bbead00 Prefill in the email address in the ITransact credentials form from the user's Shop address. 2009-02-09 18:45:21 +00:00
Yung Han Khoe
a61dd87d22 fixed Matrix best/worst rated lists 2009-02-09 17:22:32 +00:00
Colin Kuskie
d17e1f21d6 Fix bad form variable for phone number in EMS Badge address info. 2009-02-09 17:16:01 +00:00
JT Smith
be42bb0856 - Added a switch to allow the use of non-WebGUI objects with the Workflow
engine.
2009-02-08 21:20:32 +00:00
Yung Han Khoe
d32137b5db fixing a problem with previous survey fix 2009-02-07 21:08:02 +00:00
Yung Han Khoe
c817937623 fixed #9671: Survey - breaks admin bar 2009-02-07 17:37:37 +00:00
Yung Han Khoe
36d401aa74 fixed a Matrix sql problem 2009-02-06 21:23:39 +00:00
Colin Kuskie
6be6c0bb11 i18n the image labels and title for the asset manager, manage screen.
Also, display the username instead of the userId.
2009-02-06 19:32:05 +00:00
Colin Kuskie
911e30c43c Prevent an imported package from changing the a current asset's status from pending to anything else. 2009-02-06 18:58:10 +00:00
Colin Kuskie
ff3bb6f5b9 Remove trailing comma in Shop/Transaction JS so IE6 works. 2009-02-06 18:47:40 +00:00
Patrick Donelan
675333c54d More documentation tweaks for ResponseJSON 2009-02-06 06:06:29 +00:00
Patrick Donelan
6fddcdaf5f Refactored returnResponseForReporting 2009-02-06 05:51:08 +00:00
Patrick Donelan
fa6976fb40 More ResponseJSON refactoring.
Finished refactoring nextQuestions()
Added recordedResponses sub
Added getTemplatedText sub
Added sectionId, questionId, answerId, sIndex, qIndex, aIndexes
abstraction subs
2009-02-06 05:15:26 +00:00
JT Smith
36eead4e9c fixed documentation 2009-02-06 04:50:46 +00:00
JT Smith
6701a10491 fixed a bug when a matrix listing didn't have a forum attached 2009-02-06 04:49:57 +00:00
Graham Knop
332ace9648 small char encoding fix to merged upgrade 2009-02-06 03:31:39 +00:00
Patrick Donelan
306502465c Started refactoring nextQuestions in ResponseJSON
Made perlcritic happier
Extracted getQuestionResponses from processGotoExpression
Eliminated getPreviousAnswer
2009-02-06 01:56:54 +00:00
Patrick Donelan
3340a675b7 Updated Survey.pm to use new ResponseJSON.pm methods 2009-02-06 01:56:35 +00:00