It didn't work with CIDR format IP addresses. I cannabilized the
code from canShowDebug and refactored it into its own method,
canShowBasedOnIP. Both canShowDebug and canShowPerformanceIndicators call this.
Updated the docs for the debugIp setting to note that it's used for both
showDebug and showPerformanceIndicators.
Added about 20 more tests to ErrorHandler.t. Only the two hard methods are
left, fatal (which closes the session at the end) and showDebug, which is
validating a ton of output.
More tests for Session/Icon.pm. Due to the way the code is written,
this test will not test 100% of the code. Untestable conditions include
not being able to find the toolbar directory in getToolbarOptions, and
all code that sets a default pageUrl in any icon-specific method.
Documented the disabled flag for moveDown and moveUp. Only the EMS uses this in
the core as far as I can tell.
Optimized out 1 profile call in getBaseURL
There are still a few functional tests that need to be written, they're
codified as TODOs.
In Session/Style.pm, in all methods that have a send immediate option
(when sent=1), they no longer send and cache. This prevents duplicate
heag tags from being generated if generateAdditionalHeadTags was
ever called twice.
fixed a bug in userStyle where it would not process data that was false.
process will do this, so I made userStyle do it as well by adding
in a definedness check on $output.
Found a fixed an infinite loop in WebGUI::Style::process
If an asset was requested to be printed who does not have a
printableStyleTemplateId then process would recurse back up the
lineage until it does find an asset with a printableStyleTemplateId.
Eventually, if none is found, it will find the Asset Root, whose
parent is itself, and it will loop forever.
I added code to jump out of the loop if it recurses back to the
assetRoot.
for default processing and for meta tags when cache busting is enabled.
Fixed a bug where the default meta tag Generator did not contain the
WebGUI version.
Added lots of POD to the Style module detailing how meta tags are
handled in various cases.
requested. It used to be 6, but at somepoint in the 6.x cycle it
was changed to be PBtmpl0000000000000132 in the database.
Added tests that verify that it works correctly.
the Session Id. This is by design.
Added a check to Style.pm so that if no params are passed to setLink that
it won't die by trying to deref undef into a hashref.
First set of tests for Session/Style added.
Found and fixed a but in Session/Scratch/deleteNameByValue. It would
not delete any value that was false (0, '' or undef). Added a defined-ness
check to make sure it will delete 0 or '', but undef is still not handled.
Added POD to say that this was the case.
was enabled a noCache param was always added to the URL. In some
cases it would add 2 noCache params.
To fix this, I added a skipPreventProxyCache param to the gateway method,
and page just passes $pairs and $skipPreventProxyCache to gateway.
Added tests to Url.t to test gateway, page, makeAbsolute and urlize
to bring its coverage up to 100%.
Added tests to Stow.t to bring it's coverage up to 100% as well.
Tests for escape, unescape, extras methods. Test code is big enough
that I've added section delimiting comments. This has helped make
the code a lot more readable.
Convert it to use placeholders as well.
More WebGUI::Session::Url tests, and some bug fixes:
getRefererUrl returned parameters and accepted weird methods that
looked like http but weren't.
that a new userSessionId will be created and that the current sessionId (the actual
session object's id) will be set to this new id.
Add several new tests to Session/Var.t Tried hard to exploit the change in
sessionId and haven't found a way, yet.
be fixed later.
Added lots of comments to start and new subs. Changed db methods to
use placeholders. Changed timely data to call time once so that they
all match.
