Commit graph

11048 commits

Author SHA1 Message Date
Scott Walters
6a6fff613f Fixing the var() deprecation crutch. 2011-05-22 21:03:45 -04:00
Scott Walters
7687203a2f Author: kthakore <thakore.kartik@gmail.com>
Date:   Sun May 22 16:02:00 2011 -0400

    Fixed SQL statement for ?op=listUsers operation.
2011-05-22 18:12:20 -04:00
Scott Walters
f14f2e59c9 Failed calls to www_ methods generating stack traces when webgui.debug is on
is useful for developers; merely warning skips stack traces in
WebGUI::Middleware::StackTrace.  Make this an error.
2011-05-22 15:55:11 -04:00
Scott Walters
819cef2c17 $SIG{__DIE__} is a can of worms. Why doesn't try { } localize it...? 2011-05-22 15:36:40 -04:00
Scott Walters
096fe5ebaa Can't try possibily null data in an asset constructor any more, at least not without catching; this throws exceptions now. 2011-05-22 15:28:48 -04:00
Scott Walters
95def8a439 Perl run-time errors get kicked over to session->log->error, and
WebGUI::Middleware::StackTrace now intercepts errors as well as
fatals (since fatals are likely going away).
2011-05-22 15:25:10 -04:00
Doug Bell
65752f2213 Merge pull request #12 from haarg/tt-asset-plugin
Adds an Asset plugin for Template Toolkit
2011-05-20 12:07:30 -07:00
Graham Knop
2a73f5ab63 fix undefined warnings 2011-05-19 19:25:13 -05:00
Doug Bell
258d939614 remove getValue for the third time maybe? 2011-05-19 19:23:51 -05:00
Doug Bell
e5012d3914 App::Cmd options are normalized to lower-case 2011-05-18 14:56:24 -05:00
Doug Bell
b1a527682d do not buffer command output 2011-05-18 14:12:23 -05:00
Doug Bell
72667d0bd1 add process() sub for FormBuilder 2011-05-17 17:30:49 -05:00
Graham Knop
d1f93b8f7c add Asset template plugin 2011-05-17 17:09:27 -05:00
Doug Bell
72d32d679d clarify returning from try/catch 2011-05-17 15:27:37 -05:00
Doug Bell
587d494501 add Template Toolkit plugins/extentions 2011-05-17 15:20:17 -05:00
Doug Bell
1f750691c0 allow assetName to be a normal, non-i18n string 2011-05-17 11:52:03 -05:00
Doug Bell
01b9d95259 fix RichEdit merge 2011-05-17 11:49:00 -05:00
Doug Bell
677ac978b6 Merge branch 'WebGUI8' of github.com:plainblack/webgui into 8
Conflicts:
	lib/WebGUI.pm
	lib/WebGUI/Auth/WebGUI.pm
	sbin/findBrokenAssets.pl
	sbin/testEnvironment.pl
2011-05-13 18:20:52 -05:00
Doug Bell
277faae8a1 Merge commit 'v7.10.15' into 8
Conflicts:
	docs/gotcha.txt
	docs/previousVersion.sql
	docs/templates.txt
	lib/WebGUI.pm
	lib/WebGUI/Asset.pm
	lib/WebGUI/Asset/Event.pm
	lib/WebGUI/Asset/File.pm
	lib/WebGUI/Asset/MapPoint.pm
	lib/WebGUI/Asset/RichEdit.pm
	lib/WebGUI/Asset/Sku/Product.pm
	lib/WebGUI/Asset/Snippet.pm
	lib/WebGUI/Asset/Story.pm
	lib/WebGUI/Asset/Template.pm
	lib/WebGUI/Asset/Template/TemplateToolkit.pm
	lib/WebGUI/Asset/Wobject/Calendar.pm
	lib/WebGUI/Asset/Wobject/Carousel.pm
	lib/WebGUI/Asset/Wobject/Collaboration.pm
	lib/WebGUI/Asset/Wobject/Dashboard.pm
	lib/WebGUI/Asset/Wobject/DataForm.pm
	lib/WebGUI/Asset/Wobject/Folder.pm
	lib/WebGUI/Asset/Wobject/Map.pm
	lib/WebGUI/Asset/Wobject/Search.pm
	lib/WebGUI/Asset/Wobject/Shelf.pm
	lib/WebGUI/Asset/Wobject/StockData.pm
	lib/WebGUI/Asset/Wobject/StoryTopic.pm
	lib/WebGUI/Asset/Wobject/SyndicatedContent.pm
	lib/WebGUI/Asset/Wobject/Thingy.pm
	lib/WebGUI/Asset/Wobject/WeatherData.pm
	lib/WebGUI/AssetClipboard.pm
	lib/WebGUI/AssetCollateral/DataForm/Entry.pm
	lib/WebGUI/AssetExportHtml.pm
	lib/WebGUI/AssetLineage.pm
	lib/WebGUI/AssetMetaData.pm
	lib/WebGUI/AssetTrash.pm
	lib/WebGUI/AssetVersioning.pm
	lib/WebGUI/Auth.pm
	lib/WebGUI/Cache/CHI.pm
	lib/WebGUI/Content/AssetManager.pm
	lib/WebGUI/Fork/ProgressBar.pm
	lib/WebGUI/Form/JsonTable.pm
	lib/WebGUI/Form/TimeField.pm
	lib/WebGUI/Form/Zipcode.pm
	lib/WebGUI/Group.pm
	lib/WebGUI/International.pm
	lib/WebGUI/Macro/AssetProxy.pm
	lib/WebGUI/Macro/FileUrl.pm
	lib/WebGUI/Operation/SSO.pm
	lib/WebGUI/Operation/User.pm
	lib/WebGUI/Role/Asset/Subscribable.pm
	lib/WebGUI/Shop/Cart.pm
	lib/WebGUI/Shop/Transaction.pm
	lib/WebGUI/Shop/TransactionItem.pm
	lib/WebGUI/Test.pm
	lib/WebGUI/URL/Content.pm
	lib/WebGUI/URL/Uploads.pm
	lib/WebGUI/User.pm
	lib/WebGUI/Workflow/Activity/ExtendCalendarRecurrences.pm
	lib/WebGUI/Workflow/Activity/SendNewsletters.pm
	lib/WebGUI/i18n/English/Asset.pm
	lib/WebGUI/i18n/English/WebGUI.pm
	sbin/installClass.pl
	sbin/rebuildLineage.pl
	sbin/search.pl
	sbin/testEnvironment.pl
	t/Asset/Asset.t
	t/Asset/AssetClipboard.t
	t/Asset/AssetLineage.t
	t/Asset/AssetMetaData.t
	t/Asset/Event.t
	t/Asset/File.t
	t/Asset/File/Image.t
	t/Asset/Post/notification.t
	t/Asset/Sku.t
	t/Asset/Story.t
	t/Asset/Template.t
	t/Asset/Wobject/Collaboration/templateVariables.t
	t/Asset/Wobject/Collaboration/unarchiveAll.t
	t/Asset/Wobject/Shelf.t
	t/Auth.t
	t/Macro/EditableToggle.t
	t/Macro/FilePump.t
	t/Shop/Cart.t
	t/Shop/Transaction.t
	t/Storage.t
	t/User.t
	t/Workflow.t
2011-05-13 18:15:11 -05:00
Scott Walters
7a994b59ce File assets should always give IO::File::WithPath objects to PSGI, instead of the current redirecting or streaming behavior. (#11688)
New API method:  WebGUI::Response::sendFile;  it, as appropriate, calls
setRedirect or setStreamedFile, depending on enableStreamingUploads config var.
setStreamedFile now kicks off the XSendfile process.
File.pm now uses this instead of trying to set both a redirect and a stream.
IO::File::WithPath blows up if a file doesn't exist so this raises an exception
now.
The http now no longer insist that '0' is not a valid filename to stream.
site.psgi, depending on enableStreamingUploads, enables either the Static
or XSendfile middleware.
2011-05-12 20:22:43 -04:00
Scott Walters
96bb194402 Change newByDynamicClass calls that creept in back to newById, except for the ones in doc/upgrade. Kinda important. 2011-05-11 16:26:32 -04:00
Scott Walters
57d2dbed56 WebGUI::Session::Http should go away (#11647)
Move logic out of WebGUI::Session::HTTP and into WebGUI::Session::Response /
::Request; deprecate more functions; change references in core to use
$session->response instead; fix tests that broke because of the change but
not one that merely generate the deprecated warning because I want to know
that the proxying of depricated methods is working.  These can be changed later.
2011-05-11 16:17:54 -04:00
Scott Walters
72bac90f93 Rework WebGUI::Test::getPage2 to be a wrapper around WebGUI::Test::Mechanize; this is still just
a crutch for converting tests, though really, it's enough shorter that it probably should live on.
getPage should be deprecated and replaced with getPage2 which should then be renamed.  Joy.
Anyway, WebGUI::Test::Mechanize had a bit of chicken-and-egg going on with not being able to
modify things in its session until after a request with a valid session cookie was made.
It's now more forgiving.
Reworked t/Asset/AssetExportHtml.t slightly to use getPage2 as it currently stands.
2011-05-11 15:26:32 -04:00
Scott Walters
d2c8670098 Introduce WebGUI::Test::getPage2, similar to WebGUI::Test::getPage, that makes
requests using Plack::Test and attempts to maintain getPage's API.
Change three tests in t/Asset/AssetExportHtml.t to use this instead.
Backstory:
Forthcoming WebGUI::Session::HTTP, ::Request, ::Responses mucking abouts broke
some tests that use WebGUI::Test::getPage; in the case of t/Asset/AssetExportHtml.t,
files were written correctly to disc but tests failed because it was comparing them
to undef, which it got back for the page, apparently because getPage bypasses the
logic that traps printing to a filehandle.
2011-05-11 13:58:20 -04:00
Scott Walters
13a2c359e7 Get rid of the cargo culted code about sending a text reply if the browser didn't specify
that it understands HTML.  This interacts badly with Plack::Test and doesn't have much of
a point in real life anyway, and I accidentally sent the test up that dends on this being
gone without sending this too.  Argh.  If I could send up a coherent commit just once...
2011-05-05 21:42:38 -04:00
Doug Bell
2e720d6899 getEditForm returns FormBuilder and csrfToken should be added by www_edit 2011-05-05 19:43:32 -05:00
Doug Bell
18dd9a459d move export product tests and fix the export product helper 2011-05-05 19:27:22 -05:00
Doug Bell
140b5a546f move Shelf tests into AssetHelper tests (and fix the thing) 2011-05-05 18:51:42 -05:00
Doug Bell
ef2727f6f5 update usedBy when redeeming subscription code 2011-05-05 15:52:22 -05:00
Doug Bell
475a885146 shortcut now takes ?visitor=1 to edit visitor prefs from dashboard 2011-05-05 15:52:22 -05:00
Scott Walters
2f45f306fb Doc improvements 2011-05-05 15:08:06 -04:00
Scott Walters
59a22f4101 set recursion limit to 1 for dumped lexicals and function args; with unlimited depth, it was
making my Mozilla shoot to 1.5gigs and taking the server and browser forever to get the
error page up.
keep the HTML of the original page and tack it on to the end of the stack trace.
add WebGUI::Middleware::StackTrace to the default site.psgi in place of the standard StackTrace,
but leave a comment for the other one in case people prefer it.
2011-05-05 14:58:04 -04:00
Scott Walters
617ca066dc Tweak which stack frames WebGUI::Middleware::StackTrace skips for HTML and text output; add the modules it uses to testEnvironment.pl; comment out the dumping of the asset tree for now; silence a warning in testEnvironment.pl by tweaking module test/load order 2011-05-05 14:58:03 -04:00
Scott Walters
a97c1c9d86 middleware based on Plack::Middleware::StackTrace that also dumps all of the assets in a YUI tree view
because that seemed like a good idea at the time.
2011-05-05 14:58:03 -04:00
Scott Walters
742db182e8 don't force an extra layer of streaming as doing so bypasses plack middlewares. 2011-05-05 14:58:03 -04:00
Doug Bell
423e19ae0e remember to pass the definition up the stack... 2011-05-05 11:23:05 -05:00
Doug Bell
b0da37ec15 fix EMSSubmissionForm and all its tests 2011-05-04 15:33:04 -05:00
Doug Bell
ecbaca599d formbuilder templatevar prefix must contain the underscore now 2011-05-04 13:48:19 -05:00
Doug Bell
53439e4d08 old AssetManager is obsolete 2011-05-04 12:58:04 -05:00
Doug Bell
129eb2b3d5 adminbar macro no longer exists 2011-05-04 12:57:39 -05:00
Doug Bell
38eb9a8469 EditableToggle is no longer necessary 2011-05-04 12:48:12 -05:00
Doug Bell
d8d2ab0930 adminbar is no longer needed 2011-05-03 17:46:17 -05:00
Doug Bell
74b8e36552 add all the other assets 2011-05-03 17:09:14 -05:00
Doug Bell
7389128d99 must have a width/height in order to set width/height
Failing to give a proper width/height will cause ImageMagick to die
with an assertion error
2011-05-03 17:09:14 -05:00
Doug Bell
40805cee48 log the error when we have one, don't just return it 2011-05-03 17:09:13 -05:00
Doug Bell
19623178e7 fix Dashboard edit form 2011-05-03 17:09:13 -05:00
Colin Kuskie
88c9fa81b0 Remove the fields variable from the template variable help for Asset_Thing, viewThingData. 2011-05-02 20:06:54 -07:00
Scott Walters
ee212a16f3 WebGUI::Test::waitForAllForks optionally taking a number of seconds to wait;
t/AssetHelper/Copy.t using this as one of its tests; this creates a test failure out of a test suite deadlock for me
2011-05-02 18:25:21 -04:00
Scott Walters
6e12a8f78a simple cleanup logic for WebGUI::Fork; mark the fork "completed" even though it may not be just so that the next test that wants to do waitForAllForks doesn't get hung up on our fork 2011-05-02 17:59:07 -04:00
Colin Kuskie
61534779d5 Add new MapPoint code for geolocation, Thingy searching and indexing and a macro for rendering thing data outside of the Thingy. 2011-05-02 13:49:18 -07:00