Commit graph

90 commits

Author SHA1 Message Date
Patrick Donelan
b0c5c09461 Merge branch 'master' into survey
* master: (127 commits)
  Prefill in the email address in the ITransact credentials form from the user's Shop address.
  fixed Matrix best/worst rated lists
  Fix bad form variable for phone number in EMS Badge address info.
  - Added a switch to allow the use of non-WebGUI objects with the Workflow
  fixing a problem with previous survey fix
  fixed #9671: Survey - breaks admin bar
  fixed a Matrix sql problem
  i18n the image labels and title for the asset manager, manage screen.
  Prevent an imported package from changing the a current asset's status from pending to anything else.
  Remove trailing comma in Shop/Transaction JS so IE6 works.
  fixed documentation
  fixed a bug when a matrix listing didn't have a forum attached
  small char encoding fix to merged upgrade
  fix small issue in addChild
  adding merge point
  Fix a problem with purging an EMS.
  Update this template so that it passes the template i18n test.
  Fix a broken i18n label in answer edit template for the Survey.
  Unify all Survey CSS into 1 file, and use it.
  Adding/fixing Survey i18n and Help
  ...

Conflicts:
	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/ResponseJSON.pm
	lib/WebGUI/i18n/English/Asset_Survey.pm
	www/extras/wobject/Survey/editsurvey/object.js
2009-02-10 07:57:42 +00:00
Patrick Donelan
675333c54d More documentation tweaks for ResponseJSON 2009-02-06 06:06:29 +00:00
Patrick Donelan
6fddcdaf5f Refactored returnResponseForReporting 2009-02-06 05:51:08 +00:00
Patrick Donelan
fa6976fb40 More ResponseJSON refactoring.
Finished refactoring nextQuestions()
Added recordedResponses sub
Added getTemplatedText sub
Added sectionId, questionId, answerId, sIndex, qIndex, aIndexes
abstraction subs
2009-02-06 05:15:26 +00:00
Patrick Donelan
306502465c Started refactoring nextQuestions in ResponseJSON
Made perlcritic happier
Extracted getQuestionResponses from processGotoExpression
Eliminated getPreviousAnswer
2009-02-06 01:56:54 +00:00
Patrick Donelan
345989370f Renamed ResponseJSON branching methods 2009-02-06 01:56:18 +00:00
Patrick Donelan
932a033b58 More ResponseJSON refactoring
Removed unnecessary $session argument from recordResponses
Refactored nextQuestions to return a list rather than an arrayref
Lots more documentation for ResponseJSON
More param validation for ResponseJSON
Refactored recordResponses
Updated tests
2009-02-06 01:55:56 +00:00
Patrick Donelan
90d314d2f1 Refactored next/last response/section related accessors and mutators
(and tests).

Added more documentation.
2009-02-06 01:55:33 +00:00
Patrick Donelan
669e986189 Replaced ResponseJSON's implementation of shuffle with List::Util's
shuffle and updated Colin's ninja shuffle tests
2009-02-04 02:05:44 +00:00
Patrick Donelan
477f014177 Improved createSurveyOrder documentation, and made perlcritic happy 2009-02-04 00:16:44 +00:00
Patrick Donelan
6fb325699f Refactored createSurveyOrder in ResponseJSON
Added lastSectionIndex, lastQuestionIndex, lastAswerIndex convenience
methods to SurveyJSON to simplify iterations over Sections, Questions
and Answers
2009-02-04 00:16:26 +00:00
Patrick Donelan
66a2adcbe5 Moved ResponseJSON data hash to private variable, for security and
consistency with SurveyJSON

Added some more accessors/mutators, and param validation
2009-02-03 08:32:40 +00:00
Patrick Donelan
57fb3cb238 Refactored SurveyJSON for perlcritic compliance.
Simplified some code, refactored out some C-isms.
2009-02-03 08:32:06 +00:00
Patrick Donelan
821635eb71 Refactored ResponseJSON and SurveyJSON
Added Params::Validate to ResponseJSON.pm
Refactored ResponseJSON constructor and re-ordered params for
consistency
Added new ->session accessor
Updates tests
Removed unnecessary logging methods
Further refactored SurveyJSON, gave private variables underscores,
replaced direct hash access with accessors
2009-02-03 08:31:43 +00:00
Patrick Donelan
8833459c74 Added param validation to all SurveyJSON.pm methods. 2009-02-03 08:31:24 +00:00
Patrick Donelan
d00c8661f3 Made first argument to SurveyJSON contructor $session for consistency
with rest of wg.

Also added Params::Validate validation.
2009-02-03 08:31:07 +00:00
Patrick Donelan
a1033aeaa2 Replaced all decode/encode_json method calls with to/from_json method
calls now that we've licked the Survey encoding bug (wrong mysql db
field type)
2009-01-27 05:47:36 +00:00
Kaleb Murphy
3a172a9e3d POD docs added 2009-01-26 21:17:46 +00:00
Yung Han Khoe
a612b56e92 adding grade book view to Survey 2009-01-26 14:57:01 +00:00
Patrick Donelan
c4eb4e3b57 Refactored updateQuestionAnswers and addAnswersToQuestion in SurveyJSON 2009-01-26 02:20:28 +00:00
Patrick Donelan
a2d01c34da Fixed a bug where newly created questions would not pre-populate answers
(caused by my refactoring)
2009-01-26 02:20:11 +00:00
Patrick Donelan
8d5e6880c0 More SurveyJSON refactoring (mostly documentation) 2009-01-21 05:34:58 +00:00
Patrick Donelan
102ec0dd25 More SurveyJSON refactoring.. 2009-01-21 05:34:41 +00:00
Patrick Donelan
ef7c0cfaa1 More SurveJSON refactoring (mostly documentation and simple code
changes)
2009-01-21 05:34:23 +00:00
Patrick Donelan
fe32551bca Added totalSections/Questions/Answers helper subs, refactored
getDragDropList to use helper subs, and added extra $address param
documentation.
2009-01-21 03:34:22 +00:00
Patrick Donelan
6d10570fdb Refactored SurveyJSON's new, freeze and addObject for readability 2009-01-20 07:34:55 +00:00
Patrick Donelan
c4540a96ee Replaces to_json and from_json with encode_json/decode_json to properly
handle non-ascii user input (e.g. MS Word apostrophe)
2009-01-19 03:33:07 +00:00
Yung Han Khoe
46cca4fae1 rfe 9200: Survey Text/TextArea handling 2009-01-15 14:17:40 +00:00
Patrick Donelan
a02cbf95a7 More minor edits from flux branch 2009-01-14 06:15:10 +00:00
Patrick Donelan
b7520da07d Merge commit 'tags/WebGUI_7.6.8-beta' into survey-rfe
* commit 'tags/WebGUI_7.6.8-beta': (96 commits)
  Release 7.6.8-beta
  preparing for 7.6.8 release
  convert to new storage format
  fixing photo comment test
  fixed: Syndicated Content corrupts wide characters
  Add the WikiPage to the list of contributions shown in the Account Contributions tab.
  added #!/usr/bin/env perl to all utility scripts
  Forward port i18n fix for Gallery Album RSS list.
  Fix some Survey i18n typos in the time limit hoverhelp.
  Large batch of Help and i18n.  Also, make sure that the
  Fix a typo in the i18n help for the ITransact Pay Driver.
  Correct dataform captcha variable name in the help.
  Forward porting expanded patch for handling deleted things.
  Have Thingy check for existance of table and column to prevent
  Fix linking to other things and autocreating the form field for it.
  Update test to match fixed code.
  Remove the warnings pragma
  Only resize photos if they are larger than the Gallery resolutions.
  Fix a syntax error made in the i18n of the search button.
  I18n'ed a submit button in the manage transactions screen.
  ...

Conflicts:

	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/SurveyJSON.pm
	www/extras/wobject/Survey/editsurvey.js
	www/extras/wobject/Survey/editsurvey/object.js
2009-01-14 06:00:06 +00:00
Kaleb Murphy
5741d71445 Corrected survey timeout issues. 2008-12-17 14:46:54 +00:00
Patrick Donelan
fc3851705a Implemented Survey branching expressions (#9233). Woot! 2008-12-15 10:25:44 +00:00
Patrick Donelan
ad0f3b388d SurveyJSON->update() should iterate over supplied object keys, not
existing object keys. Also applied PBP formatting, fat commas, etc..
2008-12-15 10:25:22 +00:00
Patrick Donelan
fa04344b7d SurveyJSON->update() should iterate over supplied object keys, not
existing object keys. Also applied PBP formatting, fat commas, etc..
2008-12-15 05:52:07 +00:00
Colin Kuskie
941240370b Add a mutator for questionsAnswered, with tests.
Correct POD for recordResponses.
Begin recordResponses answer processing tests.
2008-12-15 00:09:03 +00:00
Colin Kuskie
ad00b0f082 Flesh out the recordResponses POD. Almost ready for more in depth testing. 2008-12-14 04:56:43 +00:00
Colin Kuskie
aa04599aec recordResponse tests (just a few)
Fix a bug where if a section is terminal, and has no questions, it did not return the terminal flag as true.
A little recordResponse POD.
2008-12-13 03:56:26 +00:00
Colin Kuskie
3c7162fb8f Add POD stubs, fully document goto.
Prevent recordResponses from autovivifying mcHash keys.  From page to page of
questions it does not matter, but if two questions in the same page have an
unrecognized, type, the second will be processed differently from the first.
2008-12-12 23:33:33 +00:00
Colin Kuskie
574d6cf036 nextQuestions tests.
Add POD, and make sure that answers returned by nextQuestions are safe refs.
2008-12-12 19:27:12 +00:00
Colin Kuskie
5fe0a7cbe2 Add section separator comments between the subroutines.
Add a few checks to getNextSection* so that it won't autovivify array elements
past the end of the survey order array.
2008-12-12 17:03:10 +00:00
Colin Kuskie
98294e4e78 Add tests for nextSectionid, nextSection, currentSection.
Add more POD to ResponseJSON
2008-12-12 00:36:08 +00:00
Colin Kuskie
c60393e44a Tests for createSurveyOrder and shuffle.
POD for several methods.
2008-12-12 00:03:16 +00:00
Colin Kuskie
1c1f01d473 Change ResponseJSON to use a proper mutator for startTime.
Add tests for startTime.
Survey uses the accessor, and no longer needs to manually set startTime.
2008-12-11 19:45:19 +00:00
Colin Kuskie
08bf6b5147 Flesh out the ResponseJSON test more. Add POD. 2008-12-10 02:25:42 +00:00
Colin Kuskie
931b502666 Update SurveyJSON POD for the new method.
Add legal and header POD for ResponseJSON.
2008-12-06 00:23:17 +00:00
Kaleb Murphy
3671e80bea terminal sections now work correctly 2008-12-05 23:53:11 +00:00
Kaleb Murphy
4d1f311c42 Fixed hasTimeLimit to work with the new storage location of the time limit. 2008-12-05 21:43:15 +00:00
Colin Kuskie
8ea45fe456 Switch to using dclone from Clone::clone due to bugs under
perl 5.10
2008-12-05 04:21:43 +00:00
Colin Kuskie
a50c27de67 add POD, fix a few typos.
Add tests for updateQuestionAnswers
2008-12-04 23:35:40 +00:00
Colin Kuskie
75f6497924 Tests for getEditVars, getEditSectionVars and addAnswersToQuestion.
Add POD.
Fix a bug with setting verbatims in addAnswersToQuestion
2008-12-04 22:01:17 +00:00