Commit graph

1629 commits

Author SHA1 Message Date
Colin Kuskie
b2523d8b24 API change to allow filtering messages by userId.
Changes to getMessagesForUser, getMessagePaginator.  With tests.
2009-02-23 12:27:11 -08:00
Colin Kuskie
12de18502a Beginning of Inbox/Message.t testing 2009-02-23 09:09:47 -08:00
Colin Kuskie
92502151f8 Add a test for setDelete. 2009-02-23 09:09:11 -08:00
David Delikat
8adae35947 fixed postfix object notation 2009-02-23 04:51:45 +00:00
Graham Knop
65a0c7bbae allow single quote delimiters for macro parameters 2009-02-23 04:25:17 +00:00
David Delikat
af5ad84fc8 added code and test suite for a series of functions that
identify non-human web clients so that advertising can
eliminate ghost impressions and ghost clicks
2009-02-23 00:20:46 +00:00
Colin Kuskie
7684aa6e53 Add a quick, 1-off profile category test. 2009-02-21 23:17:25 +00:00
Colin Kuskie
118a05a00c Handle the case when CODE_COP=0 2009-02-21 22:22:05 +00:00
Colin Kuskie
9988f6a116 Add a check for keys with spaces. 2009-02-21 22:19:46 +00:00
Graham Knop
e596489f10 adjust template i18n test to use the real macro parser 2009-02-21 22:17:24 +00:00
Colin Kuskie
f509317d55 Complete the Asset/Wobject/Matrix.t fix by using the newly calculated assetId in the test. 2009-02-21 02:24:34 +00:00
Colin Kuskie
f0b025e855 Update International test for new International module. 2009-02-21 02:16:15 +00:00
Colin Kuskie
cdcdd2951f Clean up after the newly modified DeleteExpiredSession test. 2009-02-21 02:06:22 +00:00
Graham Knop
24da723629 updating copyright year 2009-02-20 23:47:30 +00:00
Colin Kuskie
8b06f912ca Rewrite the DeleteExpiredSessions test to not take cheap shortcuts
that are not very reliable.
2009-02-20 22:31:03 +00:00
Colin Kuskie
4ee2e59f1d Add a test to make sure that update does not erase values that it is not given. 2009-02-19 18:09:32 +00:00
Colin Kuskie
d4fb48f77d Fix a bad test that will fail when we upgrade to mysql 5.1 2009-02-19 16:35:46 +00:00
Graham Knop
e5ede77c29 use char instead of varchar 2009-02-18 03:18:20 +00:00
Colin Kuskie
c90fa56507 Make WebGUI::PseudoRequest work with fatals. Cookies are now mocked and
tied off inside that package.  ErrorHandler uses the session request object,
instead of RequestUtil.
2009-02-18 02:46:59 +00:00
Graham Knop
2079266627 fix matrix test function 2009-02-17 20:53:09 +00:00
Colin Kuskie
96c15c56b2 Optimize canShowDebug for speed by caching the calculated check. 2009-02-16 21:03:31 +00:00
Patrick Donelan
50091e8e3a Started working on Survey Multiple Choice bundle management. 2009-02-16 00:13:58 +00:00
Patrick Donelan
34340e56fb Added Survey::surveyJSON_* convenience methods that auto-persist to the db 2009-02-12 01:07:22 +00:00
Patrick Donelan
7128a3d07c More Survey.pm refactoring
Turned getResponseId into a lazy-loading responseId mutator
Added responseIdCookies flag as a workaround for WebGUI::Test::getPage's
lack of cookie support
2009-02-11 09:27:31 +00:00
Patrick Donelan
e139136d08 Made Survey->surveyJSON lazy-load so that you don't have to call
loadSurveyJSON() everywhere.
2009-02-11 09:26:50 +00:00
Patrick Donelan
8d7599d781 Moved Survey.pm's "survey" and "response" properties to private hash
vars and added accessors.

So that you don't end up with mind-bending code that looks like:
$survey->survey->{survey}
2009-02-11 09:26:27 +00:00
Patrick Donelan
d882181fd1 Started refactoring the Survey.pm Wobject class
Refactored www_jumpTo and added tests
Added Params::Validate
Improved docs
Made call to SurveyJSON->createSurveyOrder() unnecessary
Turned ResponseJSON->nextResponse a mutator
2009-02-11 09:25:42 +00:00
Graham Knop
1edc66367e Spectre tests shouldn't need WRE to run 2009-02-10 22:54:54 +00:00
Graham Knop
a8dab0ac03 fix exif test 2009-02-10 21:41:48 +00:00
Graham Knop
bf9bd2f0d2 use proper JSON encoding/decoding 2009-02-10 21:41:36 +00:00
Colin Kuskie
5d8ede926c use PseudoRequest to stop some test warnings 2009-02-10 20:24:34 +00:00
Colin Kuskie
2482c0f89f Remove tests from FetchMimeType that just were setup to help Fedora pass. 2009-02-10 17:26:29 +00:00
Patrick Donelan
b0c5c09461 Merge branch 'master' into survey
* master: (127 commits)
  Prefill in the email address in the ITransact credentials form from the user's Shop address.
  fixed Matrix best/worst rated lists
  Fix bad form variable for phone number in EMS Badge address info.
  - Added a switch to allow the use of non-WebGUI objects with the Workflow
  fixing a problem with previous survey fix
  fixed #9671: Survey - breaks admin bar
  fixed a Matrix sql problem
  i18n the image labels and title for the asset manager, manage screen.
  Prevent an imported package from changing the a current asset's status from pending to anything else.
  Remove trailing comma in Shop/Transaction JS so IE6 works.
  fixed documentation
  fixed a bug when a matrix listing didn't have a forum attached
  small char encoding fix to merged upgrade
  fix small issue in addChild
  adding merge point
  Fix a problem with purging an EMS.
  Update this template so that it passes the template i18n test.
  Fix a broken i18n label in answer edit template for the Survey.
  Unify all Survey CSS into 1 file, and use it.
  Adding/fixing Survey i18n and Help
  ...

Conflicts:
	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/ResponseJSON.pm
	lib/WebGUI/i18n/English/Asset_Survey.pm
	www/extras/wobject/Survey/editsurvey/object.js
2009-02-10 07:57:42 +00:00
Patrick Donelan
306502465c Started refactoring nextQuestions in ResponseJSON
Made perlcritic happier
Extracted getQuestionResponses from processGotoExpression
Eliminated getPreviousAnswer
2009-02-06 01:56:54 +00:00
Patrick Donelan
345989370f Renamed ResponseJSON branching methods 2009-02-06 01:56:18 +00:00
Patrick Donelan
932a033b58 More ResponseJSON refactoring
Removed unnecessary $session argument from recordResponses
Refactored nextQuestions to return a list rather than an arrayref
Lots more documentation for ResponseJSON
More param validation for ResponseJSON
Refactored recordResponses
Updated tests
2009-02-06 01:55:56 +00:00
Patrick Donelan
90d314d2f1 Refactored next/last response/section related accessors and mutators
(and tests).

Added more documentation.
2009-02-06 01:55:33 +00:00
Patrick Donelan
669e986189 Replaced ResponseJSON's implementation of shuffle with List::Util's
shuffle and updated Colin's ninja shuffle tests
2009-02-04 02:05:44 +00:00
Colin Kuskie
3e326cf25d Update the templateChecker test to look at extra head tags instead of the defunct
headBlock.  Add URL to the output to make working with wgd easy.
2009-02-03 22:24:02 +00:00
Colin Kuskie
ca208699a4 Make test pass when there are no failures. Yes, it does seem strange. 2009-02-03 22:00:00 +00:00
Colin Kuskie
a17e4288ba Remove tests for file content that do not work because files stream.
Update error message in test to match how the code works.
2009-02-03 20:27:36 +00:00
Patrick Donelan
66a2adcbe5 Moved ResponseJSON data hash to private variable, for security and
consistency with SurveyJSON

Added some more accessors/mutators, and param validation
2009-02-03 08:32:40 +00:00
Patrick Donelan
821635eb71 Refactored ResponseJSON and SurveyJSON
Added Params::Validate to ResponseJSON.pm
Refactored ResponseJSON constructor and re-ordered params for
consistency
Added new ->session accessor
Updates tests
Removed unnecessary logging methods
Further refactored SurveyJSON, gave private variables underscores,
replaced direct hash access with accessors
2009-02-03 08:31:43 +00:00
Patrick Donelan
d00c8661f3 Made first argument to SurveyJSON contructor $session for consistency
with rest of wg.

Also added Params::Validate validation.
2009-02-03 08:31:07 +00:00
Colin Kuskie
151ebbde09 Also leaking a version tag. 2009-02-03 04:23:22 +00:00
Colin Kuskie
4ac37757ca Fix a leaking test. 2009-02-03 04:09:01 +00:00
Colin Kuskie
826089f075 Add a test to check for hardcoded extras in templates, and
in the extra head tags of all assets.
2009-01-30 16:49:00 +00:00
Colin Kuskie
ee9369392d Fix a test I broke with the i18n refactor for the GalleryFile 2009-01-29 23:46:39 +00:00
Colin Kuskie
83ca676be5 We want to add tests, not logically or them... 2009-01-29 06:00:50 +00:00
Graham Knop
2bc81f7757 fixing tests for Form changes 2009-01-28 16:39:38 +00:00