Commit graph

69 commits

Author SHA1 Message Date
Colin Kuskie
be37f12ab1 Clone stopped working in several tests in 5.14.2. Remove it in favor of Storable::dclone.
Clone handles being passed scalar data, but dclone does not.
2012-10-23 10:00:53 -07:00
Colin Kuskie
d76ff6ef33 Disable LDAP testing for the time being. 2011-08-30 14:53:17 -07:00
Colin Kuskie
e65368c7c1 Fix group membership by scratch variables for Visitor. Fixes bug #12195. Kudos to trex for the base patch. Also fix the same problem in the IP based group membership. 2011-08-22 19:17:58 -07:00
Colin Kuskie
8ab2dcca05 Fix cleanup and spelling issues with Group.t 2011-08-22 17:24:06 -07:00
Colin Kuskie
8f687d8aa5 Write a test to make sure Group->new returns undef for non-existant groupIds. 2011-04-01 15:13:16 -07:00
Doug Bell
5f89a281e9 fix #11965: FriendMgr pagination and getUsersNotIn 2010-11-16 13:26:38 -06:00
Colin Kuskie
cb2bb75d23 Remove notes and diags 2010-08-10 16:32:10 -07:00
Colin Kuskie
0b2d78ed71 More END block cleanups, 7 to go. 2010-06-15 16:49:34 -07:00
Graham Knop
b832deecd1 convert all cleanup methods to addToCleanup 2010-06-10 10:09:53 -05:00
Scott Walters
867095d811 A user removed from a group with deleteUsers() will still appear to be in that
group according to Inbox.pm, User::getGroupIdsRecursive() and User::getGroups().
Groups.pm wasn't clearing the cache key "getGroupsForUser" in clearCaches().
Tests and fix.
2010-06-08 13:49:02 -04:00
Colin Kuskie
d2b6a7fff1 Fix a bug in how groups using IP filters cache the user Visitor. Also, significant speedups in group lookups. Fixes bug #11552. 2010-05-16 22:11:33 -07:00
Colin Kuskie
26f7dd8bca Bug #11082: Admin group has been removed from Visitor Group. 2009-10-02 14:13:45 -07:00
Colin Kuskie
da41082cbf Have just 1 list of groups that should not be deleted. 2009-07-05 20:33:31 +00:00
Colin Kuskie
02bf1db238 Add a test to check for the override of expire time in addUsers. 2009-05-10 02:21:18 +00:00
Colin Kuskie
004b8095a1 Add method to clean up test sessions. This has to be done
after ALL other types of objects have been cleaned up.
More test clean-up for users, groups and sessions.
2009-05-01 02:02:12 +00:00
Colin Kuskie
ddd06c2ede Provide a way for WebGUI::Test to register groups to clean up at
the end of a test.
Convert several tests to use that, including Post.t, which leaked Groups.
2009-04-13 02:45:03 +00:00
Colin Kuskie
22665cbdf3 Add a few tests for Group coverage. 2009-04-04 02:33:33 +00:00
Colin Kuskie
4e78593395 Change tests to use the automatic backup of Settings in END blocks. 2009-03-30 20:41:02 +00:00
Graham Knop
24da723629 updating copyright year 2009-02-20 23:47:30 +00:00
Graham Knop
e5ede77c29 use char instead of varchar 2009-02-18 03:18:20 +00:00
Colin Kuskie
99adc3f0c2 add coverage tests for Group.t, isUserAdmin 2008-10-14 23:05:54 +00:00
Graham Knop
bbdcb6475a quiet some warnings 2008-09-30 20:03:52 +00:00
Doug Bell
4b82481594 changed User.t and Group.t to use a less used ip address to make tests pass on my network that uses 192.168.0.0/16\
fixed a logic bug in WebGUI/Workflow/Cron
2008-02-18 06:08:16 +00:00
JT Smith
93b5ca16e4 updating copyright year 2008-02-07 23:28:18 +00:00
Colin Kuskie
1e1e7a2afa Clean up left-over scratch in two tests to try and get
Workflow/Activity/DeleteExpiredSessions to work in the smoke
tests.
Comment out the two failing tests in Asset.t until my bug
gets answered.  Turns out you can't TODO them because
it requires using Test::Builder instead of Test::More.
2007-12-31 02:12:12 +00:00
Colin Kuskie
8b84ae3e76 Up coverage of addGroups to 100%.
Change tabs to spaces in group diagrams.
Optimize the addGroups membership check so the expensive getGroupsIn
doesn't have to take place.
Add a label to the foreach.
2007-11-26 05:13:32 +00:00
Colin Kuskie
83310ba311 update copyright on tests 2007-07-07 03:56:44 +00:00
Colin Kuskie
ec3eebda9b remove duplicate code in addUsers, add more tests to Group.t to cover 2007-03-07 00:16:22 +00:00
Colin Kuskie
e17e1f7e4f coverage tests for Group.pm convenience methods 2007-03-04 06:22:57 +00:00
Colin Kuskie
70d7bb2513 Remove some dead code in Group.t
Add more tests for coverage in User.t
2007-02-25 05:57:54 +00:00
Colin Kuskie
751adbcf30 more delta time fixes 2006-08-04 17:53:32 +00:00
Colin Kuskie
b02a93b491 change time difference test to handle bridging across 1 second and be more verbose in output 2006-08-04 16:00:12 +00:00
Colin Kuskie
0be1193574 adding test for id returned from calling find with a non-existant group name 2006-07-24 05:03:28 +00:00
Colin Kuskie
dae8c4c22f Fix bug where Admins are not in the Visitor group. Add a test to verify this going forward. 2006-07-15 02:30:53 +00:00
Colin Kuskie
e1b7082ac5 clean up all groups in Group.t 2006-07-13 05:29:21 +00:00
Colin Kuskie
206a294988 Fix bug where groups were being created with no defaults.
Update Group test to check for default values in groups created
with gid "new" and "".
2006-06-30 05:14:28 +00:00
Colin Kuskie
7100d1df41 Add a new method called getAllGroupsFor, which recursively returns ALL groups
that a group belongs to.  This is required to properly uncache group settings
for groups with more than 2 levels of hierarchy.

Add 7 tests to verify the working of the new method.

Fix a typo in the POD for Operation/Group.pm
2006-05-26 16:43:47 +00:00
Colin Kuskie
daa0accf45 fill in the remaining tests for users and groups 2006-05-18 03:21:30 +00:00
Colin Kuskie
aea9ce76f7 Bust group caches and caches of groups containting this group
whenever the group is edited, or when users or groups are added
or deleted.
Add a test to check adding users.
2006-05-17 23:16:11 +00:00
Colin Kuskie
499981d092 removing diag to clean up smoke test output 2006-04-20 18:43:20 +00:00
Colin Kuskie
cb2a8d025e I am 4 kinds of fool 2006-04-15 16:51:23 +00:00
Colin Kuskie
bbd17516e8 add cache clearing to end of User and Group tests, too 2006-04-15 02:36:52 +00:00
Colin Kuskie
1c6fec6695 Flush cache for User and Group tests to pass.
Add group cache clear to Group.pm
templateId clash due fixed
2006-04-15 02:32:38 +00:00
Colin Kuskie
2f5dab37d2 finalized Group code with migration and upgrade log 2006-04-14 01:17:39 +00:00
Colin Kuskie
b0356f06a0 update test to use new method name 2006-04-13 22:52:16 +00:00
Colin Kuskie
8b8b4af41b Checkpoint before final conversion.
Added getIpUsers method to Group.pm
Group->getUsers and User->isInGroup both use getIpUsers
Tests added to Group.t to verify that getIpUsers works.
2006-04-11 21:17:30 +00:00
Colin Kuskie
e5e9cd9b51 add tests for scratch users and migrate getUsers,isInGroup to use it 2006-04-07 20:42:36 +00:00
Colin Kuskie
f9b8582426 Scratch filter tests in prep for WebGUI::Group->getScratchUsers
Small tweaks for User.pm scratch and Group.pm POD
Update scratchFilter docs to show how to place multiple name and value pairs
2006-04-06 22:02:54 +00:00
Colin Kuskie
3e179fa4ad Group.t: group karma tests, better clean-up at end
User.t: better clean-up at end
Scratch.t: no newlines in test output
Session/Scratch.pm: convert to use placeholders
Ad.pm: Add missing line of POD.
Group.pm: add method to get all users in a group by karma.
User.pm: isInGroup to use getKarmaUsers.
2006-04-06 16:52:34 +00:00
Colin Kuskie
510c1f5ca5 Modify User.pm and Group.pm to consider external means of defining users,
such as a dbQuery.  This would happened coincidently before, but required
doing a User->isInGroup and only added members who were searched for rather
than all members.
Modify Group.t to test this.
Update POD in SQL.pm.
2006-04-05 18:35:26 +00:00