Commit graph

564 commits

Author SHA1 Message Date
Colin Kuskie
61b4e1e826 Never delete an asset property key. 2009-06-20 00:16:34 +00:00
Patrick Donelan
cbc308c55a SurveyJSON size reduction/optimization
SurveyJSON was storing a lot of redundant information (every setting on
every single section/question/answer, which, in most cases, will simply
take on the default values). This was bloating the surveyJSON property in
the db, and equally as importantly, slowing down Survey because it had to
do a lot of JSON parsing on the serialised surveyJSON object.

We now factor out and store the current section/question/answer defaults
along with the surveyJSON data itself, which means that we only needs to
store properties that differ from the defaults. This results is a massive
reduction in the size of the serialized surveyJSON stored in the database,
as well as a speed-up in json parsing time.

The compression/uncompression happens transparently to the rest of Survey.
2009-06-19 08:07:18 +00:00
Colin Kuskie
3bc2006991 Make the new getPackageList functionally equivalent to the old one. 2009-06-17 01:11:22 +00:00
Colin Kuskie
914620f5a4 Performance improvements with getting the lists of packages when there
are lots of assets.
2009-06-17 00:53:47 +00:00
Patrick Donelan
d820d43760 Fixed #10520 - Survey responses get confused if survey structure modified
Survey responses are now revision-aware.
The survey structure gets revisioned automatically as necessary when changes
are made on the Edit Survey screen (as necessary ~~ a response exists
for the current revision)
2009-06-16 06:25:38 +00:00
Patrick Donelan
3e5d5804f6 Made Survey tests a little less dependent on multiple choice bundle defaults 2009-06-16 06:25:09 +00:00
Colin Kuskie
f5851c96ff Graceful dying without TAP::Harness v3 2009-06-11 17:03:32 +00:00
Yung Han Khoe
be430dfdd2 fixed #9953: Matrix 2.0 - Not enough tests 2009-06-10 18:46:15 +00:00
Patrick Donelan
9004e5d711 Survey cleanup and minor bug fixes
Cleaned up edit page tabs
Improved API docs
Added noCreate option to responseId so that it doesn't create unnecessary responses
Added groupToTakeSurvey priv check to takeSurvey
2009-06-09 03:27:06 +00:00
Colin Kuskie
8a683d1aef Better template diagnostics on failure. It now also includes the template URL, and templateId
in both the onscreen and logged output.
2009-06-08 16:53:53 +00:00
Doug Bell
cbe138d16e added tests for getAdjacentThread 2009-06-05 17:31:01 +00:00
Doug Bell
75640eed59 fixed problem in test using <=> instead of cmp 2009-06-05 17:30:50 +00:00
Doug Bell
457f7f2dc6 added test for adjacent threads 2009-06-05 17:30:42 +00:00
Yung Han Khoe
15b197976e Adding Matrix tests 2009-06-03 13:22:32 +00:00
Patrick Donelan
5acade845a Fixed Survey test suite 'tagged' check to work with nested data 2009-06-03 07:15:52 +00:00
Patrick Donelan
9702ffcaac Fixed Survey section-level branch precedence bug
For Sections with questions spread out over multiple pages, branch
expressions should only happen on the last page of the Section.
Added explicit test.
2009-06-03 02:12:00 +00:00
Patrick Donelan
da595da89e Remove bloat from Survey response record to reduce json serialisation time 2009-06-03 02:11:31 +00:00
Patrick Donelan
216a48580a Fixed #9927 Survey - verbatim
Fixed inconsistencies between answer 'comment' and 'verbatim'.
Updated tests.
Made minor changes to reporting methods but they still need some love.
2009-06-03 00:29:29 +00:00
Doug Bell
939ad5a4bf added tests for packed templates 2009-06-02 08:28:52 +00:00
Patrick Donelan
084a0c3105 Fixed naff Survey::takenCount bug, added explicit test for it 2009-06-02 02:42:37 +00:00
Colin Kuskie
8f09dc062d Add edit and delete icons to the Story Topic. Update tests. Adjust both
sets of templates.  Use the correct privileges for displaying the icons.
Help and i18n.
2009-06-01 16:53:22 +00:00
Colin Kuskie
20a333cde8 Change caching on the SQLReport to be set by its cacheTimeout, even
when viewed standalone, and not part of a page.
2009-05-30 18:01:59 +00:00
Colin Kuskie
0bf47be7f4 Add a basic test for the Poll, adding votes and making a graph.
Add POD to Poll for setVote, and use placeholders in there.
2009-05-29 18:54:26 +00:00
Patrick Donelan
1a4b673843 Made Survey Test Suite feature was dependent on TAP::Parser and TAP::Parser::Aggregator 2009-05-29 01:04:45 +00:00
Colin Kuskie
67cce548ff Add enableSurveyExpressionEngine to default WebGUI conf file.
Rerun the upgrade subroutine to handle newer surveys.
Handle the config option being off in Survey/Test.t
2009-05-28 23:28:52 +00:00
Colin Kuskie
b74761619e More SKIP number fixes. 2009-05-28 23:03:19 +00:00
Colin Kuskie
4dd1089a00 Update test to track Matrix code for getListings. 2009-05-28 15:57:51 +00:00
Patrick Donelan
beff1d2166 Survey NYTProf performance improvements
initSurveyOrder now builds a lookup cache to speed up branching
Test suite caches surveyOrder and response itself
Unnecessary sub calls reduced
Updated tests
My largest survey instance test suite, which contains > 1000 tests,
now runs nearly 8 times faster.
2009-05-28 07:24:11 +00:00
Patrick Donelan
d14cf19e9d Added Survey tests for more question types 2009-05-28 07:23:43 +00:00
Colin Kuskie
83497b773e Fix Story permissions so that admin need not be turned on.
canEdit is now determined by the Story and the parent StoryArchive.
With tests, and template changes.
2009-05-28 04:15:50 +00:00
Yung Han Khoe
dc48bd270b adding some Matrix tests 2009-05-25 15:22:23 +00:00
Colin Kuskie
689e645e51 Forward porting tests with better cleanups. 2009-05-25 04:42:40 +00:00
David Delikat
a054c9de73 added date pagination to EMS schedule table
also improved formatting of table
2009-05-24 22:51:39 +00:00
Patrick Donelan
3a25e806c6 Survey bug fixes
Fixed bugs in the handling of logical sections,
creating of responses and counting of responses.
Added in a bunch of new tests.
Jslinting of all survye js files
2009-05-23 09:54:03 +00:00
Colin Kuskie
d3a874dd36 Update AssetExportHtml test to match new API for 7.7 2009-05-21 16:02:37 +00:00
Patrick Donelan
302e217e7a Survey test suite added support for checking answer properties 2009-05-21 08:22:11 +00:00
Patrick Donelan
f55559e124 Survey: fixed subtle bug in testing of answers with recordedAnswer set to q{} 2009-05-21 08:21:54 +00:00
Patrick Donelan
d246454b2f Survey: fixed bugs in handling of test setup & Slider question type 2009-05-21 08:21:35 +00:00
Patrick Donelan
8baf09948e Fixed bug where ResponseJSON was not properly resetting between
tests. Refactored out reset() sub to make it easy for people to
achieve reliable resetting of rJSON objects.
2009-05-21 08:21:17 +00:00
Colin Kuskie
558fba2f6a Cleanup in Post tests. Set skipNotification to prevent emails from being queued during the tests. 2009-05-20 03:29:17 +00:00
David Delikat
0fb2b7775d added EMS Schedule table 2009-05-20 02:51:44 +00:00
Colin Kuskie
8de4e6fed2 Clean up changes to admin user, who has no friends. 2009-05-20 01:32:04 +00:00
Colin Kuskie
f06b8c08fb In Thread tests, too. 2009-05-20 00:59:20 +00:00
Colin Kuskie
9d1829d5f5 Prevent emails from being sent out during the creation of assets. 2009-05-20 00:58:11 +00:00
Patrick Donelan
59329e9718 Survey tweaks
Added Survey 'Tagged' question type, which builds its answers dynamically from tagged data
Made Survey test suite more forgiving about JSON parsing
2009-05-19 02:45:45 +00:00
Patrick Donelan
a9638ae691 Survey: Let them eat sort 2009-05-19 02:45:26 +00:00
Patrick Donelan
9cbd30c3d8 Refactored Survey test suite diagnostics etc.. 2009-05-17 08:15:59 +00:00
Patrick Donelan
3105b27034 Improved Survey test setup 2009-05-16 09:06:00 +00:00
Patrick Donelan
4d181da7f9 SurveyJSON bug fixes
Fixed bug in SurveyJSON::update to stop it updating questionType when not asked
Fixed unsafe reference bug in SurveyJSON::getMultipleChoiceBundle
Added more Survey Test Suite tests
2009-05-16 07:24:55 +00:00
Patrick Donelan
7e0796cc78 Some minor Survey bug fixes
Removed evil "use JSON -support_by_pp"
test() and test_mc() now intelligently start at the right place and give better TAP descriptions
2009-05-16 01:13:20 +00:00