Commit graph

157 commits

Author SHA1 Message Date
Patrick Donelan
5da0379f99 Updated SurveyJSON tests to recognise goto[Expression] on Section and Question 2009-03-11 15:29:04 +11:00
Patrick Donelan
7ec5cab126 Merge branch 'master' into survey
* master: (121 commits)
  Fix a POD typo.
  correct inbox message from user preface
  Fix a typo in the Default gallery view template
  Documentation bug in buildArrayRefOfHashRefs
  changed screenshots in Matrix Listing view to popup
  matrix privileging fixes
  Fix an i18n typo in the Post user defined variables.
  Remove debugging code.
  approval workflow fix
  matrix upgrade and privileging fixes
  fixed: Template parser cannot be set
  forward porting gallery bug fixes
  preparing for 7.7.0 dev
  parser should be a selectbox, not a selectlist.
  labeling survey as beta
  fixeding my borkes to the changelog
  fixed #9852: Users can accept private messages from Visitor, but Visitor cannot send messages
  preparing for 7.6.14 release
  fix AdSpace, Ad tests
  Restore the original properties for the profile category that was modified for test.
  ...

Conflicts:
	docs/gotcha.txt
	docs/upgrades/upgrade_7.6.10-7.6.11.pl
	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/SurveyJSON.pm
2009-03-11 15:26:07 +11:00
Graham Knop
d7649d3212 survey test fix 2009-03-03 17:07:53 +00:00
Colin Kuskie
f509317d55 Complete the Asset/Wobject/Matrix.t fix by using the newly calculated assetId in the test. 2009-02-21 02:24:34 +00:00
Graham Knop
24da723629 updating copyright year 2009-02-20 23:47:30 +00:00
Graham Knop
2079266627 fix matrix test function 2009-02-17 20:53:09 +00:00
Patrick Donelan
50091e8e3a Started working on Survey Multiple Choice bundle management. 2009-02-16 00:13:58 +00:00
Patrick Donelan
34340e56fb Added Survey::surveyJSON_* convenience methods that auto-persist to the db 2009-02-12 01:07:22 +00:00
Patrick Donelan
7128a3d07c More Survey.pm refactoring
Turned getResponseId into a lazy-loading responseId mutator
Added responseIdCookies flag as a workaround for WebGUI::Test::getPage's
lack of cookie support
2009-02-11 09:27:31 +00:00
Patrick Donelan
e139136d08 Made Survey->surveyJSON lazy-load so that you don't have to call
loadSurveyJSON() everywhere.
2009-02-11 09:26:50 +00:00
Patrick Donelan
8d7599d781 Moved Survey.pm's "survey" and "response" properties to private hash
vars and added accessors.

So that you don't end up with mind-bending code that looks like:
$survey->survey->{survey}
2009-02-11 09:26:27 +00:00
Patrick Donelan
d882181fd1 Started refactoring the Survey.pm Wobject class
Refactored www_jumpTo and added tests
Added Params::Validate
Improved docs
Made call to SurveyJSON->createSurveyOrder() unnecessary
Turned ResponseJSON->nextResponse a mutator
2009-02-11 09:25:42 +00:00
Graham Knop
bf9bd2f0d2 use proper JSON encoding/decoding 2009-02-10 21:41:36 +00:00
Patrick Donelan
306502465c Started refactoring nextQuestions in ResponseJSON
Made perlcritic happier
Extracted getQuestionResponses from processGotoExpression
Eliminated getPreviousAnswer
2009-02-06 01:56:54 +00:00
Patrick Donelan
345989370f Renamed ResponseJSON branching methods 2009-02-06 01:56:18 +00:00
Patrick Donelan
932a033b58 More ResponseJSON refactoring
Removed unnecessary $session argument from recordResponses
Refactored nextQuestions to return a list rather than an arrayref
Lots more documentation for ResponseJSON
More param validation for ResponseJSON
Refactored recordResponses
Updated tests
2009-02-06 01:55:56 +00:00
Patrick Donelan
90d314d2f1 Refactored next/last response/section related accessors and mutators
(and tests).

Added more documentation.
2009-02-06 01:55:33 +00:00
Patrick Donelan
669e986189 Replaced ResponseJSON's implementation of shuffle with List::Util's
shuffle and updated Colin's ninja shuffle tests
2009-02-04 02:05:44 +00:00
Patrick Donelan
66a2adcbe5 Moved ResponseJSON data hash to private variable, for security and
consistency with SurveyJSON

Added some more accessors/mutators, and param validation
2009-02-03 08:32:40 +00:00
Patrick Donelan
821635eb71 Refactored ResponseJSON and SurveyJSON
Added Params::Validate to ResponseJSON.pm
Refactored ResponseJSON constructor and re-ordered params for
consistency
Added new ->session accessor
Updates tests
Removed unnecessary logging methods
Further refactored SurveyJSON, gave private variables underscores,
replaced direct hash access with accessors
2009-02-03 08:31:43 +00:00
Patrick Donelan
d00c8661f3 Made first argument to SurveyJSON contructor $session for consistency
with rest of wg.

Also added Params::Validate validation.
2009-02-03 08:31:07 +00:00
Patrick Donelan
fe32551bca Added totalSections/Questions/Answers helper subs, refactored
getDragDropList to use helper subs, and added extra $address param
documentation.
2009-01-21 03:34:22 +00:00
Patrick Donelan
6d10570fdb Refactored SurveyJSON's new, freeze and addObject for readability 2009-01-20 07:34:55 +00:00
Patrick Donelan
34b44def2f Added gotoExpression tests (from flux branch) 2009-01-14 06:14:37 +00:00
Patrick Donelan
b7520da07d Merge commit 'tags/WebGUI_7.6.8-beta' into survey-rfe
* commit 'tags/WebGUI_7.6.8-beta': (96 commits)
  Release 7.6.8-beta
  preparing for 7.6.8 release
  convert to new storage format
  fixing photo comment test
  fixed: Syndicated Content corrupts wide characters
  Add the WikiPage to the list of contributions shown in the Account Contributions tab.
  added #!/usr/bin/env perl to all utility scripts
  Forward port i18n fix for Gallery Album RSS list.
  Fix some Survey i18n typos in the time limit hoverhelp.
  Large batch of Help and i18n.  Also, make sure that the
  Fix a typo in the i18n help for the ITransact Pay Driver.
  Correct dataform captcha variable name in the help.
  Forward porting expanded patch for handling deleted things.
  Have Thingy check for existance of table and column to prevent
  Fix linking to other things and autocreating the form field for it.
  Update test to match fixed code.
  Remove the warnings pragma
  Only resize photos if they are larger than the Gallery resolutions.
  Fix a syntax error made in the i18n of the search button.
  I18n'ed a submit button in the manage transactions screen.
  ...

Conflicts:

	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/SurveyJSON.pm
	www/extras/wobject/Survey/editsurvey.js
	www/extras/wobject/Survey/editsurvey/object.js
2009-01-14 06:00:06 +00:00
Graham Knop
0487acca1d fix Thingy test to account for new template options 2008-12-16 21:13:21 +00:00
Patrick Donelan
fc3851705a Implemented Survey branching expressions (#9233). Woot! 2008-12-15 10:25:44 +00:00
Colin Kuskie
941240370b Add a mutator for questionsAnswered, with tests.
Correct POD for recordResponses.
Begin recordResponses answer processing tests.
2008-12-15 00:09:03 +00:00
Colin Kuskie
aa04599aec recordResponse tests (just a few)
Fix a bug where if a section is terminal, and has no questions, it did not return the terminal flag as true.
A little recordResponse POD.
2008-12-13 03:56:26 +00:00
Colin Kuskie
aafd5e5a2e goto tests. 2008-12-12 23:33:45 +00:00
Colin Kuskie
574d6cf036 nextQuestions tests.
Add POD, and make sure that answers returned by nextQuestions are safe refs.
2008-12-12 19:27:12 +00:00
Colin Kuskie
98294e4e78 Add tests for nextSectionid, nextSection, currentSection.
Add more POD to ResponseJSON
2008-12-12 00:36:08 +00:00
Colin Kuskie
c60393e44a Tests for createSurveyOrder and shuffle.
POD for several methods.
2008-12-12 00:03:16 +00:00
Colin Kuskie
1c1f01d473 Change ResponseJSON to use a proper mutator for startTime.
Add tests for startTime.
Survey uses the accessor, and no longer needs to manually set startTime.
2008-12-11 19:45:19 +00:00
Colin Kuskie
08bf6b5147 Flesh out the ResponseJSON test more. Add POD. 2008-12-10 02:25:42 +00:00
Colin Kuskie
8ea45fe456 Switch to using dclone from Clone::clone due to bugs under
perl 5.10
2008-12-05 04:21:43 +00:00
Colin Kuskie
ace2c81fca update SurveyJSON test to fix perl 5.10 misleading errors 2008-12-05 03:41:29 +00:00
Colin Kuskie
75da4c46bd Add more tests for coverage.
Interim checkin for debug assistance.
2008-12-05 03:32:47 +00:00
Colin Kuskie
a50c27de67 add POD, fix a few typos.
Add tests for updateQuestionAnswers
2008-12-04 23:35:40 +00:00
Colin Kuskie
75f6497924 Tests for getEditVars, getEditSectionVars and addAnswersToQuestion.
Add POD.
Fix a bug with setting verbatims in addAnswersToQuestion
2008-12-04 22:01:17 +00:00
Colin Kuskie
24fe2e6dc0 Add tests for getQuestionEditVars.
Refactor out the list of valid question types to make testing easier.
2008-12-04 20:47:42 +00:00
Colin Kuskie
0453f47bc1 Tests for getDragDrop and getAnswerEditVars.
More POD.
2008-12-04 20:18:49 +00:00
Colin Kuskie
d370772762 Make copy use safe references.
Add tests for remove, and copy.
2008-12-03 04:41:38 +00:00
Colin Kuskie
f41421058c Add wide character JSON encoding test. 2008-12-03 02:39:35 +00:00
Colin Kuskie
23f8e48f6d Update POD for several methods.
Make getObject clone data for safety and update tests.
Make newObject always alter $address for consistency and update tests.
2008-12-01 17:39:34 +00:00
Colin Kuskie
377126da8c Add more POD to SurveyJSON.
Add some basic tests for getObject, update and remove.
2008-11-30 04:30:40 +00:00
Colin Kuskie
020c882fb6 Test abusing references in getObject.
More insertObject testing.
More POD.
2008-11-29 17:29:00 +00:00
Colin Kuskie
fe33c87f13 Add tests for insertObject, and a helper method for summarizing the SurveyJSON data structure.
Add POD for insertObject.  Note that splicing beyond the end of the array will generate
a warning.
2008-11-29 05:32:14 +00:00
Colin Kuskie
63646aa497 rename test 2008-11-28 17:25:40 +00:00
Colin Kuskie
356772b722 Build Survey2 tests. Each survey2 module has at least a basic
load test, and the SurveyJSON module has many more tests in
it, testing new, log, newSection, newQuestion, newAnswer and
newObject.
2008-11-28 05:02:38 +00:00