Hopefully this will make it much easier to deal with later, and hopefully this
will help to flush out the remaining duration-calculation-related bugs by
avoiding repetition of the calculations. Various minor fixes in the process.
I'm not convinced this is completely bug-free yet, of course, but it does
seem at least to be slightly less broken than before, so.
over the users sorted by connection and then by userId, so
that we don't connect once to the LDAP server for each user(!),
and also use the LDAP link properly rather than rolling our own
anonymous bind.
the Session Id. This is by design.
Added a check to Style.pm so that if no params are passed to setLink that
it won't die by trying to deref undef into a hashref.
First set of tests for Session/Style added.
existing timed tasks and milestones in that they have a duration that
increases based on the amount of time tracked for them, and no set
completion time. Nearby minor fixes.
Found and fixed a but in Session/Scratch/deleteNameByValue. It would
not delete any value that was false (0, '' or undef). Added a defined-ness
check to make sure it will delete 0 or '', but undef is still not handled.
Added POD to say that this was the case.
was enabled a noCache param was always added to the URL. In some
cases it would add 2 noCache params.
To fix this, I added a skipPreventProxyCache param to the gateway method,
and page just passes $pairs and $skipPreventProxyCache to gateway.
Added tests to Url.t to test gateway, page, makeAbsolute and urlize
to bring its coverage up to 100%.
Added tests to Stow.t to bring it's coverage up to 100% as well.
Tests for escape, unescape, extras methods. Test code is big enough
that I've added section delimiting comments. This has helped make
the code a lot more readable.
- admin bar causing pages to extend forever
- changing asset URL returning to old URL rather than new
- performance indicators interfering with non-HTML data
Convert it to use placeholders as well.
More WebGUI::Session::Url tests, and some bug fixes:
getRefererUrl returned parameters and accepted weird methods that
looked like http but weren't.
existing overrides and callers for that method and making sure they followed
the correct signature. Various related cleanups.
This should fix those bugs with collaboration systems refusing to be copied
or deployed as packages.
that a new userSessionId will be created and that the current sessionId (the actual
session object's id) will be set to this new id.
Add several new tests to Session/Var.t Tried hard to exploit the change in
sessionId and haven't found a way, yet.
be fixed later.
Added lots of comments to start and new subs. Changed db methods to
use placeholders. Changed timely data to call time once so that they
all match.
