Commit graph

19 commits

Author SHA1 Message Date
Patrick Donelan
821635eb71 Refactored ResponseJSON and SurveyJSON
Added Params::Validate to ResponseJSON.pm
Refactored ResponseJSON constructor and re-ordered params for
consistency
Added new ->session accessor
Updates tests
Removed unnecessary logging methods
Further refactored SurveyJSON, gave private variables underscores,
replaced direct hash access with accessors
2009-02-03 08:31:43 +00:00
Patrick Donelan
d00c8661f3 Made first argument to SurveyJSON contructor $session for consistency
with rest of wg.

Also added Params::Validate validation.
2009-02-03 08:31:07 +00:00
Patrick Donelan
fe32551bca Added totalSections/Questions/Answers helper subs, refactored
getDragDropList to use helper subs, and added extra $address param
documentation.
2009-01-21 03:34:22 +00:00
Patrick Donelan
6d10570fdb Refactored SurveyJSON's new, freeze and addObject for readability 2009-01-20 07:34:55 +00:00
Patrick Donelan
fc3851705a Implemented Survey branching expressions (#9233). Woot! 2008-12-15 10:25:44 +00:00
Colin Kuskie
8ea45fe456 Switch to using dclone from Clone::clone due to bugs under
perl 5.10
2008-12-05 04:21:43 +00:00
Colin Kuskie
ace2c81fca update SurveyJSON test to fix perl 5.10 misleading errors 2008-12-05 03:41:29 +00:00
Colin Kuskie
75da4c46bd Add more tests for coverage.
Interim checkin for debug assistance.
2008-12-05 03:32:47 +00:00
Colin Kuskie
a50c27de67 add POD, fix a few typos.
Add tests for updateQuestionAnswers
2008-12-04 23:35:40 +00:00
Colin Kuskie
75f6497924 Tests for getEditVars, getEditSectionVars and addAnswersToQuestion.
Add POD.
Fix a bug with setting verbatims in addAnswersToQuestion
2008-12-04 22:01:17 +00:00
Colin Kuskie
24fe2e6dc0 Add tests for getQuestionEditVars.
Refactor out the list of valid question types to make testing easier.
2008-12-04 20:47:42 +00:00
Colin Kuskie
0453f47bc1 Tests for getDragDrop and getAnswerEditVars.
More POD.
2008-12-04 20:18:49 +00:00
Colin Kuskie
d370772762 Make copy use safe references.
Add tests for remove, and copy.
2008-12-03 04:41:38 +00:00
Colin Kuskie
f41421058c Add wide character JSON encoding test. 2008-12-03 02:39:35 +00:00
Colin Kuskie
23f8e48f6d Update POD for several methods.
Make getObject clone data for safety and update tests.
Make newObject always alter $address for consistency and update tests.
2008-12-01 17:39:34 +00:00
Colin Kuskie
377126da8c Add more POD to SurveyJSON.
Add some basic tests for getObject, update and remove.
2008-11-30 04:30:40 +00:00
Colin Kuskie
020c882fb6 Test abusing references in getObject.
More insertObject testing.
More POD.
2008-11-29 17:29:00 +00:00
Colin Kuskie
fe33c87f13 Add tests for insertObject, and a helper method for summarizing the SurveyJSON data structure.
Add POD for insertObject.  Note that splicing beyond the end of the array will generate
a warning.
2008-11-29 05:32:14 +00:00
Colin Kuskie
356772b722 Build Survey2 tests. Each survey2 module has at least a basic
load test, and the SurveyJSON module has many more tests in
it, testing new, log, newSection, newQuestion, newAnswer and
newObject.
2008-11-28 05:02:38 +00:00