Commit graph

10842 commits

Author SHA1 Message Date
Patrick Donelan
6fddcdaf5f Refactored returnResponseForReporting 2009-02-06 05:51:08 +00:00
Patrick Donelan
fa6976fb40 More ResponseJSON refactoring.
Finished refactoring nextQuestions()
Added recordedResponses sub
Added getTemplatedText sub
Added sectionId, questionId, answerId, sIndex, qIndex, aIndexes
abstraction subs
2009-02-06 05:15:26 +00:00
JT Smith
36eead4e9c fixed documentation 2009-02-06 04:50:46 +00:00
JT Smith
6701a10491 fixed a bug when a matrix listing didn't have a forum attached 2009-02-06 04:49:57 +00:00
Graham Knop
332ace9648 small char encoding fix to merged upgrade 2009-02-06 03:31:39 +00:00
Patrick Donelan
306502465c Started refactoring nextQuestions in ResponseJSON
Made perlcritic happier
Extracted getQuestionResponses from processGotoExpression
Eliminated getPreviousAnswer
2009-02-06 01:56:54 +00:00
Patrick Donelan
3340a675b7 Updated Survey.pm to use new ResponseJSON.pm methods 2009-02-06 01:56:35 +00:00
Patrick Donelan
345989370f Renamed ResponseJSON branching methods 2009-02-06 01:56:18 +00:00
Patrick Donelan
932a033b58 More ResponseJSON refactoring
Removed unnecessary $session argument from recordResponses
Refactored nextQuestions to return a list rather than an arrayref
Lots more documentation for ResponseJSON
More param validation for ResponseJSON
Refactored recordResponses
Updated tests
2009-02-06 01:55:56 +00:00
Patrick Donelan
90d314d2f1 Refactored next/last response/section related accessors and mutators
(and tests).

Added more documentation.
2009-02-06 01:55:33 +00:00
Graham Knop
ede922e060 fix small issue in addChild 2009-02-06 01:04:27 +00:00
Graham Knop
653fea0aa6 adding merge point 2009-02-06 01:04:16 +00:00
Colin Kuskie
6c61eb54db Fix a problem with purging an EMS. 2009-02-05 23:10:35 +00:00
Colin Kuskie
1cbedd34a8 Update this template so that it passes the template i18n test. 2009-02-05 22:46:56 +00:00
Colin Kuskie
b994216944 Fix a broken i18n label in answer edit template for the Survey. 2009-02-05 22:44:48 +00:00
Colin Kuskie
0d09360cdd Unify all Survey CSS into 1 file, and use it. 2009-02-05 22:36:44 +00:00
Yung Han Khoe
71e7db62c6 Adding/fixing Survey i18n and Help 2009-02-05 22:29:36 +00:00
Colin Kuskie
8bc1417091 Fix bad template code in 4 gallery templates. They were functional, just not
using template variables.
2009-02-05 22:13:14 +00:00
Tabitha Zipperer
c6c78794e5 Updated Data Table templates to be compliant with Rogier's templating project 2009-02-05 20:03:25 +00:00
Graham Knop
fbd118d37e fixed: Permissions aren't correctly applied to Article attachments 2009-02-05 20:02:52 +00:00
Kaleb Murphy
4d4dc3b253 Added survey.css as a snippet. Had been left out. 2009-02-05 16:50:15 +00:00
Kaleb Murphy
f38c821be5 Added survey.css as a snippet. Had been left out. 2009-02-05 16:49:58 +00:00
Colin Kuskie
ddff93418c Fix the display of creationDate in the gallery search template. 2009-02-05 01:56:39 +00:00
Colin Kuskie
4c5397ca71 Document the hoverhelp fix in the changelog. 2009-02-04 23:25:06 +00:00
Colin Kuskie
c4d4182f0f Prototype fix for yellow hoverhelp lines in opera/firefox. 2009-02-04 23:20:53 +00:00
Colin Kuskie
f2f8f22669 When data is successfully saved from the edit user preferences form, make it
redraw the Dashboard, instead of the shortcut.
2009-02-04 22:07:50 +00:00
Colin Kuskie
2c6717d508 Fix a dashboard bug where scripts and css needed by user profile fields were not
sent via an AJAX method in the shortcut.
2009-02-04 21:58:34 +00:00
Colin Kuskie
62a14a2dcc Dates in the galley advanced search were ignored. 2009-02-04 16:58:25 +00:00
Colin Kuskie
a5ad3bf4bd Fix broken subfolder synopsis template variable in the Folder. 2009-02-04 16:30:38 +00:00
Colin Kuskie
b8b2a38ef5 Fix the exitURL redirection when a survey is completed and the site uses a gateway url. 2009-02-04 02:22:21 +00:00
Patrick Donelan
669e986189 Replaced ResponseJSON's implementation of shuffle with List::Util's
shuffle and updated Colin's ninja shuffle tests
2009-02-04 02:05:44 +00:00
Patrick Donelan
477f014177 Improved createSurveyOrder documentation, and made perlcritic happy 2009-02-04 00:16:44 +00:00
Patrick Donelan
6fb325699f Refactored createSurveyOrder in ResponseJSON
Added lastSectionIndex, lastQuestionIndex, lastAswerIndex convenience
methods to SurveyJSON to simplify iterations over Sections, Questions
and Answers
2009-02-04 00:16:26 +00:00
Graham Knop
787fe74ee1 fixed #9623: preload.custom paths not included during upgrade 2009-02-03 23:46:41 +00:00
Colin Kuskie
a8f3d2ea30 Fix dotted assetIds in the database for the WebGUI 7 Style snippets, navigations,
folder and Image assets.
2009-02-03 23:42:59 +00:00
Graham Knop
3433c7c332 fixed #9542: Default WebGUI config contains invalid workflow activity 2009-02-03 23:28:25 +00:00
Colin Kuskie
2c60d6e7a8 Fix broken gateway macros. ^/;file does not work with prevent proxy cache. 2009-02-03 22:25:27 +00:00
Colin Kuskie
3e326cf25d Update the templateChecker test to look at extra head tags instead of the defunct
headBlock.  Add URL to the output to make working with wgd easy.
2009-02-03 22:24:02 +00:00
Colin Kuskie
10dcc25aef Fix hardcoded extras URLs in templates and in extra head tags in assets. 2009-02-03 22:07:59 +00:00
Colin Kuskie
ca208699a4 Make test pass when there are no failures. Yes, it does seem strange. 2009-02-03 22:00:00 +00:00
Colin Kuskie
7365d116be Remove old help for the survey that is broken, and not used anymore. 2009-02-03 20:37:28 +00:00
Colin Kuskie
a17e4288ba Remove tests for file content that do not work because files stream.
Update error message in test to match how the code works.
2009-02-03 20:27:36 +00:00
Colin Kuskie
cdf2638243 Remove dots from config files in exportBinaryExtensions. 2009-02-03 17:43:59 +00:00
David Delikat
621a0cf71b initialize keyword field in GalleryFile.pm because get fills it in now due to a recent code change 2009-02-03 16:43:47 +00:00
Patrick Donelan
66a2adcbe5 Moved ResponseJSON data hash to private variable, for security and
consistency with SurveyJSON

Added some more accessors/mutators, and param validation
2009-02-03 08:32:40 +00:00
Patrick Donelan
17dbf7fa66 Updated Survey.pm to use the new SurveyJSON contructor params 2009-02-03 08:32:22 +00:00
Patrick Donelan
57fb3cb238 Refactored SurveyJSON for perlcritic compliance.
Simplified some code, refactored out some C-isms.
2009-02-03 08:32:06 +00:00
Patrick Donelan
821635eb71 Refactored ResponseJSON and SurveyJSON
Added Params::Validate to ResponseJSON.pm
Refactored ResponseJSON constructor and re-ordered params for
consistency
Added new ->session accessor
Updates tests
Removed unnecessary logging methods
Further refactored SurveyJSON, gave private variables underscores,
replaced direct hash access with accessors
2009-02-03 08:31:43 +00:00
Patrick Donelan
8833459c74 Added param validation to all SurveyJSON.pm methods. 2009-02-03 08:31:24 +00:00
Patrick Donelan
d00c8661f3 Made first argument to SurveyJSON contructor $session for consistency
with rest of wg.

Also added Params::Validate validation.
2009-02-03 08:31:07 +00:00