Commit graph

1813 commits

Author SHA1 Message Date
Colin Kuskie
d4fb48f77d Fix a bad test that will fail when we upgrade to mysql 5.1 2009-02-19 16:35:46 +00:00
Graham Knop
e5ede77c29 use char instead of varchar 2009-02-18 03:18:20 +00:00
Colin Kuskie
c90fa56507 Make WebGUI::PseudoRequest work with fatals. Cookies are now mocked and
tied off inside that package.  ErrorHandler uses the session request object,
instead of RequestUtil.
2009-02-18 02:46:59 +00:00
Graham Knop
2079266627 fix matrix test function 2009-02-17 20:53:09 +00:00
Colin Kuskie
96c15c56b2 Optimize canShowDebug for speed by caching the calculated check. 2009-02-16 21:03:31 +00:00
Patrick Donelan
50091e8e3a Started working on Survey Multiple Choice bundle management. 2009-02-16 00:13:58 +00:00
Patrick Donelan
34340e56fb Added Survey::surveyJSON_* convenience methods that auto-persist to the db 2009-02-12 01:07:22 +00:00
Patrick Donelan
7128a3d07c More Survey.pm refactoring
Turned getResponseId into a lazy-loading responseId mutator
Added responseIdCookies flag as a workaround for WebGUI::Test::getPage's
lack of cookie support
2009-02-11 09:27:31 +00:00
Patrick Donelan
e139136d08 Made Survey->surveyJSON lazy-load so that you don't have to call
loadSurveyJSON() everywhere.
2009-02-11 09:26:50 +00:00
Patrick Donelan
8d7599d781 Moved Survey.pm's "survey" and "response" properties to private hash
vars and added accessors.

So that you don't end up with mind-bending code that looks like:
$survey->survey->{survey}
2009-02-11 09:26:27 +00:00
Patrick Donelan
d882181fd1 Started refactoring the Survey.pm Wobject class
Refactored www_jumpTo and added tests
Added Params::Validate
Improved docs
Made call to SurveyJSON->createSurveyOrder() unnecessary
Turned ResponseJSON->nextResponse a mutator
2009-02-11 09:25:42 +00:00
Graham Knop
1edc66367e Spectre tests shouldn't need WRE to run 2009-02-10 22:54:54 +00:00
Graham Knop
a8dab0ac03 fix exif test 2009-02-10 21:41:48 +00:00
Graham Knop
bf9bd2f0d2 use proper JSON encoding/decoding 2009-02-10 21:41:36 +00:00
Colin Kuskie
5d8ede926c use PseudoRequest to stop some test warnings 2009-02-10 20:24:34 +00:00
Colin Kuskie
2482c0f89f Remove tests from FetchMimeType that just were setup to help Fedora pass. 2009-02-10 17:26:29 +00:00
Patrick Donelan
b0c5c09461 Merge branch 'master' into survey
* master: (127 commits)
  Prefill in the email address in the ITransact credentials form from the user's Shop address.
  fixed Matrix best/worst rated lists
  Fix bad form variable for phone number in EMS Badge address info.
  - Added a switch to allow the use of non-WebGUI objects with the Workflow
  fixing a problem with previous survey fix
  fixed #9671: Survey - breaks admin bar
  fixed a Matrix sql problem
  i18n the image labels and title for the asset manager, manage screen.
  Prevent an imported package from changing the a current asset's status from pending to anything else.
  Remove trailing comma in Shop/Transaction JS so IE6 works.
  fixed documentation
  fixed a bug when a matrix listing didn't have a forum attached
  small char encoding fix to merged upgrade
  fix small issue in addChild
  adding merge point
  Fix a problem with purging an EMS.
  Update this template so that it passes the template i18n test.
  Fix a broken i18n label in answer edit template for the Survey.
  Unify all Survey CSS into 1 file, and use it.
  Adding/fixing Survey i18n and Help
  ...

Conflicts:
	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/ResponseJSON.pm
	lib/WebGUI/i18n/English/Asset_Survey.pm
	www/extras/wobject/Survey/editsurvey/object.js
2009-02-10 07:57:42 +00:00
Patrick Donelan
306502465c Started refactoring nextQuestions in ResponseJSON
Made perlcritic happier
Extracted getQuestionResponses from processGotoExpression
Eliminated getPreviousAnswer
2009-02-06 01:56:54 +00:00
Patrick Donelan
345989370f Renamed ResponseJSON branching methods 2009-02-06 01:56:18 +00:00
Patrick Donelan
932a033b58 More ResponseJSON refactoring
Removed unnecessary $session argument from recordResponses
Refactored nextQuestions to return a list rather than an arrayref
Lots more documentation for ResponseJSON
More param validation for ResponseJSON
Refactored recordResponses
Updated tests
2009-02-06 01:55:56 +00:00
Patrick Donelan
90d314d2f1 Refactored next/last response/section related accessors and mutators
(and tests).

Added more documentation.
2009-02-06 01:55:33 +00:00
Patrick Donelan
669e986189 Replaced ResponseJSON's implementation of shuffle with List::Util's
shuffle and updated Colin's ninja shuffle tests
2009-02-04 02:05:44 +00:00
Colin Kuskie
3e326cf25d Update the templateChecker test to look at extra head tags instead of the defunct
headBlock.  Add URL to the output to make working with wgd easy.
2009-02-03 22:24:02 +00:00
Colin Kuskie
ca208699a4 Make test pass when there are no failures. Yes, it does seem strange. 2009-02-03 22:00:00 +00:00
Colin Kuskie
a17e4288ba Remove tests for file content that do not work because files stream.
Update error message in test to match how the code works.
2009-02-03 20:27:36 +00:00
Patrick Donelan
66a2adcbe5 Moved ResponseJSON data hash to private variable, for security and
consistency with SurveyJSON

Added some more accessors/mutators, and param validation
2009-02-03 08:32:40 +00:00
Patrick Donelan
821635eb71 Refactored ResponseJSON and SurveyJSON
Added Params::Validate to ResponseJSON.pm
Refactored ResponseJSON constructor and re-ordered params for
consistency
Added new ->session accessor
Updates tests
Removed unnecessary logging methods
Further refactored SurveyJSON, gave private variables underscores,
replaced direct hash access with accessors
2009-02-03 08:31:43 +00:00
Patrick Donelan
d00c8661f3 Made first argument to SurveyJSON contructor $session for consistency
with rest of wg.

Also added Params::Validate validation.
2009-02-03 08:31:07 +00:00
Colin Kuskie
151ebbde09 Also leaking a version tag. 2009-02-03 04:23:22 +00:00
Colin Kuskie
4ac37757ca Fix a leaking test. 2009-02-03 04:09:01 +00:00
Colin Kuskie
826089f075 Add a test to check for hardcoded extras in templates, and
in the extra head tags of all assets.
2009-01-30 16:49:00 +00:00
Colin Kuskie
ee9369392d Fix a test I broke with the i18n refactor for the GalleryFile 2009-01-29 23:46:39 +00:00
Colin Kuskie
83ca676be5 We want to add tests, not logically or them... 2009-01-29 06:00:50 +00:00
Graham Knop
2bc81f7757 fixing tests for Form changes 2009-01-28 16:39:38 +00:00
Colin Kuskie
7f2bc2458c Handle the case where someone is doing double quoted variable interpolation
in the label part of an i18n fetch.
2009-01-27 20:33:55 +00:00
Colin Kuskie
0302e7b96e WebGUI Perl::Critic policy. Handle the case when the namespace is
variable instead of a literal.
2009-01-27 20:19:39 +00:00
Colin Kuskie
6b7886c856 Add module version detecting to this test to handle WRE and non-WRE
installations of WebGUI.
2009-01-27 03:07:13 +00:00
Colin Kuskie
f47cb2ffdd Detect when Devel::Symdump pukes and skip modules that fail falsely.
Give better diagnostics so that true coverage can be monitored.
2009-01-27 02:22:08 +00:00
David Delikat
d24079f2ca added splitTag test cases 2009-01-26 03:56:02 +00:00
Patrick Donelan
1376c8ae92 Merge commit WebGUI_7.6.9-beta into survey-rfe
* commit 'tags/WebGUI_7.6.9-beta': (31 commits)
  Release 7.6.9-beta
  preparing for 7.6.9 release
  fixed: Exporting to static files can leak large amounts of memory
  fixed: HTTP Proxy doesn't serve new content to visitors
  use to_json and from_json in more places instead of encode_json and decode_json
  Document the heretofore missing date template variable in
  Qualify a chained method call when getting Workflow instances.  If the
  Attempt to fix IE6 bug
  fixed: ukplayer example is now loaded with swfobject.js released under the MIT licence, see gotcha's and /extras/ukplayer
  Added a style for printing Alumni pages
  Emails sent about low stock should have status unread, not completed.
  Moved draggable.js to extras/yui-webgui/build/layout since it is now a wrapper around YUI dragdrob
  Attributions in the changelog for a patch provided to fix a bug.
  whups, left in console.logs
  Updated draggable.js to wrap the YUI
  fixed #4137: Calendar Search page has extra head tags in body
  Fix a typo typo in the Operation/Workflow POD.
  Forward port Shelf view fix.  Was not displaying child shelves, only self.
  Forward port the PayDriver bug fixes from 7.5 branch.  Labels are always
  fixed #9264: new slideShow.swf uploaded in extras/ukplayer (United Knowledge/Arjan Widlak)
  ...

Conflicts:
	lib/WebGUI/Asset/Wobject/Survey.pm
2009-01-22 04:39:43 +00:00
Patrick Donelan
fe32551bca Added totalSections/Questions/Answers helper subs, refactored
getDragDropList to use helper subs, and added extra $address param
documentation.
2009-01-21 03:34:22 +00:00
Patrick Donelan
6d10570fdb Refactored SurveyJSON's new, freeze and addObject for readability 2009-01-20 07:34:55 +00:00
Colin Kuskie
1b6dd7be63 Forward port the PayDriver bug fixes from 7.5 branch. Labels are always
taken consistently from the JSON blob, and not a mixture of the two.
2009-01-15 00:34:34 +00:00
Patrick Donelan
34b44def2f Added gotoExpression tests (from flux branch) 2009-01-14 06:14:37 +00:00
Patrick Donelan
b7520da07d Merge commit 'tags/WebGUI_7.6.8-beta' into survey-rfe
* commit 'tags/WebGUI_7.6.8-beta': (96 commits)
  Release 7.6.8-beta
  preparing for 7.6.8 release
  convert to new storage format
  fixing photo comment test
  fixed: Syndicated Content corrupts wide characters
  Add the WikiPage to the list of contributions shown in the Account Contributions tab.
  added #!/usr/bin/env perl to all utility scripts
  Forward port i18n fix for Gallery Album RSS list.
  Fix some Survey i18n typos in the time limit hoverhelp.
  Large batch of Help and i18n.  Also, make sure that the
  Fix a typo in the i18n help for the ITransact Pay Driver.
  Correct dataform captcha variable name in the help.
  Forward porting expanded patch for handling deleted things.
  Have Thingy check for existance of table and column to prevent
  Fix linking to other things and autocreating the form field for it.
  Update test to match fixed code.
  Remove the warnings pragma
  Only resize photos if they are larger than the Gallery resolutions.
  Fix a syntax error made in the i18n of the search button.
  I18n'ed a submit button in the manage transactions screen.
  ...

Conflicts:

	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/SurveyJSON.pm
	www/extras/wobject/Survey/editsurvey.js
	www/extras/wobject/Survey/editsurvey/object.js
2009-01-14 06:00:06 +00:00
Colin Kuskie
e3c77d4e80 Add a test for evaluating templates and macros in the right order
in the Snippet.  Fix a bug with that.
2009-01-12 22:23:41 +00:00
Graham Knop
b5104d9581 fixing photo comment test 2009-01-09 10:33:20 +00:00
Colin Kuskie
312d1f2f8b Update test to match fixed code. 2009-01-04 03:49:42 +00:00
JT Smith
c76d533c31 got it before perlDreamer did! 2008-12-20 16:12:09 +00:00
Colin Kuskie
a30f940db1 fix Account test to use whatever method is set by default 2008-12-17 03:29:41 +00:00