Commit graph

9 commits

Author SHA1 Message Date
Colin Kuskie
5e502fee53 Merge commit '17ce3572bf' into WebGUI8. All tests passing. 2010-06-30 18:43:27 -07:00
Colin Kuskie
bb78682fb1 Update this test for the method name change, surveyJSON -> getSurveyJSON 2010-06-11 12:16:37 -07:00
Graham Knop
4c18ba3563 convert all test cleanup to addToCleanup 2010-06-10 18:47:54 -05:00
Graham Knop
b832deecd1 convert all cleanup methods to addToCleanup 2010-06-10 10:09:53 -05:00
Colin Kuskie
7034e2cf57 More END block cleanups. 2010-06-07 19:07:45 -07:00
Patrick Donelan
e4b18757d8 Fixes bug in ExpireIncompleteSurveyResponses
Use a left outer join on userProfileData so that the workflow processes
responses for users that have been deleted
2009-10-20 16:50:00 +11:00
Patrick Donelan
549f9ce650 Fix bugs in ExpireIncompleteSurveyResponses Workflow
Need to join on revisionDate otherwise one email per Survey revision
will be sent. (Added explicit test for this)

Some standard template vars were also missing - username and userId.

(forward-port from webgui-7.7)
2009-09-25 14:13:15 +10:00
Colin Kuskie
8fd0be0dc4 Purge tests before cleaning up version tags. Fix a leaky test. 2009-09-04 19:59:26 -07:00
Patrick Donelan
146373937d Fixed two new Survey bugs
* Survey response startDate stored twice
startDate was being stored both in a column in Survey_response and also inside the
serialised responseJSON. Consolidated to column and moved startDate methods to
Survey.pm where they are actually used. Was not causing errors because both copies
were initialised to "now" at response creation time, and then never changed (this is also
why we don't need any repair code to fix existing survey repsonses in the wild).

* Survey ExpireIncompleteSurveyResponses Workflow Activity not enabled
The only time you'd actually want to modify startDate is when you're trying to simulate
response expiry in test code, which is why I found the above bug when I was writing the
missing test suite for ExpireIncompleteSurveyResponses. Along with test suite, added
upgrade code to enable workflow activity and add it  to the Daily Maintenance Tasks
workflow. Also made minor fixes to the workflow activity, such as making sure it uses
the correct isComplete code.
2009-08-07 01:08:39 +00:00