Change tabs to spaces in group diagrams.
Optimize the addGroups membership check so the expensive getGroupsIn
doesn't have to take place.
Add a label to the foreach.
would fail every time.
Added a missing DESTROY method to Group.pm. That way it won't puke when trying
to call an undefined method when the User object is cleaned up.
Added coverage tests for friends method in User.pm
Added more docs for find method in Group.pm
Fixed a latent bug that would probably never occur in Macro/GroupAdd.pm
If Group->find is called with the name of a group that doesn't exist,
then Group will return an object with defaults, and the guid of the
group is undef, not ''. However, since by default autoAdd is off,
the Macro will still do the right thing.
GroupDelete has the same bug, but it shouldn't be patched until there's
a test written for it.
- fix: Rollback
- fix: debug output
- fix: Can't delete images at product asset
fixed a problem with file/image form uploads
rearranged group methods for alphabetical order
removed matt's hack for group caching and replaced it with the right way
that a group belongs to. This is required to properly uncache group settings
for groups with more than 2 levels of hierarchy.
Add 7 tests to verify the working of the new method.
Fix a typo in the POD for Operation/Group.pm
User.pm: Collapse all methods into getUsers(1) inside isInGroup
Group.pm: Disable the cache whenever a scratchFilter or ipFilter is assigned.
Begin updating Group documentation for changes to dbQuery
User.t: better clean-up at end
Scratch.t: no newlines in test output
Session/Scratch.pm: convert to use placeholders
Ad.pm: Add missing line of POD.
Group.pm: add method to get all users in a group by karma.
User.pm: isInGroup to use getKarmaUsers.
such as a dbQuery. This would happened coincidently before, but required
doing a User->isInGroup and only added members who were searched for rather
than all members.
Modify Group.t to test this.
Update POD in SQL.pm.
Grepped all files and fixed these errors:
- Passed userId replaced by User object creation and use.
- Where $session->user->userId was used, it was removed.
Updated POD inside Group.pm
Fixed two bugs in Group.pm
1) If recursive was set, and no recursive cache was present but a
direct cache was available, it would be returned. That's wrong.
2) Added a check in addGroups so that self cannot be added to itself.
Force uniqueness check inside isInGroups to prevent multiple group
definitions from being returned. This should cut the size of
the in-memory Group cache by 50%, since group id #3 is returned for _every_
group.
