Missing coverage is checking for leaving off the epoch argument
and getting the default of time(), and some kind of Devel::Cover
issue where it says that time() could return 0.
Removed the default setting for mailToEpoch that would have assigned
the epoch to the mail field and automatically caused the method
to fail, returning undef.
It didn't work with CIDR format IP addresses. I cannabilized the
code from canShowDebug and refactored it into its own method,
canShowBasedOnIP. Both canShowDebug and canShowPerformanceIndicators call this.
Updated the docs for the debugIp setting to note that it's used for both
showDebug and showPerformanceIndicators.
Added about 20 more tests to ErrorHandler.t. Only the two hard methods are
left, fatal (which closes the session at the end) and showDebug, which is
validating a ton of output.
More tests for Session/Icon.pm. Due to the way the code is written,
this test will not test 100% of the code. Untestable conditions include
not being able to find the toolbar directory in getToolbarOptions, and
all code that sets a default pageUrl in any icon-specific method.
Documented the disabled flag for moveDown and moveUp. Only the EMS uses this in
the core as far as I can tell.
Optimized out 1 profile call in getBaseURL
There are still a few functional tests that need to be written, they're
codified as TODOs.
In Session/Style.pm, in all methods that have a send immediate option
(when sent=1), they no longer send and cache. This prevents duplicate
heag tags from being generated if generateAdditionalHeadTags was
ever called twice.
fixed a bug in userStyle where it would not process data that was false.
process will do this, so I made userStyle do it as well by adding
in a definedness check on $output.
Found a fixed an infinite loop in WebGUI::Style::process
If an asset was requested to be printed who does not have a
printableStyleTemplateId then process would recurse back up the
lineage until it does find an asset with a printableStyleTemplateId.
Eventually, if none is found, it will find the Asset Root, whose
parent is itself, and it will loop forever.
I added code to jump out of the loop if it recurses back to the
assetRoot.
for default processing and for meta tags when cache busting is enabled.
Fixed a bug where the default meta tag Generator did not contain the
WebGUI version.
Added lots of POD to the Style module detailing how meta tags are
handled in various cases.
