Commit graph

32 commits

Author SHA1 Message Date
Colin Kuskie
daa0accf45 fill in the remaining tests for users and groups 2006-05-18 03:21:30 +00:00
Colin Kuskie
aea9ce76f7 Bust group caches and caches of groups containting this group
whenever the group is edited, or when users or groups are added
or deleted.
Add a test to check adding users.
2006-05-17 23:16:11 +00:00
Colin Kuskie
499981d092 removing diag to clean up smoke test output 2006-04-20 18:43:20 +00:00
Colin Kuskie
cb2a8d025e I am 4 kinds of fool 2006-04-15 16:51:23 +00:00
Colin Kuskie
bbd17516e8 add cache clearing to end of User and Group tests, too 2006-04-15 02:36:52 +00:00
Colin Kuskie
1c6fec6695 Flush cache for User and Group tests to pass.
Add group cache clear to Group.pm
templateId clash due fixed
2006-04-15 02:32:38 +00:00
Colin Kuskie
2f5dab37d2 finalized Group code with migration and upgrade log 2006-04-14 01:17:39 +00:00
Colin Kuskie
b0356f06a0 update test to use new method name 2006-04-13 22:52:16 +00:00
Colin Kuskie
8b8b4af41b Checkpoint before final conversion.
Added getIpUsers method to Group.pm
Group->getUsers and User->isInGroup both use getIpUsers
Tests added to Group.t to verify that getIpUsers works.
2006-04-11 21:17:30 +00:00
Colin Kuskie
e5e9cd9b51 add tests for scratch users and migrate getUsers,isInGroup to use it 2006-04-07 20:42:36 +00:00
Colin Kuskie
f9b8582426 Scratch filter tests in prep for WebGUI::Group->getScratchUsers
Small tweaks for User.pm scratch and Group.pm POD
Update scratchFilter docs to show how to place multiple name and value pairs
2006-04-06 22:02:54 +00:00
Colin Kuskie
3e179fa4ad Group.t: group karma tests, better clean-up at end
User.t: better clean-up at end
Scratch.t: no newlines in test output
Session/Scratch.pm: convert to use placeholders
Ad.pm: Add missing line of POD.
Group.pm: add method to get all users in a group by karma.
User.pm: isInGroup to use getKarmaUsers.
2006-04-06 16:52:34 +00:00
Colin Kuskie
510c1f5ca5 Modify User.pm and Group.pm to consider external means of defining users,
such as a dbQuery.  This would happened coincidently before, but required
doing a User->isInGroup and only added members who were searched for rather
than all members.
Modify Group.t to test this.
Update POD in SQL.pm.
2006-04-05 18:35:26 +00:00
Colin Kuskie
8bbae90c4e remove debugging tests 2006-04-03 23:19:21 +00:00
Colin Kuskie
7b60bc8fef test that while a user can be in a group they may not be in the list of users 2006-04-03 19:13:09 +00:00
Colin Kuskie
2f65790a74 Annotate recursive versus non-recursive test
Clean-up the crowd and the mab
2006-04-03 18:17:38 +00:00
Colin Kuskie
c802e4ddad Add tests for database defined groups to Group.t
Clear cache on set of databaseLinkId or dbQuery in WebGUI::Group.pm.
Fix typos, missing module use lines and extra variables in WebGUI::User.pm.
2006-04-03 18:07:09 +00:00
Colin Kuskie
910e191fb4 Add note to DatabaseLink->new that id 0 is reserved for WebGUI database.
Build SQL table to be used in Group membership test
2006-04-03 05:36:27 +00:00
Colin Kuskie
c2fdde2635 Fix POD doc for getUsers.
Add baseline tests for changing sql method of group membership.
2006-04-03 05:14:03 +00:00
Colin Kuskie
abfa6ed1ac make isUserAdmin do what the POD says (returns 0, 1), and clarify it
(deliberately passed null string or undef causes query instead of set).
Add tests to Group.t to check that behavior.
2006-03-19 06:10:44 +00:00
Colin Kuskie
0eb6ec7b01 Group test for user expiration inside a group.
1 POD tweak, more placeholder work.
2006-03-19 04:09:45 +00:00
Colin Kuskie
9711a237de Finally figured out how to become a group admin, and set a test for it.
Updated Secondary Admin docs to include all details for that.
More placeholder conversions, all backed by test code.
2006-03-18 06:07:01 +00:00
Colin Kuskie
e8a364f526 New user and group tests for caching and membership and default group settings.
Cache busting in User.pm.
Allow Visitor to be formally added to groups 2 and 7.
More placeholder work.
Update Help for Secondary Admins.
2006-03-18 05:36:04 +00:00
Colin Kuskie
b0e0cec9aa add tests to deleting groups and try to create a loop 2006-03-17 06:08:25 +00:00
Colin Kuskie
0197f6f1bd Cleaned up Group.t so that diagnostics when failing are correct.
Fixed two bugs in Group.pm
1) If recursive was set, and no recursive cache was present but a
direct cache was available, it would be returned.  That's wrong.
2) Added a check in addGroups so that self cannot be added to itself.
2006-03-15 06:27:47 +00:00
Colin Kuskie
c6b0d9b8d5 Remove debug code from Group.t
Force uniqueness check inside isInGroups to prevent multiple group
definitions from being returned.  This should cut the size of
the in-memory Group cache by 50%, since group id #3 is returned for _every_
group.
2006-03-14 05:54:42 +00:00
Colin Kuskie
8b80268013 check in code to expose bugs 2006-03-14 04:57:27 +00:00
Colin Kuskie
248f77f3a9 Added more test in preparation for changing Group SQL query work.
Update documentation in User.pm and Group.pm.
Refactor Group.pm to use placholders.
Fix typo in getGroupsIn where wrong key in hash was accessed.
2006-03-13 04:43:05 +00:00
Colin Kuskie
346ebe97ba testing more default settings 2006-02-12 06:56:45 +00:00
Colin Kuskie
b4520939f1 13 more Group tests
WebGUI::Group->find returns first group, no guaranteed order of search
2006-02-12 06:11:23 +00:00
Colin Kuskie
23fa58ca11 4 more WebGUI::Group tests
More Operation::Group.pm subs without session calls fixed.
2006-02-12 05:50:06 +00:00
Colin Kuskie
acdd58aec6 Very beginning of Group test that cleans up after itself.
Operation/Group wasn't passing session var internally.
Fixed WebGUI::Group POD docs.
2006-02-12 05:37:37 +00:00