Commit graph

614 commits

Author SHA1 Message Date
Scott Walters
9a45ff4b91 on invalid proceed method in call to editSave, warn and recover rather than run time error 2012-10-27 02:02:26 -04:00
Colin Kuskie
be37f12ab1 Clone stopped working in several tests in 5.14.2. Remove it in favor of Storable::dclone.
Clone handles being passed scalar data, but dclone does not.
2012-10-23 10:00:53 -07:00
Colin Kuskie
ffcee041be Allow WebGUI::Fork's to be built for asset specific methods, and not only those found in WebGUI::Asset's namespace. 2012-06-08 08:43:52 -07:00
Scott Walters
ee121e9460 Mobile template is not being inherited (#12246)
Break get_add_instance out of www_add; subclass it in Layout to
pull mobileTemplateId and mobileStyleTemplateId from the parent
if the parent is also a Layout.
2011-09-07 20:19:50 -04:00
Scott Walters
b05c7ea810 Revert "Mobile template is not being inherited (#12246)"
... per perlDreamer's additional argument for his original design for this

This reverts commit 2628263384.
2011-09-07 20:19:50 -04:00
Scott Walters
2628263384 Mobile template is not being inherited (#12246)
added extra_www_add_properties method to Asset.pm and subclassed it in as
Layout.pm as properties fix-up hook in child for www_add
2011-09-07 15:43:23 -04:00
Scott Walters
d65fd7e646 Pending perlDreamer's comments...:
Revert "Mobile template is not being inherited  (#12246)"

This reverts commit a4624663cf.
2011-09-06 20:32:50 -04:00
Scott Walters
a4624663cf Mobile template is not being inherited (#12246)
Applied SquOnk's patch and added tests; modify www_add to inherit mobileStyleTemplateId
from the parent as well as mobileTemplateId.  mobileTemplateId is only used by PageLayout
currently.  If other assets start using this and this gets inherited cross asset types,
thing will break.  A better design here would be to flag on a case-by-case basis in
asset definitions whether any given property should be inherited globally, of children
of the same asset class, or not at all.
2011-09-06 20:26:55 -04:00
Paul Driver
a4ee31feef Re-fixed #11379, with tests this time. 2011-07-19 16:41:51 -05:00
Colin Kuskie
87d252ec26 Make sure that the keywords template variable is provided by processTemplate, since we documented that it does that. Fixes bug #12186. 2011-07-10 18:29:52 -07:00
Paul Driver
c1a29182ca fixed #12129: AdminBar calls canAdd as an object method 2011-05-16 16:11:42 -05:00
Colin Kuskie
8525e4b7ee Don't refund transactionItems unless the transaction is successful, or if the item is already canceled. Also, no not call onCancelRecurring for normal Sku's unless they're really recurring. Fixes bug #12089. 2011-04-04 14:45:53 -07:00
Colin Kuskie
2195a7b04c Remove debug logging from www_editSave. 2011-03-14 10:03:01 -07:00
Colin Kuskie
88797c1d6c Add Asset Dashlets to Dashboard. Add required and static properties to Dashboard Assets. Add caching to StockData and WeatherData assets. Add LastModifiedBy macro. Add GroupManager to the Group form control. 2011-03-09 21:33:44 -08:00
Colin Kuskie
efcc4fe1a7 www_editSave needs permission checks to prevent extra assets from being added by unprivileged users. Partial fix for #12068. 2011-03-07 15:59:31 -08:00
Arjan Widlaak
3d79b8b26c - fixed bug 11997: maximumAssets is ignored
- fixed bug 11998: maximumAssets prevents editing existing assets if maximum is reached
2010-12-17 23:06:27 +01:00
Doug Bell
270f52aaaa fix 11954 Can't clear packed head tags 2010-11-16 18:47:51 -06:00
Paul Driver
c86ee12651 Fixing some failing tests 2010-10-07 16:14:48 -07:00
Paul Driver
04fa1ca794 VersionTag rollback moved to Fork 2010-10-06 08:54:18 -07:00
Paul Driver
895ce37917 Move trash functions to Fork 2010-10-06 08:54:17 -07:00
Paul Driver
e238f72278 www_copy and www_pasteList Forkified 2010-10-06 08:54:17 -07:00
Colin Kuskie
5ff871f2d5 Fix loose calls to $form->param('key') 2010-10-05 16:03:33 -07:00
Colin Kuskie
86ecb10198 Keep comments when packing asset content, since it will also remove conditional comments for IE. Fixes bug #11876 2010-09-20 13:37:12 -07:00
Colin Kuskie
09ff64334e Explicit scalar for getting the URL form param in Asset.pm. 2010-08-17 11:13:29 -07:00
Colin Kuskie
fff5bcfcd8 Better handling of fragment null string. Return chunked for errors in www_view. 2010-08-10 10:27:45 -07:00
Colin Kuskie
8a448e8f96 Tests for methods that die. Strange tom-foolery to get $@ into the logged message... 2010-08-10 10:27:45 -07:00
Colin Kuskie
3a9a3dd8e9 Add retry in case of problems in dispatch. Add tests for logging errors for bad templates. 2010-08-10 10:27:45 -07:00
Colin Kuskie
25fb019a18 Prepare a test method for throwing Template exceptions. Add code to handle HTTP 304 for visitors. 2010-08-10 10:27:45 -07:00
Colin Kuskie
1e00e6a93f Complete refactor, to handle defaulting to www_view. 2010-08-10 10:27:45 -07:00
Colin Kuskie
c987747409 Explicit return of undef in the fall through case. Test for notFound now look for undef. Added POD. 2010-08-10 10:27:45 -07:00
Colin Kuskie
7e96b15141 Check for fragment existance. Clarify a test. 2010-08-10 10:27:44 -07:00
Colin Kuskie
a649816db8 handle query params before URLs 2010-08-10 10:27:44 -07:00
Colin Kuskie
cb4189b7da Initial pass at dispatch 2010-08-10 10:27:44 -07:00
Colin Kuskie
092e3502c2 Add stub dispatch sub to Asset.pm 2010-08-10 10:27:44 -07:00
Doug Bell
69b7fe0465 fix jsontable and use it for Calendar feeds 2010-07-13 13:12:47 -05:00
kimd
fa04d01518 o Allow return from photo edit view to gallery edit view (RFE 11571)
o Reject form submissions without image selected for upload in edit view of Photo asset
2010-06-09 15:28:42 -05:00
Doug Bell
cc87552a22 weaken all session refs 2010-06-01 16:23:48 -05:00
Doug Bell
09092a13b6 performance enhancement 2010-04-29 12:21:50 -05:00
Colin Kuskie
a0253fa599 Remove really old code from the old Rss From Parent asset. 2010-04-07 14:50:51 -07:00
Luke Robinson
017a9a7fc2 allow field overrides in the config file 2010-01-27 15:57:26 -08:00
Colin Kuskie
38dedef368 Remove debug from Asset.pm 2010-01-21 11:55:49 -08:00
Colin Kuskie
be7cd328cf Add POD for getIsa. Enforce a repeatable order for testing. 2010-01-12 11:07:25 -08:00
Colin Kuskie
27a7c099ba fix: getIsa returns undef for pending assets.
Add a new option flag to getIsa, called returnAll.  If returnAll = 1, then
assets are returned regardless of status.  Otherwise, getIsa will only
return committed assets.
2009-12-08 17:22:59 -08:00
Colin Kuskie
f96c2f7af1 Change assetManager search to work like assetManager manage. Fixes bug #11272
Force all actions to be routed through asset methods with Csrf and
permission checks.
2009-11-24 22:53:20 -08:00
Colin Kuskie
da6743c211 Add the code to actually generate the hexadecimal assetId for templates. 2009-11-24 22:53:12 -08:00
Colin Kuskie
74f7038ec1 Fix a bad comment. 2009-11-02 09:05:36 -08:00
Colin Kuskie
edcbd95250 Have getIsa throw exceptions, instead of croaking. 2009-10-27 13:49:13 -07:00
Colin Kuskie
5bd5bb48a9 Central cache access for Assets to handle SSL caching. Fixes bug #11131. 2009-10-20 15:15:38 -07:00
Colin Kuskie
2250ab0452 Fix a typo in Asset->checkView, which redirected assets in the clipboard to the trash instead. Fixes bug #11139. 2009-10-16 14:31:26 -07:00
Graham Knop
60a4a9b140 mark $session->datetime->time as deprecated and remove its use from core code 2009-10-05 20:56:37 -05:00