Commit graph

1869 commits

Author SHA1 Message Date
Patrick Donelan
bc9c66c2fd Fixed template var regression in Survey.pm 2009-02-16 00:13:36 +00:00
Patrick Donelan
7958aefe64 Survey documentation improvements 2009-02-16 00:13:19 +00:00
Kaleb Murphy
a350398f41 Logic is corrected, but the JS should probably be rewritten to be more like the WG PageLayout drag and drop so that it isn't so finicky. 2009-02-13 18:28:52 +00:00
Patrick Donelan
34340e56fb Added Survey::surveyJSON_* convenience methods that auto-persist to the db 2009-02-12 01:07:22 +00:00
Patrick Donelan
d9316f47c4 Made perlcritic a little less grumpy about Survey.pm 2009-02-11 09:28:16 +00:00
Patrick Donelan
5a2f514a5a Added Delete Responses back into Survey template (with i18n) 2009-02-11 09:27:54 +00:00
Patrick Donelan
7128a3d07c More Survey.pm refactoring
Turned getResponseId into a lazy-loading responseId mutator
Added responseIdCookies flag as a workaround for WebGUI::Test::getPage's
lack of cookie support
2009-02-11 09:27:31 +00:00
Patrick Donelan
16c87b9cba Made Survey's responseJSON property lazy-load so that you don't have to
call loadResponseJSON and/or loadBothJSON everywhere
2009-02-11 09:27:10 +00:00
Patrick Donelan
e139136d08 Made Survey->surveyJSON lazy-load so that you don't have to call
loadSurveyJSON() everywhere.
2009-02-11 09:26:50 +00:00
Patrick Donelan
8d7599d781 Moved Survey.pm's "survey" and "response" properties to private hash
vars and added accessors.

So that you don't end up with mind-bending code that looks like:
$survey->survey->{survey}
2009-02-11 09:26:27 +00:00
Patrick Donelan
316d133a02 Improved Survey.pm documentation 2009-02-11 09:26:05 +00:00
Patrick Donelan
d882181fd1 Started refactoring the Survey.pm Wobject class
Refactored www_jumpTo and added tests
Added Params::Validate
Improved docs
Made call to SurveyJSON->createSurveyOrder() unnecessary
Turned ResponseJSON->nextResponse a mutator
2009-02-11 09:25:42 +00:00
Patrick Donelan
ba6764065b Added Survey Template i18n and hoverhelp 2009-02-11 09:25:17 +00:00
Patrick Donelan
25a6fc5e76 Added 'max responses per user' i18n and hoverhelp 2009-02-11 09:24:39 +00:00
Patrick Donelan
73c02b6803 Part-way through merging Survey features from trunk
Cleaned up Survey Edit screen, hover help, layout etc..
Added "jump to" AutoComplete box on Section Edit dialog (as per Answer
Edit dialog)
N.B. "take survey" is currently broken, but will be easy to fix
2009-02-10 08:00:18 +00:00
Patrick Donelan
b0c5c09461 Merge branch 'master' into survey
* master: (127 commits)
  Prefill in the email address in the ITransact credentials form from the user's Shop address.
  fixed Matrix best/worst rated lists
  Fix bad form variable for phone number in EMS Badge address info.
  - Added a switch to allow the use of non-WebGUI objects with the Workflow
  fixing a problem with previous survey fix
  fixed #9671: Survey - breaks admin bar
  fixed a Matrix sql problem
  i18n the image labels and title for the asset manager, manage screen.
  Prevent an imported package from changing the a current asset's status from pending to anything else.
  Remove trailing comma in Shop/Transaction JS so IE6 works.
  fixed documentation
  fixed a bug when a matrix listing didn't have a forum attached
  small char encoding fix to merged upgrade
  fix small issue in addChild
  adding merge point
  Fix a problem with purging an EMS.
  Update this template so that it passes the template i18n test.
  Fix a broken i18n label in answer edit template for the Survey.
  Unify all Survey CSS into 1 file, and use it.
  Adding/fixing Survey i18n and Help
  ...

Conflicts:
	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/ResponseJSON.pm
	lib/WebGUI/i18n/English/Asset_Survey.pm
	www/extras/wobject/Survey/editsurvey/object.js
2009-02-10 07:57:42 +00:00
Yung Han Khoe
66e4b23e7f improving matrix performance 2009-02-10 02:17:42 +00:00
Yung Han Khoe
a61dd87d22 fixed Matrix best/worst rated lists 2009-02-09 17:22:32 +00:00
Yung Han Khoe
d32137b5db fixing a problem with previous survey fix 2009-02-07 21:08:02 +00:00
Yung Han Khoe
36d401aa74 fixed a Matrix sql problem 2009-02-06 21:23:39 +00:00
Patrick Donelan
675333c54d More documentation tweaks for ResponseJSON 2009-02-06 06:06:29 +00:00
Patrick Donelan
6fddcdaf5f Refactored returnResponseForReporting 2009-02-06 05:51:08 +00:00
Patrick Donelan
fa6976fb40 More ResponseJSON refactoring.
Finished refactoring nextQuestions()
Added recordedResponses sub
Added getTemplatedText sub
Added sectionId, questionId, answerId, sIndex, qIndex, aIndexes
abstraction subs
2009-02-06 05:15:26 +00:00
Patrick Donelan
306502465c Started refactoring nextQuestions in ResponseJSON
Made perlcritic happier
Extracted getQuestionResponses from processGotoExpression
Eliminated getPreviousAnswer
2009-02-06 01:56:54 +00:00
Patrick Donelan
3340a675b7 Updated Survey.pm to use new ResponseJSON.pm methods 2009-02-06 01:56:35 +00:00
Patrick Donelan
345989370f Renamed ResponseJSON branching methods 2009-02-06 01:56:18 +00:00
Patrick Donelan
932a033b58 More ResponseJSON refactoring
Removed unnecessary $session argument from recordResponses
Refactored nextQuestions to return a list rather than an arrayref
Lots more documentation for ResponseJSON
More param validation for ResponseJSON
Refactored recordResponses
Updated tests
2009-02-06 01:55:56 +00:00
Patrick Donelan
90d314d2f1 Refactored next/last response/section related accessors and mutators
(and tests).

Added more documentation.
2009-02-06 01:55:33 +00:00
Colin Kuskie
6c61eb54db Fix a problem with purging an EMS. 2009-02-05 23:10:35 +00:00
Graham Knop
fbd118d37e fixed: Permissions aren't correctly applied to Article attachments 2009-02-05 20:02:52 +00:00
Colin Kuskie
62a14a2dcc Dates in the galley advanced search were ignored. 2009-02-04 16:58:25 +00:00
Colin Kuskie
a5ad3bf4bd Fix broken subfolder synopsis template variable in the Folder. 2009-02-04 16:30:38 +00:00
Colin Kuskie
b8b2a38ef5 Fix the exitURL redirection when a survey is completed and the site uses a gateway url. 2009-02-04 02:22:21 +00:00
Patrick Donelan
669e986189 Replaced ResponseJSON's implementation of shuffle with List::Util's
shuffle and updated Colin's ninja shuffle tests
2009-02-04 02:05:44 +00:00
Patrick Donelan
477f014177 Improved createSurveyOrder documentation, and made perlcritic happy 2009-02-04 00:16:44 +00:00
Patrick Donelan
6fb325699f Refactored createSurveyOrder in ResponseJSON
Added lastSectionIndex, lastQuestionIndex, lastAswerIndex convenience
methods to SurveyJSON to simplify iterations over Sections, Questions
and Answers
2009-02-04 00:16:26 +00:00
Patrick Donelan
66a2adcbe5 Moved ResponseJSON data hash to private variable, for security and
consistency with SurveyJSON

Added some more accessors/mutators, and param validation
2009-02-03 08:32:40 +00:00
Patrick Donelan
17dbf7fa66 Updated Survey.pm to use the new SurveyJSON contructor params 2009-02-03 08:32:22 +00:00
Patrick Donelan
57fb3cb238 Refactored SurveyJSON for perlcritic compliance.
Simplified some code, refactored out some C-isms.
2009-02-03 08:32:06 +00:00
Patrick Donelan
821635eb71 Refactored ResponseJSON and SurveyJSON
Added Params::Validate to ResponseJSON.pm
Refactored ResponseJSON constructor and re-ordered params for
consistency
Added new ->session accessor
Updates tests
Removed unnecessary logging methods
Further refactored SurveyJSON, gave private variables underscores,
replaced direct hash access with accessors
2009-02-03 08:31:43 +00:00
Patrick Donelan
8833459c74 Added param validation to all SurveyJSON.pm methods. 2009-02-03 08:31:24 +00:00
Patrick Donelan
d00c8661f3 Made first argument to SurveyJSON contructor $session for consistency
with rest of wg.

Also added Params::Validate validation.
2009-02-03 08:31:07 +00:00
David Delikat
118c18569f caching now takes into account the correct parameter for pagination 2009-01-31 19:12:34 +00:00
David Delikat
e3e24b37b0 fixed #9596: Articles now use a semi-unique pagination variable based on asset id
also restored the 'synopsis = first page' feature in Asset::Post::getSynopsisAndContent
2009-01-29 17:45:52 +00:00
Colin Kuskie
6a9e65d7d3 Backporting GalleryAlbum isHidden fix. 2009-01-29 17:14:46 +00:00
Colin Kuskie
129d45ca2a Refactor gallery code to use old i18n technologies so they can
be verified with the critic_labels test.
2009-01-28 22:20:39 +00:00
Graham Knop
e345fd8706 fixed #9592: DataForm deleteAttachedFiles method can crash 2009-01-28 18:24:26 +00:00
Graham Knop
e0e6e9b947 fixed: Syndicated Content asset doesn't work with feeds that specify their encodings via HTTP headers 2009-01-28 18:03:37 +00:00
Graham Knop
c7dac4aa42 cleaning up survey pod 2009-01-28 16:39:27 +00:00
Graham Knop
c7c4b8aecd fix error reporting in Syndicated Content 2009-01-28 16:39:21 +00:00