Commit graph

75 commits

Author SHA1 Message Date
JT Smith
1013381c36 fixed an error in the groups/db system where removing a dblink connected to a group would produce a fatal error 2007-04-11 17:24:56 +00:00
JT Smith
e1c86d7f95 - fix: fixed an error in the groups/db system where removing a dblink connected to a group would produce a fatal error 2007-04-05 03:43:37 +00:00
Nik Ogura
cb7f79543a changed pod from 'days' to 'seconds' for expireOffset et al. to reflect what's actually happening 2007-03-27 06:07:50 +00:00
Colin Kuskie
ec3eebda9b remove duplicate code in addUsers, add more tests to Group.t to cover 2007-03-07 00:16:22 +00:00
Colin Kuskie
d948cb4a33 fix typo in expireNotifyOffset method which prevents it from setting this value 2007-03-04 06:22:15 +00:00
JT Smith
67dfefff08 merging 7.1.3 changes 2006-10-31 23:34:55 +00:00
Doug Bell
6d56df1362 Added SQLReport download and Product AddToGroup handler 2006-10-10 18:14:31 +00:00
Colin Kuskie
5dbd9b44c9 Fixed a typo in the POD for Session/Env.pm
Added more docs for find method in Group.pm
Fixed a latent bug that would probably never occur in Macro/GroupAdd.pm
If Group->find is called with the name of a group that doesn't exist,
then Group will return an object with defaults, and the guid of the
group is undef, not ''.  However, since by default autoAdd is off,
the Macro will still do the right thing.
GroupDelete has the same bug, but it shouldn't be patched until there's
a test written for it.
2006-07-24 05:08:17 +00:00
Colin Kuskie
2142186d97 remove old debugging output 2006-07-17 03:29:12 +00:00
Frank Dillon
ec4245a7d8 changes for adding ldap recursive filter 2006-07-12 20:31:02 +00:00
Colin Kuskie
206a294988 Fix bug where groups were being created with no defaults.
Update Group test to check for default values in groups created
with gid "new" and "".
2006-06-30 05:14:28 +00:00
Frank Dillon
6e734b900f LDAP isInGroup changes 2006-06-23 01:49:34 +00:00
JT Smith
41e655b452 - fix: New page layout instead of not found
- fix: Rollback
 - fix: debug output
 - fix: Can't delete images at product asset
fixed a problem with file/image form uploads
rearranged group methods for alphabetical order
removed matt's hack for group caching and replaced it with the right way
2006-05-30 22:35:12 +00:00
Colin Kuskie
7100d1df41 Add a new method called getAllGroupsFor, which recursively returns ALL groups
that a group belongs to.  This is required to properly uncache group settings
for groups with more than 2 levels of hierarchy.

Add 7 tests to verify the working of the new method.

Fix a typo in the POD for Operation/Group.pm
2006-05-26 16:43:47 +00:00
Wouter van Oijen
684f08649d Fixing stuff 2006-05-21 14:49:40 +00:00
Colin Kuskie
aea9ce76f7 Bust group caches and caches of groups containting this group
whenever the group is edited, or when users or groups are added
or deleted.
Add a test to check adding users.
2006-05-17 23:16:11 +00:00
Colin Kuskie
1c6fec6695 Flush cache for User and Group tests to pass.
Add group cache clear to Group.pm
templateId clash due fixed
2006-04-15 02:32:38 +00:00
Colin Kuskie
6726f56af3 remove debug code 2006-04-14 01:50:29 +00:00
Colin Kuskie
2f5dab37d2 finalized Group code with migration and upgrade log 2006-04-14 01:17:39 +00:00
Colin Kuskie
4f60281392 change dbCacheTimeout to groupCacheTimeout 2006-04-13 22:26:11 +00:00
Colin Kuskie
be7a44d4f2 make Group->getUsers fully recursive to remove duplicate code 2006-04-13 21:22:04 +00:00
Colin Kuskie
ad694fb030 Fix User.t so that it assigns IPs in a way that works with the new isInGroup code.
User.pm: Collapse all methods into getUsers(1) inside isInGroup
Group.pm: Disable the cache whenever a scratchFilter or ipFilter is assigned.
Begin updating Group documentation for changes to dbQuery
2006-04-12 23:33:11 +00:00
Colin Kuskie
8b8b4af41b Checkpoint before final conversion.
Added getIpUsers method to Group.pm
Group->getUsers and User->isInGroup both use getIpUsers
Tests added to Group.t to verify that getIpUsers works.
2006-04-11 21:17:30 +00:00
Colin Kuskie
e5e9cd9b51 add tests for scratch users and migrate getUsers,isInGroup to use it 2006-04-07 20:42:36 +00:00
Matthew Wilson
2c60283ba3 first major round of EMS changes. much more to come late tonight. 2006-04-07 00:02:45 +00:00
Colin Kuskie
f9b8582426 Scratch filter tests in prep for WebGUI::Group->getScratchUsers
Small tweaks for User.pm scratch and Group.pm POD
Update scratchFilter docs to show how to place multiple name and value pairs
2006-04-06 22:02:54 +00:00
Colin Kuskie
3e179fa4ad Group.t: group karma tests, better clean-up at end
User.t: better clean-up at end
Scratch.t: no newlines in test output
Session/Scratch.pm: convert to use placeholders
Ad.pm: Add missing line of POD.
Group.pm: add method to get all users in a group by karma.
User.pm: isInGroup to use getKarmaUsers.
2006-04-06 16:52:34 +00:00
Colin Kuskie
510c1f5ca5 Modify User.pm and Group.pm to consider external means of defining users,
such as a dbQuery.  This would happened coincidently before, but required
doing a User->isInGroup and only added members who were searched for rather
than all members.
Modify Group.t to test this.
Update POD in SQL.pm.
2006-04-05 18:35:26 +00:00
Colin Kuskie
c802e4ddad Add tests for database defined groups to Group.t
Clear cache on set of databaseLinkId or dbQuery in WebGUI::Group.pm.
Fix typos, missing module use lines and extra variables in WebGUI::User.pm.
2006-04-03 18:07:09 +00:00
Colin Kuskie
c2fdde2635 Fix POD doc for getUsers.
Add baseline tests for changing sql method of group membership.
2006-04-03 05:14:03 +00:00
Colin Kuskie
abfa6ed1ac make isUserAdmin do what the POD says (returns 0, 1), and clarify it
(deliberately passed null string or undef causes query instead of set).
Add tests to Group.t to check that behavior.
2006-03-19 06:10:44 +00:00
Colin Kuskie
0eb6ec7b01 Group test for user expiration inside a group.
1 POD tweak, more placeholder work.
2006-03-19 04:09:45 +00:00
Colin Kuskie
9711a237de Finally figured out how to become a group admin, and set a test for it.
Updated Secondary Admin docs to include all details for that.
More placeholder conversions, all backed by test code.
2006-03-18 06:07:01 +00:00
Colin Kuskie
e8a364f526 New user and group tests for caching and membership and default group settings.
Cache busting in User.pm.
Allow Visitor to be formally added to groups 2 and 7.
More placeholder work.
Update Help for Secondary Admins.
2006-03-18 05:36:04 +00:00
Colin Kuskie
b0e0cec9aa add tests to deleting groups and try to create a loop 2006-03-17 06:08:25 +00:00
Colin Kuskie
f59f41cd9e WebGUI::User->isInGroup does not take a UID argument anymore.
Grepped all files and fixed these errors:
	- Passed userId replaced by User object creation and use.
	- Where $session->user->userId was used, it was removed.
Updated POD inside Group.pm
2006-03-15 22:55:00 +00:00
Colin Kuskie
0197f6f1bd Cleaned up Group.t so that diagnostics when failing are correct.
Fixed two bugs in Group.pm
1) If recursive was set, and no recursive cache was present but a
direct cache was available, it would be returned.  That's wrong.
2) Added a check in addGroups so that self cannot be added to itself.
2006-03-15 06:27:47 +00:00
Colin Kuskie
c6b0d9b8d5 Remove debug code from Group.t
Force uniqueness check inside isInGroups to prevent multiple group
definitions from being returned.  This should cut the size of
the in-memory Group cache by 50%, since group id #3 is returned for _every_
group.
2006-03-14 05:54:42 +00:00
Colin Kuskie
7f7347faa9 fix 3 bugs and add more POD 2006-03-14 05:09:33 +00:00
Colin Kuskie
248f77f3a9 Added more test in preparation for changing Group SQL query work.
Update documentation in User.pm and Group.pm.
Refactor Group.pm to use placholders.
Fix typo in getGroupsIn where wrong key in hash was accessed.
2006-03-13 04:43:05 +00:00
JT Smith
6ee05b85af first round of changes to create the ui for building workflows, more to come
a few small bug fixes
2006-02-15 21:23:22 +00:00
Colin Kuskie
b4520939f1 13 more Group tests
WebGUI::Group->find returns first group, no guaranteed order of search
2006-02-12 06:11:23 +00:00
Colin Kuskie
acdd58aec6 Very beginning of Group test that cleans up after itself.
Operation/Group wasn't passing session var internally.
Fixed WebGUI::Group POD docs.
2006-02-12 05:37:37 +00:00
Matthew Wilson
4a3121960f removal of dumpSession. 2006-01-26 05:39:16 +00:00
Matthew Wilson
2069da5fdb tons of bug fixes. 2006-01-18 14:41:12 +00:00
Matthew Wilson
09483e18c5 a ton of $session fixes (thanks to Colin), and a new $session checker, that supposedly, shouldn't be needed now. It can be backed out, however, easily. 2006-01-16 22:45:21 +00:00
Matthew Wilson
f2cccdff9f more oodles of changes. 2006-01-15 18:19:44 +00:00
Colin Kuskie
3c0c47014c string concat, Grouping->Group merge provides access to groupId 2006-01-13 18:29:42 +00:00
JT Smith
4b439f610e bugfixes from session conversion 2006-01-12 23:13:18 +00:00
JT Smith
a3adaee3a0 removing unnecessary use lines 2006-01-12 22:27:20 +00:00