Commit graph

2183 commits

Author SHA1 Message Date
Colin Kuskie
3cd1e13051 Add missing POD and fix POD typos in subroutine names. 30/441 failing 100% POD coverage. 2009-07-04 20:09:35 +00:00
Colin Kuskie
721a8ced26 Use as many autogenerated form fields as possible. 2009-07-04 19:26:36 +00:00
Colin Kuskie
e5c0293498 Add missing POD. 2009-07-04 18:56:59 +00:00
Colin Kuskie
576b914293 More POD fixes. 2009-07-04 17:21:05 +00:00
Colin Kuskie
cff07644e0 Fix POD to increase POD coverage, mainly by fixing typos and removing
unused code.
2009-07-04 17:12:13 +00:00
Colin Kuskie
1bcae0d3bc Add an Event method for returning a non-inclusive end DataTime object.
Have Calendar use that for determining the end of a week in viewWeek.
Fix getEventsIn to do all comparisons in UTC so that extra events are not added in.
2009-07-03 05:04:43 +00:00
Patrick Donelan
29f20d3889 Fixed bug in Survey::ExpressionEngine - was not using most recent survey
response to resolve external values
2009-07-03 01:39:53 +00:00
Patrick Donelan
79692ca8fe Fixed: Survey - check for groupToEditSurvey as well as groupToViewSurvey in canView 2009-07-03 01:39:34 +00:00
Patrick Donelan
0265e1dfbd Fixed Survey::Test diagnostics when comparing complex data structures 2009-07-03 01:39:16 +00:00
Colin Kuskie
c30614bdf6 Forward porting fixes for iCal escaping and unescaping, and line wrapping. 2009-07-01 22:18:57 +00:00
Colin Kuskie
109178ac6a remove debug 2009-06-30 15:50:07 +00:00
Colin Kuskie
755d7909a5 Fix iCal processing in the Calendar module and workflow. Errors with
generation and processing.
2009-06-30 15:43:40 +00:00
Patrick Donelan
bb3de4bf96 Fixed minor Survey bug that could prevent tests from running in some cases 2009-06-27 00:04:38 +00:00
Patrick Donelan
eca88d70f4 Fixed bug where Survey was leaving uncommitted version tags behind 2009-06-26 02:30:12 +00:00
Colin Kuskie
a7c489e454 Make the importer check the date format when importing tickets. 2009-06-24 03:25:07 +00:00
Patrick Donelan
17c7618605 Removed debug line 2009-06-22 23:21:35 +00:00
Patrick Donelan
b5186bfbab fixed #10565: Survey: add question doing double-create 2009-06-22 07:08:08 +00:00
Patrick Donelan
3fccab7743 Minor bugfixes/tweaks to Survey 2009-06-22 07:07:41 +00:00
Colin Kuskie
3b94bad76d Fix a typo in user output. 2009-06-20 00:02:20 +00:00
Patrick Donelan
cbc308c55a SurveyJSON size reduction/optimization
SurveyJSON was storing a lot of redundant information (every setting on
every single section/question/answer, which, in most cases, will simply
take on the default values). This was bloating the surveyJSON property in
the db, and equally as importantly, slowing down Survey because it had to
do a lot of JSON parsing on the serialised surveyJSON object.

We now factor out and store the current section/question/answer defaults
along with the surveyJSON data itself, which means that we only needs to
store properties that differ from the defaults. This results is a massive
reduction in the size of the serialized surveyJSON stored in the database,
as well as a speed-up in json parsing time.

The compression/uncompression happens transparently to the rest of Survey.
2009-06-19 08:07:18 +00:00
Martin Kamerbeek
65bdea5f3c fixed a bug in Thingy where in some cases the style template was not processed after editing a Thing. 2009-06-17 12:23:06 +00:00
Patrick Donelan
e44c7bae2e Small survey bug fix to Survey::persistResponseJSON 2009-06-17 07:21:35 +00:00
Colin Kuskie
d09015502e Better comment for why ads are being reprocessed. 2009-06-16 18:00:31 +00:00
Patrick Donelan
d820d43760 Fixed #10520 - Survey responses get confused if survey structure modified
Survey responses are now revision-aware.
The survey structure gets revisioned automatically as necessary when changes
are made on the Edit Survey screen (as necessary ~~ a response exists
for the current revision)
2009-06-16 06:25:38 +00:00
Colin Kuskie
c95ea52978 Reverting Thingy RFE commit. 2009-06-11 16:38:39 +00:00
Eric Kennedy
381219a4c0 rfe #10423: Provide a way to access the instance of the thing that was added, modified, or deleted via workflow. (Eric Kennedy) 2009-06-11 03:04:45 +00:00
Yung Han Khoe
be430dfdd2 fixed #9953: Matrix 2.0 - Not enough tests 2009-06-10 18:46:15 +00:00
Colin Kuskie
52b8143707 Fix date handling by the search form in the Gallery. 2009-06-10 17:14:37 +00:00
Patrick Donelan
9004e5d711 Survey cleanup and minor bug fixes
Cleaned up edit page tabs
Improved API docs
Added noCreate option to responseId so that it doesn't create unnecessary responses
Added groupToTakeSurvey priv check to takeSurvey
2009-06-09 03:27:06 +00:00
Patrick Donelan
977be654cc Fixed bug in privs check for Survey::www_showFeedback 2009-06-09 03:26:44 +00:00
Patrick Donelan
cdc44a1bfb Made Survey Preview a little less brutal 2009-06-09 03:26:24 +00:00
Colin Kuskie
fcad3a112d Fix a bug in the Story when handling images of different sizes. Add a
photoWidth property to the StoryArchive, and resize all newly uploaded pictures
to a Story.
2009-06-08 21:51:33 +00:00
Doug Bell
1de7439056 fixed issue with getSortOrder and rating 2009-06-05 17:31:39 +00:00
Colin Kuskie
0cf94b4c32 Fix a syntax warning in Survey.pm 2009-06-04 21:45:13 +00:00
Colin Kuskie
f9f5a8b12a Remove patch temporary file. 2009-06-04 16:24:37 +00:00
Patrick Donelan
d3f5c9ecfd Survey - differentiated between endDate and endDateEpoch. 2009-06-04 07:22:48 +00:00
JT Smith
9381fd02d8 Insufficient filtering in javascript filter (#10001) 2009-06-03 15:53:55 +00:00
Patrick Donelan
3ffb76ef7f Fixed Survey testsuite handling of Tagged question type 2009-06-03 07:16:14 +00:00
Patrick Donelan
5acade845a Fixed Survey test suite 'tagged' check to work with nested data 2009-06-03 07:15:52 +00:00
Patrick Donelan
9702ffcaac Fixed Survey section-level branch precedence bug
For Sections with questions spread out over multiple pages, branch
expressions should only happen on the last page of the Section.
Added explicit test.
2009-06-03 02:12:00 +00:00
Patrick Donelan
da595da89e Remove bloat from Survey response record to reduce json serialisation time 2009-06-03 02:11:31 +00:00
Patrick Donelan
216a48580a Fixed #9927 Survey - verbatim
Fixed inconsistencies between answer 'comment' and 'verbatim'.
Updated tests.
Made minor changes to reporting methods but they still need some love.
2009-06-03 00:29:29 +00:00
Colin Kuskie
80dfb9ffd0 Throw an exception in all wobjects if the main template (used by view)
has been deleted.
2009-06-02 19:34:18 +00:00
Patrick Donelan
084a0c3105 Fixed naff Survey::takenCount bug, added explicit test for it 2009-06-02 02:42:37 +00:00
Patrick Donelan
7faa9c3e9d Fixed Survey Date question type server-side validation, and made
all validation messages generate debug output
2009-06-02 01:48:41 +00:00
Colin Kuskie
5fd74af21e Don't make a 2nd i18n object. 2009-06-01 20:47:06 +00:00
Colin Kuskie
fcb884a410 Fix Project Manager calling wrong method on right object. www_viewScreen now
uses mobile template if so enabled via calling processStyle.
2009-06-01 20:00:16 +00:00
Colin Kuskie
8f09dc062d Add edit and delete icons to the Story Topic. Update tests. Adjust both
sets of templates.  Use the correct privileges for displaying the icons.
Help and i18n.
2009-06-01 16:53:22 +00:00
Colin Kuskie
6844ef4559 Add missing edit story and delete story icons in the view method of the Story Archive. 2009-06-01 16:27:49 +00:00
Colin Kuskie
76b9f01e77 Prevent head tags from appearing twice in wobjects.
prepareView sets the extra head tags.  Have all wobjects, in their www_view method,
tell processStyle not to set the extra head tags again.
2009-06-01 02:03:05 +00:00