Commit graph

367 commits

Author SHA1 Message Date
Patrick Donelan
d882181fd1 Started refactoring the Survey.pm Wobject class
Refactored www_jumpTo and added tests
Added Params::Validate
Improved docs
Made call to SurveyJSON->createSurveyOrder() unnecessary
Turned ResponseJSON->nextResponse a mutator
2009-02-11 09:25:42 +00:00
Patrick Donelan
b0c5c09461 Merge branch 'master' into survey
* master: (127 commits)
  Prefill in the email address in the ITransact credentials form from the user's Shop address.
  fixed Matrix best/worst rated lists
  Fix bad form variable for phone number in EMS Badge address info.
  - Added a switch to allow the use of non-WebGUI objects with the Workflow
  fixing a problem with previous survey fix
  fixed #9671: Survey - breaks admin bar
  fixed a Matrix sql problem
  i18n the image labels and title for the asset manager, manage screen.
  Prevent an imported package from changing the a current asset's status from pending to anything else.
  Remove trailing comma in Shop/Transaction JS so IE6 works.
  fixed documentation
  fixed a bug when a matrix listing didn't have a forum attached
  small char encoding fix to merged upgrade
  fix small issue in addChild
  adding merge point
  Fix a problem with purging an EMS.
  Update this template so that it passes the template i18n test.
  Fix a broken i18n label in answer edit template for the Survey.
  Unify all Survey CSS into 1 file, and use it.
  Adding/fixing Survey i18n and Help
  ...

Conflicts:
	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/ResponseJSON.pm
	lib/WebGUI/i18n/English/Asset_Survey.pm
	www/extras/wobject/Survey/editsurvey/object.js
2009-02-10 07:57:42 +00:00
Patrick Donelan
306502465c Started refactoring nextQuestions in ResponseJSON
Made perlcritic happier
Extracted getQuestionResponses from processGotoExpression
Eliminated getPreviousAnswer
2009-02-06 01:56:54 +00:00
Patrick Donelan
345989370f Renamed ResponseJSON branching methods 2009-02-06 01:56:18 +00:00
Patrick Donelan
932a033b58 More ResponseJSON refactoring
Removed unnecessary $session argument from recordResponses
Refactored nextQuestions to return a list rather than an arrayref
Lots more documentation for ResponseJSON
More param validation for ResponseJSON
Refactored recordResponses
Updated tests
2009-02-06 01:55:56 +00:00
Patrick Donelan
90d314d2f1 Refactored next/last response/section related accessors and mutators
(and tests).

Added more documentation.
2009-02-06 01:55:33 +00:00
Patrick Donelan
669e986189 Replaced ResponseJSON's implementation of shuffle with List::Util's
shuffle and updated Colin's ninja shuffle tests
2009-02-04 02:05:44 +00:00
Colin Kuskie
a17e4288ba Remove tests for file content that do not work because files stream.
Update error message in test to match how the code works.
2009-02-03 20:27:36 +00:00
Patrick Donelan
66a2adcbe5 Moved ResponseJSON data hash to private variable, for security and
consistency with SurveyJSON

Added some more accessors/mutators, and param validation
2009-02-03 08:32:40 +00:00
Patrick Donelan
821635eb71 Refactored ResponseJSON and SurveyJSON
Added Params::Validate to ResponseJSON.pm
Refactored ResponseJSON constructor and re-ordered params for
consistency
Added new ->session accessor
Updates tests
Removed unnecessary logging methods
Further refactored SurveyJSON, gave private variables underscores,
replaced direct hash access with accessors
2009-02-03 08:31:43 +00:00
Patrick Donelan
d00c8661f3 Made first argument to SurveyJSON contructor $session for consistency
with rest of wg.

Also added Params::Validate validation.
2009-02-03 08:31:07 +00:00
Colin Kuskie
ee9369392d Fix a test I broke with the i18n refactor for the GalleryFile 2009-01-29 23:46:39 +00:00
Patrick Donelan
1376c8ae92 Merge commit WebGUI_7.6.9-beta into survey-rfe
* commit 'tags/WebGUI_7.6.9-beta': (31 commits)
  Release 7.6.9-beta
  preparing for 7.6.9 release
  fixed: Exporting to static files can leak large amounts of memory
  fixed: HTTP Proxy doesn't serve new content to visitors
  use to_json and from_json in more places instead of encode_json and decode_json
  Document the heretofore missing date template variable in
  Qualify a chained method call when getting Workflow instances.  If the
  Attempt to fix IE6 bug
  fixed: ukplayer example is now loaded with swfobject.js released under the MIT licence, see gotcha's and /extras/ukplayer
  Added a style for printing Alumni pages
  Emails sent about low stock should have status unread, not completed.
  Moved draggable.js to extras/yui-webgui/build/layout since it is now a wrapper around YUI dragdrob
  Attributions in the changelog for a patch provided to fix a bug.
  whups, left in console.logs
  Updated draggable.js to wrap the YUI
  fixed #4137: Calendar Search page has extra head tags in body
  Fix a typo typo in the Operation/Workflow POD.
  Forward port Shelf view fix.  Was not displaying child shelves, only self.
  Forward port the PayDriver bug fixes from 7.5 branch.  Labels are always
  fixed #9264: new slideShow.swf uploaded in extras/ukplayer (United Knowledge/Arjan Widlak)
  ...

Conflicts:
	lib/WebGUI/Asset/Wobject/Survey.pm
2009-01-22 04:39:43 +00:00
Patrick Donelan
fe32551bca Added totalSections/Questions/Answers helper subs, refactored
getDragDropList to use helper subs, and added extra $address param
documentation.
2009-01-21 03:34:22 +00:00
Patrick Donelan
6d10570fdb Refactored SurveyJSON's new, freeze and addObject for readability 2009-01-20 07:34:55 +00:00
Patrick Donelan
34b44def2f Added gotoExpression tests (from flux branch) 2009-01-14 06:14:37 +00:00
Patrick Donelan
b7520da07d Merge commit 'tags/WebGUI_7.6.8-beta' into survey-rfe
* commit 'tags/WebGUI_7.6.8-beta': (96 commits)
  Release 7.6.8-beta
  preparing for 7.6.8 release
  convert to new storage format
  fixing photo comment test
  fixed: Syndicated Content corrupts wide characters
  Add the WikiPage to the list of contributions shown in the Account Contributions tab.
  added #!/usr/bin/env perl to all utility scripts
  Forward port i18n fix for Gallery Album RSS list.
  Fix some Survey i18n typos in the time limit hoverhelp.
  Large batch of Help and i18n.  Also, make sure that the
  Fix a typo in the i18n help for the ITransact Pay Driver.
  Correct dataform captcha variable name in the help.
  Forward porting expanded patch for handling deleted things.
  Have Thingy check for existance of table and column to prevent
  Fix linking to other things and autocreating the form field for it.
  Update test to match fixed code.
  Remove the warnings pragma
  Only resize photos if they are larger than the Gallery resolutions.
  Fix a syntax error made in the i18n of the search button.
  I18n'ed a submit button in the manage transactions screen.
  ...

Conflicts:

	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/SurveyJSON.pm
	www/extras/wobject/Survey/editsurvey.js
	www/extras/wobject/Survey/editsurvey/object.js
2009-01-14 06:00:06 +00:00
Colin Kuskie
e3c77d4e80 Add a test for evaluating templates and macros in the right order
in the Snippet.  Fix a bug with that.
2009-01-12 22:23:41 +00:00
Graham Knop
b5104d9581 fixing photo comment test 2009-01-09 10:33:20 +00:00
Graham Knop
0487acca1d fix Thingy test to account for new template options 2008-12-16 21:13:21 +00:00
Patrick Donelan
fc3851705a Implemented Survey branching expressions (#9233). Woot! 2008-12-15 10:25:44 +00:00
Colin Kuskie
941240370b Add a mutator for questionsAnswered, with tests.
Correct POD for recordResponses.
Begin recordResponses answer processing tests.
2008-12-15 00:09:03 +00:00
Colin Kuskie
aa04599aec recordResponse tests (just a few)
Fix a bug where if a section is terminal, and has no questions, it did not return the terminal flag as true.
A little recordResponse POD.
2008-12-13 03:56:26 +00:00
Colin Kuskie
aafd5e5a2e goto tests. 2008-12-12 23:33:45 +00:00
Colin Kuskie
574d6cf036 nextQuestions tests.
Add POD, and make sure that answers returned by nextQuestions are safe refs.
2008-12-12 19:27:12 +00:00
Colin Kuskie
98294e4e78 Add tests for nextSectionid, nextSection, currentSection.
Add more POD to ResponseJSON
2008-12-12 00:36:08 +00:00
Colin Kuskie
c60393e44a Tests for createSurveyOrder and shuffle.
POD for several methods.
2008-12-12 00:03:16 +00:00
Colin Kuskie
1c1f01d473 Change ResponseJSON to use a proper mutator for startTime.
Add tests for startTime.
Survey uses the accessor, and no longer needs to manually set startTime.
2008-12-11 19:45:19 +00:00
Colin Kuskie
665284392f forward porting quotes in asset title fixTitle test 2008-12-11 19:20:12 +00:00
Colin Kuskie
09f7caab40 Provide a way for Template to import old packages that have headBlock properties, with tests. 2008-12-10 18:29:18 +00:00
Colin Kuskie
08bf6b5147 Flesh out the ResponseJSON test more. Add POD. 2008-12-10 02:25:42 +00:00
Colin Kuskie
8ea45fe456 Switch to using dclone from Clone::clone due to bugs under
perl 5.10
2008-12-05 04:21:43 +00:00
Colin Kuskie
ace2c81fca update SurveyJSON test to fix perl 5.10 misleading errors 2008-12-05 03:41:29 +00:00
Colin Kuskie
75da4c46bd Add more tests for coverage.
Interim checkin for debug assistance.
2008-12-05 03:32:47 +00:00
Colin Kuskie
a50c27de67 add POD, fix a few typos.
Add tests for updateQuestionAnswers
2008-12-04 23:35:40 +00:00
Colin Kuskie
75f6497924 Tests for getEditVars, getEditSectionVars and addAnswersToQuestion.
Add POD.
Fix a bug with setting verbatims in addAnswersToQuestion
2008-12-04 22:01:17 +00:00
Colin Kuskie
24fe2e6dc0 Add tests for getQuestionEditVars.
Refactor out the list of valid question types to make testing easier.
2008-12-04 20:47:42 +00:00
Colin Kuskie
0453f47bc1 Tests for getDragDrop and getAnswerEditVars.
More POD.
2008-12-04 20:18:49 +00:00
Colin Kuskie
d370772762 Make copy use safe references.
Add tests for remove, and copy.
2008-12-03 04:41:38 +00:00
Colin Kuskie
f41421058c Add wide character JSON encoding test. 2008-12-03 02:39:35 +00:00
Graham Knop
6073703999 some fixes after Storage and Storage::Image merge 2008-12-03 00:33:13 +00:00
Colin Kuskie
e961bb6f26 forward port Product JSON collateral wide character fix 2008-12-01 19:29:45 +00:00
Colin Kuskie
23f8e48f6d Update POD for several methods.
Make getObject clone data for safety and update tests.
Make newObject always alter $address for consistency and update tests.
2008-12-01 17:39:34 +00:00
Colin Kuskie
377126da8c Add more POD to SurveyJSON.
Add some basic tests for getObject, update and remove.
2008-11-30 04:30:40 +00:00
Colin Kuskie
020c882fb6 Test abusing references in getObject.
More insertObject testing.
More POD.
2008-11-29 17:29:00 +00:00
Colin Kuskie
fe33c87f13 Add tests for insertObject, and a helper method for summarizing the SurveyJSON data structure.
Add POD for insertObject.  Note that splicing beyond the end of the array will generate
a warning.
2008-11-29 05:32:14 +00:00
Colin Kuskie
63646aa497 rename test 2008-11-28 17:25:40 +00:00
Colin Kuskie
356772b722 Build Survey2 tests. Each survey2 module has at least a basic
load test, and the SurveyJSON module has many more tests in
it, testing new, log, newSection, newQuestion, newAnswer and
newObject.
2008-11-28 05:02:38 +00:00
JT Smith
782a4396b5 The deprecated use of Graphics::Magick has been eliminated. WebGUI uses
Image::Magick exclusively for all image processing functions once again.
2008-11-26 17:00:26 +00:00
JT Smith
ee84cc7611 Deprecated WebGUI::Storage::Image. WebGUI::Storage can now do everything
WebGUI::Storage::Image can do.
2008-11-26 16:06:18 +00:00