Commit graph

288 commits

Author SHA1 Message Date
Graham Knop
ed04b99872 remove WebGUI::Utility 2010-09-07 13:18:49 -05:00
Graham Knop
fadc4f34ea remove WebGUI::Utility::round 2010-08-25 12:38:14 -05:00
Scott Walters
c74572bac1 Fix typo in '_doAfterTimeLimit_options' call from property definition. 2010-08-11 19:29:18 -04:00
Doug Bell
2471517fa7 remove getAdminConsole from Survey 2010-07-15 12:54:31 -05:00
Colin Kuskie
005b9da1ac Move session->env->getIp into session->request->address 2010-07-01 13:11:01 -07:00
Colin Kuskie
7df0cc51ed Always get a fresh copy of the survey after doing revision control. 2010-06-11 19:11:12 -07:00
Colin Kuskie
1450d1361d Fix POD problems 2010-05-07 18:27:39 -07:00
Graham Knop
0efa62a73c asset immutability 2010-04-19 18:57:01 -05:00
Graham Knop
2400f19099 Merge branch 'master' into WebGUI8 2010-04-13 07:50:02 -05:00
Colin Kuskie
616d5cc866 Moose overrides for purge, purgeRevision, and purgeCache. 2010-04-07 16:43:16 -07:00
Graham Knop
913fa9ad03 clean up Tie::IxHash imports 2010-03-10 12:59:51 -06:00
Colin Kuskie
8128f54943 WebGUI now needs Test::Harness 3.17 or higher for the Survey. Fixes bug #11402. 2010-03-02 13:58:34 -08:00
Colin Kuskie
117c7897bb Closer to Roles. Remove also from WebGUI::Definition, and put use Moose in all Asset classes. 2010-02-26 12:01:25 -08:00
Graham Knop
20ee527dbd change aspect to define 2010-02-17 16:31:10 -06:00
Colin Kuskie
dc2d086b2a Fix a whole bunch of aspect comma/semicolon changes. 2010-02-15 13:52:11 -08:00
Colin Kuskie
2cb4bc45b8 remove definition subroutine from these already converted assets. 2010-02-11 16:40:09 -08:00
Colin Kuskie
d41affa4cc Update Survey for Moose and new accessors. Also update the tests. 2010-02-11 13:54:46 -08:00
Patrick Donelan
3da08fcc48 Moved Survey's "Max Resposes" option beck to Properties tab
Content Managers shouldn't need Security tab acccess to set this property
2009-10-17 13:43:42 +11:00
Patrick Donelan
f4f30cc4fe Survey_tempReport table post-report clean-up 2009-10-17 13:43:34 +11:00
Patrick Donelan
439f93f98e Further fix to Survey macro processing changes 2009-10-13 08:15:12 -07:00
Colin Kuskie
20d0630658 Fix the Survey Edit icon. Fixes bug #11122 2009-10-12 21:42:26 -07:00
Colin Kuskie
1953e71d76 www_loadSurvey has to process its own macros. Fixes bug #11088. 2009-10-05 10:16:46 -07:00
JT Smith
ccff9c7014 Converted all existing uses of cache. 2009-09-25 22:24:33 -05:00
Colin Kuskie
e3029f3661 Fix a typo in exportTransposedResults in the Survey fixes bug#10990. 2009-09-18 10:37:39 -07:00
hao
082b04b967 Fixed bug #10982 where survey admin menu options appear twice. Caused by the Survey Asset directly calling its parent getAdminConsole method instead of instantiating a session instance of the method. 2009-09-15 12:02:49 -04:00
Patrick Donelan
f3c3bfb4dc Fixed GUID string comparisons (eq instead of ==) 2009-08-23 07:44:41 +00:00
Patrick Donelan
280e902c09 Fixes to Survey reporting and performance improvements
Fix: Survey export simple/transposed results to csv or tab
Fix: loadTempReportTable handling of revisionDates (and documentation)
Fix: returnResponseForReporting handling of mc questions
NYTProf performance improvements
Added some very basic Survey reporting tests
2009-08-23 05:15:32 +00:00
Patrick Donelan
ffea2a2825 Minor fix - made subclass dependency explicit 2009-08-19 06:43:38 +00:00
Patrick Donelan
e85335cbc7 Made Survey::getResponseDetails template vars consistent 2009-08-12 06:28:08 +00:00
Patrick Donelan
146373937d Fixed two new Survey bugs
* Survey response startDate stored twice
startDate was being stored both in a column in Survey_response and also inside the
serialised responseJSON. Consolidated to column and moved startDate methods to
Survey.pm where they are actually used. Was not causing errors because both copies
were initialised to "now" at response creation time, and then never changed (this is also
why we don't need any repair code to fix existing survey repsonses in the wild).

* Survey ExpireIncompleteSurveyResponses Workflow Activity not enabled
The only time you'd actually want to modify startDate is when you're trying to simulate
response expiry in test code, which is why I found the above bug when I was writing the
missing test suite for ExpireIncompleteSurveyResponses. Along with test suite, added
upgrade code to enable workflow activity and add it  to the Daily Maintenance Tasks
workflow. Also made minor fixes to the workflow activity, such as making sure it uses
the correct isComplete code.
2009-08-07 01:08:39 +00:00
Colin Kuskie
2c4ebe6333 Fix misspelled i18n for Gradebook. 2009-07-31 15:51:55 +00:00
Patrick Donelan
10755c3b83 Fixed Survey reporting bugs
* Survey::responseJSON mutator was not doing the right thing when
  responseId argument was passed in
* www_viewGradeBook template fixes and documentation
2009-07-29 06:37:34 +00:00
Patrick Donelan
84d8b24cec Add missing POD to SurveyJSON
Also fix a bug I noticed while updating POD - when removing a
multiple-choice bundle the question should have its questionType
set to the generic "Multiple Choice' question type rather than
leaving it set to the now-deleted bundle questionType.
2009-07-12 03:28:54 +00:00
Colin Kuskie
3cd1e13051 Add missing POD and fix POD typos in subroutine names. 30/441 failing 100% POD coverage. 2009-07-04 20:09:35 +00:00
Patrick Donelan
79692ca8fe Fixed: Survey - check for groupToEditSurvey as well as groupToViewSurvey in canView 2009-07-03 01:39:34 +00:00
Patrick Donelan
bb3de4bf96 Fixed minor Survey bug that could prevent tests from running in some cases 2009-06-27 00:04:38 +00:00
Patrick Donelan
eca88d70f4 Fixed bug where Survey was leaving uncommitted version tags behind 2009-06-26 02:30:12 +00:00
Patrick Donelan
17c7618605 Removed debug line 2009-06-22 23:21:35 +00:00
Patrick Donelan
b5186bfbab fixed #10565: Survey: add question doing double-create 2009-06-22 07:08:08 +00:00
Patrick Donelan
3fccab7743 Minor bugfixes/tweaks to Survey 2009-06-22 07:07:41 +00:00
Patrick Donelan
e44c7bae2e Small survey bug fix to Survey::persistResponseJSON 2009-06-17 07:21:35 +00:00
Patrick Donelan
d820d43760 Fixed #10520 - Survey responses get confused if survey structure modified
Survey responses are now revision-aware.
The survey structure gets revisioned automatically as necessary when changes
are made on the Edit Survey screen (as necessary ~~ a response exists
for the current revision)
2009-06-16 06:25:38 +00:00
Patrick Donelan
9004e5d711 Survey cleanup and minor bug fixes
Cleaned up edit page tabs
Improved API docs
Added noCreate option to responseId so that it doesn't create unnecessary responses
Added groupToTakeSurvey priv check to takeSurvey
2009-06-09 03:27:06 +00:00
Patrick Donelan
977be654cc Fixed bug in privs check for Survey::www_showFeedback 2009-06-09 03:26:44 +00:00
Patrick Donelan
cdc44a1bfb Made Survey Preview a little less brutal 2009-06-09 03:26:24 +00:00
Colin Kuskie
0cf94b4c32 Fix a syntax warning in Survey.pm 2009-06-04 21:45:13 +00:00
Patrick Donelan
d3f5c9ecfd Survey - differentiated between endDate and endDateEpoch. 2009-06-04 07:22:48 +00:00
Patrick Donelan
216a48580a Fixed #9927 Survey - verbatim
Fixed inconsistencies between answer 'comment' and 'verbatim'.
Updated tests.
Made minor changes to reporting methods but they still need some love.
2009-06-03 00:29:29 +00:00
Colin Kuskie
80dfb9ffd0 Throw an exception in all wobjects if the main template (used by view)
has been deleted.
2009-06-02 19:34:18 +00:00
Patrick Donelan
084a0c3105 Fixed naff Survey::takenCount bug, added explicit test for it 2009-06-02 02:42:37 +00:00