Commit graph

11203 commits

Author SHA1 Message Date
Patrick Donelan
66a2adcbe5 Moved ResponseJSON data hash to private variable, for security and
consistency with SurveyJSON

Added some more accessors/mutators, and param validation
2009-02-03 08:32:40 +00:00
Patrick Donelan
17dbf7fa66 Updated Survey.pm to use the new SurveyJSON contructor params 2009-02-03 08:32:22 +00:00
Patrick Donelan
57fb3cb238 Refactored SurveyJSON for perlcritic compliance.
Simplified some code, refactored out some C-isms.
2009-02-03 08:32:06 +00:00
Patrick Donelan
821635eb71 Refactored ResponseJSON and SurveyJSON
Added Params::Validate to ResponseJSON.pm
Refactored ResponseJSON constructor and re-ordered params for
consistency
Added new ->session accessor
Updates tests
Removed unnecessary logging methods
Further refactored SurveyJSON, gave private variables underscores,
replaced direct hash access with accessors
2009-02-03 08:31:43 +00:00
Patrick Donelan
8833459c74 Added param validation to all SurveyJSON.pm methods. 2009-02-03 08:31:24 +00:00
Patrick Donelan
d00c8661f3 Made first argument to SurveyJSON contructor $session for consistency
with rest of wg.

Also added Params::Validate validation.
2009-02-03 08:31:07 +00:00
Patrick Donelan
76d677ab4f Updated & cleaned YUI includes in Default Survey Edit template 2009-02-03 08:30:48 +00:00
Colin Kuskie
99d6796675 Prevent Event, WikiPage and Thread from being pasted places where they don't
belong.  This allows chained method calls to "getMyParent", getParent, getWiki, getCalendar, etc.
to work.
Adds the new canPaste and validParent method to Asset and AssetClipboard.
2009-02-03 04:43:11 +00:00
Colin Kuskie
151ebbde09 Also leaking a version tag. 2009-02-03 04:23:22 +00:00
Colin Kuskie
4ac37757ca Fix a leaking test. 2009-02-03 04:09:01 +00:00
Colin Kuskie
512b672ac6 Fix a few broken help entries. 2009-02-03 01:46:12 +00:00
Colin Kuskie
e0f6eec470 Fix the bad subnet checking in spectreTest. Subnet checks should only happen
in www_spectreTest, until a way is found to round trip data in and out of spectre
back to WebGUI.  Documented how and where that should occur.
2009-02-03 00:14:05 +00:00
Colin Kuskie
1091616705 Prevent WikiPages from being manually added to places where they shouldn't. 2009-02-03 00:11:52 +00:00
Yung Han Khoe
8dd4d66c96 fixed #9635: Matrix - Add attributes not working 2009-02-03 00:11:46 +00:00
Tabitha Zipperer
cd1992c9b5 Added styles for taking a survey 2009-02-02 22:44:50 +00:00
David Delikat
118c18569f caching now takes into account the correct parameter for pagination 2009-01-31 19:12:34 +00:00
Colin Kuskie
101e95fd63 Prevent Wiki Pages from being pasted to anywhere but a Wiki Master.
Add provisions for other assets to behave similarly.
2009-01-30 23:49:19 +00:00
Colin Kuskie
826089f075 Add a test to check for hardcoded extras in templates, and
in the extra head tags of all assets.
2009-01-30 16:49:00 +00:00
Colin Kuskie
ee9369392d Fix a test I broke with the i18n refactor for the GalleryFile 2009-01-29 23:46:39 +00:00
Colin Kuskie
097de28bd0 Fix a perl syntax error, and use if/elsif/else instead
of cascaded if, since the 2nd if would always win.
2009-01-29 23:38:14 +00:00
Colin Kuskie
2f599812f4 Fix the mime/type and content of the XML sent to ITransact. 2009-01-29 23:24:53 +00:00
Yung Han Khoe
df7de822ff Adding help for Survey Questions template 2009-01-29 23:17:29 +00:00
Paul Driver
9b749bc2ff Delete friends now removes both sides of the friendship. 2009-01-29 20:35:05 +00:00
Meg O'Keefe Andrea
285c910480 new account skins 2009-01-29 19:39:02 +00:00
David Delikat
e3e24b37b0 fixed #9596: Articles now use a semi-unique pagination variable based on asset id
also restored the 'synopsis = first page' feature in Asset::Post::getSynopsisAndContent
2009-01-29 17:45:52 +00:00
Colin Kuskie
70b0c262f5 Forward port removing workflow instances that don't have an underlying workflow anymore. 2009-01-29 17:40:43 +00:00
Stephen Opal
fb3c85fdd2 When using only a groupId in create, the code assumed that the call also intended to use a userId, which it acquired from $session->user->userId.
This caused group type administrative notices to also go to the initial user.
2009-01-29 17:36:36 +00:00
Doug Bell
dd6c492016 fixed copyright 2009-01-29 17:29:58 +00:00
Colin Kuskie
6a9e65d7d3 Backporting GalleryAlbum isHidden fix. 2009-01-29 17:14:46 +00:00
Yung Han Khoe
1d0db51904 Updating Survey Help, more to come. 2009-01-29 16:40:11 +00:00
Colin Kuskie
83ca676be5 We want to add tests, not logically or them... 2009-01-29 06:00:50 +00:00
Tabitha Zipperer
54d73c9bc9 Adding margins back to tabs. 2009-01-29 01:37:15 +00:00
Tabitha Zipperer
1ffcd7399f Fixing IE spacing problem on tabs 2009-01-29 01:24:41 +00:00
Colin Kuskie
129d45ca2a Refactor gallery code to use old i18n technologies so they can
be verified with the critic_labels test.
2009-01-28 22:20:39 +00:00
Graham Knop
e345fd8706 fixed #9592: DataForm deleteAttachedFiles method can crash 2009-01-28 18:24:26 +00:00
Graham Knop
13d0433b53 fixed #9375: Syndicated Content asset improperly decodes wide XML entities 2009-01-28 18:03:44 +00:00
Graham Knop
e0e6e9b947 fixed: Syndicated Content asset doesn't work with feeds that specify their encodings via HTTP headers 2009-01-28 18:03:37 +00:00
Graham Knop
a8b096d675 preparing for 7.6.11 dev 2009-01-28 17:39:28 +00:00
Graham Knop
6cba44d0e3 preparing for 7.6.10 release 2009-01-28 16:39:51 +00:00
Graham Knop
73ba4cddcc fixing macro usage in matrix compare template 2009-01-28 16:39:46 +00:00
Graham Knop
2bc81f7757 fixing tests for Form changes 2009-01-28 16:39:38 +00:00
Graham Knop
744751a86f cleaning up function in List form type 2009-01-28 16:39:32 +00:00
Graham Knop
c7dac4aa42 cleaning up survey pod 2009-01-28 16:39:27 +00:00
Graham Knop
c7c4b8aecd fix error reporting in Syndicated Content 2009-01-28 16:39:21 +00:00
Graham Knop
b89bb0740e log ITransact XML at debug instead of info to make logging credit cards less likely 2009-01-28 16:39:14 +00:00
Graham Knop
9d1fdfd1c6 remove needless import 2009-01-28 16:39:07 +00:00
Yung Han Khoe
0812e21b5b fixed #9215: Survey 2.0 results screens missing 2009-01-28 15:24:20 +00:00
Yung Han Khoe
57b3d4cbc2 added Statistical overview screen to survey 2009-01-28 15:22:50 +00:00
Doug Bell
188f22b678 leaving a TODO 2009-01-27 23:50:48 +00:00
Colin Kuskie
7f2bc2458c Handle the case where someone is doing double quoted variable interpolation
in the label part of an i18n fetch.
2009-01-27 20:33:55 +00:00