Commit graph

187 commits

Author SHA1 Message Date
Colin Kuskie
eadb9ada36 Implemented the last few tests to give Session::Style 100% coverage.
There are still a few functional tests that need to be written, they're
codified as TODOs.

In Session/Style.pm, in all methods that have a send immediate option
(when sent=1), they no longer send and cache.  This prevents duplicate
heag tags from being generated if generateAdditionalHeadTags was
ever called twice.
2006-10-12 22:43:33 +00:00
Colin Kuskie
514c2263fc Added tests to cover userStyle.
fixed a bug in userStyle where it would not process data that was false.
process will do this, so I made userStyle do it as well by adding
in a definedness check on $output.
2006-10-12 04:53:43 +00:00
Colin Kuskie
01a09cbea9 Add tests for printableStyleTemplateId.
Found a fixed an infinite loop in WebGUI::Style::process

If an asset was requested to be printed who does not have a
printableStyleTemplateId then process would recurse back up the
lineage until it does find an asset with a printableStyleTemplateId.
Eventually, if none is found, it will find the Asset Root, whose
parent is itself, and it will loop forever.

I added code to jump out of the loop if it recurses back to the
assetRoot.
2006-10-12 04:06:13 +00:00
Colin Kuskie
7867ce3573 more POD docs for WebGUI::Session::Style->process that describe hierarchy if templates 2006-10-12 01:13:41 +00:00
Colin Kuskie
a86c34df84 Added 5 more tests for Style's process method, checking for meta tags
for default processing and for meta tags when cache busting is enabled.

Fixed a bug where the default meta tag Generator did not contain the
WebGUI version.

Added lots of POD to the Style module detailing how meta tags are
handled in various cases.
2006-10-11 04:15:21 +00:00
Colin Kuskie
b1bb5d0b58 Fix broken templateId in Session/Style/process when useEmptyStyle was
requested.  It used to be 6, but at somepoint in the 6.x cycle it
was changed to be PBtmpl0000000000000132 in the database.

Added tests that verify that it works correctly.
2006-10-11 00:32:42 +00:00
Colin Kuskie
6cf1afc6a7 Add more POD to Style.pm to document that sent is set to true after this method
is called.

Add tests to check personalStyleTemplate and sent inside process method.
2006-10-10 23:10:31 +00:00
Colin Kuskie
5920a6d482 10 more tests for methods in Session/Style.pm
Refactored generateAdditionalHeadTags to remove two loops.
2006-10-05 03:40:39 +00:00
Colin Kuskie
ff2344cdad Added comments to the POD in Var.pm that creating a Var object overwrites
the Session Id.  This is by design.

Added a check to Style.pm so that if no params are passed to setLink that
it won't die by trying to deref undef into a hashref.

First set of tests for Session/Style added.
2006-10-03 23:27:08 +00:00
Colin Kuskie
f5aaa2e996 Additional tests to cover WebGUI::Session::Scratch.
Found and fixed a but in Session/Scratch/deleteNameByValue.  It would
not delete any value that was false (0, '' or undef).  Added a defined-ness
check to make sure it will delete 0 or '', but undef is still not handled.
Added POD to say that this was the case.
2006-10-01 21:49:05 +00:00
Colin Kuskie
d995ff09fe Fixed a bug with WebGUI::Session::Url::page where, if preventProxyCache
was enabled a noCache param was always added to the URL.  In some
cases it would add 2 noCache params.

To fix this, I added a skipPreventProxyCache param to the gateway method,
and page just passes $pairs and $skipPreventProxyCache to gateway.

Added tests to Url.t to test gateway, page, makeAbsolute and urlize
to bring its coverage up to 100%.

Added tests to Stow.t to bring it's coverage up to 100% as well.
2006-09-30 17:23:44 +00:00
Colin Kuskie
b1a5c46fcb add 6 more tests for page and clean up the POD 2006-09-29 22:51:18 +00:00
Colin Kuskie
2d2b780ed6 More comments and POD for Session/Url.pm.
Tests for escape, unescape, extras methods.  Test code is big enough 
that I've added section delimiting comments.  This has helped make
the code a lot more readable.
2006-09-29 03:32:24 +00:00
Colin Kuskie
8174f9d2b4 More tests for WebGUI::Session::Url::getSiteUrl, which now has 100% test coverage.
Refactored getSiteUrl so it is very obvious as to how it works, replacing
code that was hard to cover.
2006-09-29 02:30:54 +00:00
Colin Kuskie
86a5cb9128 Fix the same problem with form params in getRequestedUrl as in
getRefererUrl and add tests to detect it.
2006-09-25 04:47:05 +00:00
Colin Kuskie
eea7b941c9 A few more tests to kick coverage up to 100 on WebGUI::Session::Setting
Convert it to use placeholders as well.
More WebGUI::Session::Url tests, and some bug fixes:
	getRefererUrl returned parameters and accepted weird methods that
	looked like http but weren't.
2006-09-25 03:49:25 +00:00
Colin Kuskie
00e37ae971 finalized Var test with 100% coverage 2006-09-23 02:49:37 +00:00
Colin Kuskie
56e78708a4 Add a comment to WebGUI::Session::Var::start that if no userSessionId is passed
that a new userSessionId will be created and that the current sessionId (the actual
session object's id) will be set to this new id.
Add several new tests to Session/Var.t  Tried hard to exploit the change in 
sessionId and haven't found a way, yet.
2006-09-22 03:44:34 +00:00
Drake
a170904340 Add support for browser-session cookies, using a cookieTTL value of
"session".
2006-09-21 18:42:41 +00:00
Colin Kuskie
381ce45c1a Add 7 tests to Session/Var.t. Some of them are redundant. That will
be fixed later.
Added lots of comments to start and new subs.  Changed db methods to
use placeholders.  Changed timely data to call time once so that they
all match.
2006-09-21 03:06:04 +00:00
Drake
08858c20c3 Revert erroneously-included hunk in previous commit. 2006-09-21 00:50:14 +00:00
Drake
1ad3f6e3b3 Make DBI connect errors not infinitely recurse. 2006-09-21 00:25:01 +00:00
JT Smith
90cb569bb5 - fix: deleting workflows did not delete related instances and crons
- Added a "run" link to the scheduler and the running workflows listings to
   aid in debugging workflow errors.
 - fix: profile fields not validated by WebGUI::User
2006-09-15 06:08:30 +00:00
Colin Kuskie
66d98f371c Update some POD in Stow and PageTitle.
Fix several tests with bad coverage.
2006-09-14 15:54:54 +00:00
Roy Johnson
aac1df8dfb fix - makePrintable operation with other styleId 2006-09-07 18:17:32 +00:00
JT Smith
35db285a67 - rfe: Workflow activity for assigning users to a group
- The prevent proxy cache setting also now sets anti-caching meta tags and
   HTTP headers.
2006-08-16 22:04:59 +00:00
Colin Kuskie
b3678c6795 fix bad minute spec in Session/DateTime/epochToHttp. Add tests to cover 2006-08-09 20:06:19 +00:00
JT Smith
c956ba3969 - Added an option to override the session cookie domain.
- fix: Search results not showing synopses
 - fix: Redirects get displayed inside page layouts as '0'
 - fix: Mysterious "0" Appearing When Admin Is Off
 - fix: Deletion of Products
2006-08-08 17:27:41 +00:00
JT Smith
03b4b0ed33 - fix: Head Block in styles
- fix: select assetVersionTag
 - fix: Infinite recursion
 - fix: assetUiLevel override broken
 - fix: Indexing files failes (derck)
 - fix: Unable to approve New listings on Matrix
2006-07-25 17:15:57 +00:00
Colin Kuskie
5dbd9b44c9 Fixed a typo in the POD for Session/Env.pm
Added more docs for find method in Group.pm
Fixed a latent bug that would probably never occur in Macro/GroupAdd.pm
If Group->find is called with the name of a group that doesn't exist,
then Group will return an object with defaults, and the guid of the
group is undef, not ''.  However, since by default autoAdd is off,
the Macro will still do the right thing.
GroupDelete has the same bug, but it shouldn't be patched until there's
a test written for it.
2006-07-24 05:08:17 +00:00
JT Smith
9f3ff77dbd webgui for windows changes 2006-07-21 20:42:50 +00:00
Colin Kuskie
f3a1f0f9f2 GroupText.t: fix number of tests
Session/Id.pm: add a method to validate GUIDs, change s/// to tr/// for efficiency.
Session.pm: change open to use new Id.pm validation method
Scratch.t: Change test from ok to is so that it tells you what the failing ID is.
Id.t: Add validation tests in addition to uniqueness tests.  Fix the uniqueness test so that it works.  Add tests to check the new validation method
2006-07-15 01:54:49 +00:00
JT Smith
8abbdf5e41 there should have been a space here 2006-07-13 21:01:23 +00:00
Wouter van Oijen
dcfc935ed7 Fixing error in POD (Whitespace.t) 2006-07-13 11:45:15 +00:00
JT Smith
a440cb5f41 fix: Security bug in session env 2006-07-11 20:32:46 +00:00
JT Smith
63b22dc502 - fix: Style Wizard
- fix: content-type
 - fix: Two cookies and incorrect Last-Modified date in HTTP header
 - fix: HTTP status code 404 broken
 - fix: Add missing page on Problem With Request
 - fix: Avatar/photo upload not working
 - fix: Shortcut with content lock fails (Thanks to Michelle Lamar)
2006-07-11 20:08:30 +00:00
Wouter van Oijen
2d9565775f POD fixes and removing debug output 2006-07-11 09:05:22 +00:00
JT Smith
a511ab9d50 preparing for 7.0.0 release 2006-07-05 15:05:28 +00:00
Roy Johnson
c93d6ba4d2 fix: ?op=listTransactions causes fatal
Session/DateTime addToTime, addToDate, and addToDateTime now default to the current epoch as a starting point.
2006-06-14 16:23:20 +00:00
JT Smith
af84fb43af - Fixed a macro processing problem on the Redirect asset.
- Added a log info entry when a redirect occurs.
2006-06-13 00:55:35 +00:00
JT Smith
ce50d2808b - fix: Uncommitted, new Assets BREAK Navigations
- fix: I get on the chewed page
 - fix: Bug in updateMetaData function in AssetMetaData.pm
 - fix: Problems with In/Out Board
 - fix: Alternate Apache Port breaks "Commit with Approval"
 - Rearranged the "Getting Started" page in the default content to make it
   easier to follow for noobs.
2006-06-12 19:41:09 +00:00
JT Smith
255ec42344 switcharoo on debug and info 2006-06-09 17:24:06 +00:00
Wouter van Oijen
9a087b0ac8 Cleaning up and bugfixing DateTime.pm 2006-06-02 08:25:06 +00:00
JT Smith
2568e6c8ce - fix: Link to page in Webgui Page Tree not working in IE
- fix: Not Found page not working
 - Made debug output more colorful, and set queries as info rather than debug.
2006-05-31 18:12:14 +00:00
JT Smith
41e655b452 - fix: New page layout instead of not found
- fix: Rollback
 - fix: debug output
 - fix: Can't delete images at product asset
fixed a problem with file/image form uploads
rearranged group methods for alphabetical order
removed matt's hack for group caching and replaced it with the right way
2006-05-30 22:35:12 +00:00
JT Smith
741b523ad3 - fix create.sql / style3
- fix Spectre memory consumption
 - fix password vidible in debug mode
 - fix No way to add an advertisment to an adspace.
2006-05-25 04:56:12 +00:00
Wouter van Oijen
e81ce2759a Fixed POD in 12 files reported by new test for invalid whitespace 2006-05-20 10:39:16 +00:00
Matthew Wilson
4078d4d417 validating (and caching) timezone. 2006-05-19 02:07:52 +00:00
JT Smith
5041f31025 added drag bar 2006-05-18 23:04:23 +00:00
JT Smith
61050f1aed fix [ 1489528 ] HTTP header contains invalid time-stamp 2006-05-18 00:09:20 +00:00