Commit graph

4453 commits

Author SHA1 Message Date
Colin Kuskie
f5aaa2e996 Additional tests to cover WebGUI::Session::Scratch.
Found and fixed a but in Session/Scratch/deleteNameByValue.  It would
not delete any value that was false (0, '' or undef).  Added a defined-ness
check to make sure it will delete 0 or '', but undef is still not handled.
Added POD to say that this was the case.
2006-10-01 21:49:05 +00:00
JT Smith
e22c679421 - Removed the need for DateTime::Cron::Simple, which also added the ability
to use ! < and > in schedules.
2006-09-30 19:29:47 +00:00
Colin Kuskie
d995ff09fe Fixed a bug with WebGUI::Session::Url::page where, if preventProxyCache
was enabled a noCache param was always added to the URL.  In some
cases it would add 2 noCache params.

To fix this, I added a skipPreventProxyCache param to the gateway method,
and page just passes $pairs and $skipPreventProxyCache to gateway.

Added tests to Url.t to test gateway, page, makeAbsolute and urlize
to bring its coverage up to 100%.

Added tests to Stow.t to bring it's coverage up to 100% as well.
2006-09-30 17:23:44 +00:00
Colin Kuskie
b1a5c46fcb add 6 more tests for page and clean up the POD 2006-09-29 22:51:18 +00:00
Drake
066dbab461 Make Project Management asset task editor default start date of task
to start date of project.
2006-09-29 17:54:05 +00:00
Colin Kuskie
053a0b4cfe fix errors in pod for www_setScratch 2006-09-29 17:44:40 +00:00
Martin Kamerbeek
9096e6f9fe Fixed some bugs and refactored some parts of the SQLForm. 2006-09-29 13:16:11 +00:00
Colin Kuskie
2d2b780ed6 More comments and POD for Session/Url.pm.
Tests for escape, unescape, extras methods.  Test code is big enough 
that I've added section delimiting comments.  This has helped make
the code a lot more readable.
2006-09-29 03:32:24 +00:00
Colin Kuskie
8174f9d2b4 More tests for WebGUI::Session::Url::getSiteUrl, which now has 100% test coverage.
Refactored getSiteUrl so it is very obvious as to how it works, replacing
code that was hard to cover.
2006-09-29 02:30:54 +00:00
Drake
c71a1ac5ee Refactor getEditForm override back into definition clauses for Collaboration
asset.  Should still do this for the remaining assets that no longer need
getEditForm overrides with the existence of autoGenerateForms in definition.
2006-09-29 01:50:58 +00:00
Drake
da1a49f183 Improve robustness of Stock Data asset on erroneous or absent
data, and add a timeout.  Associated refactoring.
2006-09-29 00:18:43 +00:00
Drake
e8fd02ca9e Fix HTTP Proxy asset file uploads. 2006-09-28 01:49:12 +00:00
Drake
bb360794c1 Partially fix sending of invalid Message-ID headers from post notifications.
Associated refactoring.  The actual determination of the Message-ID still
needs some work, though.
2006-09-27 23:59:00 +00:00
JT Smith
f8d22359d5 Images now create revisions as you resize them, so you can roll back to a
previous size.
adjusted roy's test because it's not accurate
2006-09-27 21:19:19 +00:00
Drake
057d743dfb Fix problem with attachment section of post form miscalculating
the number of new attachments uploadable.
2006-09-27 02:00:49 +00:00
JT Smith
58b3128a3a Fixed the search function that broke in 7.0.7.
also fixed a user profile problemm
2006-09-26 20:34:59 +00:00
Roy Johnson
efebe33ecf fix - File upload (document HTTP filesize upload restrictions) 2006-09-26 17:04:08 +00:00
Drake
dbc34c6270 Apply slightly modified versions of DBell's patches for:
- admin bar causing pages to extend forever
  - changing asset URL returning to old URL rather than new
  - performance indicators interfering with non-HTML data
2006-09-26 04:59:15 +00:00
Drake
4f7a3bf490 Fix bad interaction between WebGUI::Asset->new() and caching mechanism. 2006-09-26 04:08:16 +00:00
Drake
1dd24dd6b7 Refactor duplicated asset export code. Fix asset context error
in the process, which should in turn fix a few related bugs
with static export.
2006-09-25 21:36:56 +00:00
Drake
8ffc2f57c2 Fix erroneous instances of printf into sprintf in AssetExportHtml.pm.
Remove extraneous error text from some internationalization files.
2006-09-25 19:11:05 +00:00
Colin Kuskie
86a5cb9128 Fix the same problem with form params in getRequestedUrl as in
getRefererUrl and add tests to detect it.
2006-09-25 04:47:05 +00:00
Colin Kuskie
eea7b941c9 A few more tests to kick coverage up to 100 on WebGUI::Session::Setting
Convert it to use placeholders as well.
More WebGUI::Session::Url tests, and some bug fixes:
	getRefererUrl returned parameters and accepted weird methods that
	looked like http but weren't.
2006-09-25 03:49:25 +00:00
Colin Kuskie
00e37ae971 finalized Var test with 100% coverage 2006-09-23 02:49:37 +00:00
Drake
b196473eaf Make WeatherData use basename for alt text of icons, rather than full URL.
Also change the if/if/if linear-search lookup that it was using to a hash.
2006-09-23 02:33:57 +00:00
Drake
c438d55310 Normalized signature of Asset::duplicate. This involved going through
existing overrides and callers for that method and making sure they followed
the correct signature.  Various related cleanups.

This should fix those bugs with collaboration systems refusing to be copied
or deployed as packages.
2006-09-23 01:33:46 +00:00
JT Smith
3f45819b49 fixed a bug that would only happen when you tried to deploy a package that contained collaboration systems with posts 2006-09-22 18:09:08 +00:00
Colin Kuskie
56e78708a4 Add a comment to WebGUI::Session::Var::start that if no userSessionId is passed
that a new userSessionId will be created and that the current sessionId (the actual
session object's id) will be set to this new id.
Add several new tests to Session/Var.t  Tried hard to exploit the change in 
sessionId and haven't found a way, yet.
2006-09-22 03:44:34 +00:00
Drake
a170904340 Add support for browser-session cookies, using a cookieTTL value of
"session".
2006-09-21 18:42:41 +00:00
Drake
31cbd665e6 Back out r2910 for now since it doesn't seem quite right. This
needs further examination.
2006-09-21 08:19:15 +00:00
Colin Kuskie
381ce45c1a Add 7 tests to Session/Var.t. Some of them are redundant. That will
be fixed later.
Added lots of comments to start and new subs.  Changed db methods to
use placeholders.  Changed timely data to call time once so that they
all match.
2006-09-21 03:06:04 +00:00
Drake
643f792008 Remove extraneous debug message. 2006-09-21 01:45:50 +00:00
Drake
fcbefb7286 Make clipboard copies not do the bizarre thing that duplicate usually does
where the duplicate asset becomes a child of the original.  This fixes the
error with copying Collaboration System assets.
2006-09-21 01:12:56 +00:00
Drake
08858c20c3 Revert erroneously-included hunk in previous commit. 2006-09-21 00:50:14 +00:00
Drake
1ad3f6e3b3 Make DBI connect errors not infinitely recurse. 2006-09-21 00:25:01 +00:00
JT Smith
b81d7cd974 fixed a typo in pod 2006-09-21 00:22:59 +00:00
Drake
05156d1232 Propagating r2864 changes properly, hopefully fixing the recent search
breakage.  Killing some massive duplication of query string generation
in the process.
2006-09-20 23:19:22 +00:00
Frank Dillon
b3874ccba9 - Fixed a bug which would cause the workflow to crash if more than a certain amount of users exists.
- Moved the alias mapping into the config file
2006-09-20 20:39:39 +00:00
Colin Kuskie
858acf5bae add comment to clarify why generateThumbnail is used instead of resize while processing uploaded images 2006-09-18 22:51:17 +00:00
Colin Kuskie
65374109b1 Final test for L_loginBox, and coverage improvements for RootTitle.
Pod and documentation fixes for L_loginBox macro.
2006-09-15 21:08:04 +00:00
JT Smith
90cb569bb5 - fix: deleting workflows did not delete related instances and crons
- Added a "run" link to the scheduler and the running workflows listings to
   aid in debugging workflow errors.
 - fix: profile fields not validated by WebGUI::User
2006-09-15 06:08:30 +00:00
JT Smith
7852441151 preparing for 7.0.8 bugfix cycle
- Fixed a couple of minor bugs with the default values of the Request
   Approval for Version Tag workflow activity.
 - Updated the hoverhelp to denote that you can use ranges in the WebGUI
   scheduler.
2006-09-15 04:58:03 +00:00
Colin Kuskie
a1bf6a2b21 Coverage fixes for date and last modified macros.
Refactor LastModified macro to use placeholders and remove an unused conditional.
2006-09-14 22:22:35 +00:00
Colin Kuskie
4d94cd929d missed passing the session to SUPER::definition 2006-09-14 18:34:41 +00:00
Colin Kuskie
66d98f371c Update some POD in Stow and PageTitle.
Fix several tests with bad coverage.
2006-09-14 15:54:54 +00:00
Roy Johnson
6ebe990f7b fix - whitespace test failing 2006-09-08 14:48:07 +00:00
Martin Kamerbeek
a8e06374ee Fixed an field type labels and an issue with displying images in the search results. 2006-09-08 12:06:34 +00:00
Drake
54dc7206c0 Fix minor errors:
- typo in changelog
  - wrong lastUpdated in i18n/English/Asset_ProjectManager.pm
2006-09-08 01:56:26 +00:00
Drake
8d27693394 Enhancement: add observer groups to project manager projects, such that
anyone who is not in the observer group cannot view the project or see
it in the project list.  Some associated refactoring of project manager
permissions.  Schema change to accommodate the new data.
2006-09-08 01:10:16 +00:00
Drake
a2521f0472 Deactivate shading representation of lag time, and remove redundant
background-color specification in the CSS to avoid confusion.
2006-09-07 22:57:17 +00:00