oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix the label test to handle not explicit i18n namespace in new

Browse source
This commit is contained in:
Colin Kuskie 2008-06-13 00:05:05 +00:00
parent 42ed751694
commit 55237e3e82
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
t/lib/Perl/Critic/Policy/WebGUI/NoIllegalI18NLabels.pm
View file

@ -73,14 +73,19 @@ sub violates {
return unless $class eq 'WebGUI::International';
my $symbol_name = _get_symbol_name($class);
return unless $symbol_name;
##It's an i18n object, see if a default namespace was passed in.
my $arg_list = $elem->snext_sibling;
return unless ref $arg_list eq 'PPI::Structure::List';
my @arguments = _get_args($arg_list);
my $namespace = $arguments[1]->[0];
return unless $namespace; ##This can be a namespace in a variable.
$namespace = $namespace->string || 'WebGUI';
my $namespace;
if ($arguments[1]) {
$namespace = $arguments[1]->[0]->string;
}
else {
$namespace = 'WebGUI';
}
$self->{_i18n_objects}->{$symbol_name} = $namespace;
return;
}