oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not call group methods on an undefined value. IOW, do not assume that we got a group.

Browse source
This commit is contained in:
Colin Kuskie 2011-06-28 17:16:09 -07:00
parent 3fa9d82bcd
commit 814845b7f1
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changelog/7.x.x.txt
View file

@ -1,4 +1,5 @@
7.10.20 7.10.20
- fixed: Do not call group methods on an undefined value.
7.10.19 7.10.19
- fixed #12169: extras uploads symlink export - fixed #12169: extras uploads symlink export

3
lib/WebGUI/User.pm
View file

@ -684,8 +684,9 @@ sub getGroupIdsRecursive {
my $self = shift; my $self = shift;
my $groupingIds = $self->getGroups( "withoutExpired" ); my $groupingIds = $self->getGroups( "withoutExpired" );
my %groupIds = map { $_ => 1 } @{ $groupingIds }; my %groupIds = map { $_ => 1 } @{ $groupingIds };
while ( my $groupingId = shift @{ $groupingIds } ) { GROUPINGID: while ( my $groupingId = shift @{ $groupingIds } ) {
my $group = WebGUI::Group->new( $self->session, $groupingId ); my $group = WebGUI::Group->new( $self->session, $groupingId );
next GROUPINGID unless $group;
for my $groupGroupingId ( @{ $group->getGroupsFor } ) { for my $groupGroupingId ( @{ $group->getGroupsFor } ) {
if ( !$groupIds{ $groupGroupingId } ) { if ( !$groupIds{ $groupGroupingId } ) {
push @{ $groupingIds }, $groupGroupingId; push @{ $groupingIds }, $groupGroupingId;