oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Forward porting bug fix for random checkout problems in the Shop

Browse source 
related to Class::InsideOut and using ref instead of refaddr/id.
This commit is contained in:
Colin Kuskie 2009-03-12 15:32:48 +00:00
parent 4c79e23196
commit c45fe174a0
4 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changelog/7.x.x.txt
View file

@ -1,6 +1,7 @@
7.7.0 7.7.0
- fixed: Template parser cannot be set - fixed: Template parser cannot be set
- fixed #9836: Matrix: Group to Add Listings is missing - fixed #9836: Matrix: Group to Add Listings is missing
- fixed #9924: WebGUI::Shop::Cart::readyForCheckout fails randomly (Henry Tang, Long Term Results B.v.)
- fixed #9873: third-> first in post template help - fixed #9873: third-> first in post template help
- fixed #9892: Typo in "Default Gallery View Album" Template [TEMPLATE] - fixed #9892: Typo in "Default Gallery View Album" Template [TEMPLATE]

2
lib/WebGUI/Shop/AddressBook.pm
View file

@ -147,7 +147,7 @@ An address object's unique id.
sub getAddress { sub getAddress {
my ($self, $addressId) = @_; my ($self, $addressId) = @_;
my $id = ref $self; my $id = id $self;
unless (exists $addressCache{$id}{$addressId}) { unless (exists $addressCache{$id}{$addressId}) {
$addressCache{$id}{$addressId} = WebGUI::Shop::Address->new($self, $addressId); $addressCache{$id}{$addressId} = WebGUI::Shop::Address->new($self, $addressId);
} }

3
lib/WebGUI/Shop/Cart.pm
View file

@ -260,7 +260,7 @@ Returns a reference to the address book for the user who's cart this is.
sub getAddressBook { sub getAddressBook {
my $self = shift; my $self = shift;
my $id = ref $self; my $id = id $self;
unless (exists $addressBookCache{$id}) { unless (exists $addressBookCache{$id}) {
$addressBookCache{$id} = WebGUI::Shop::AddressBook->newBySession($self->session); $addressBookCache{$id} = WebGUI::Shop::AddressBook->newBySession($self->session);
} }
@ -297,7 +297,6 @@ sub getItem {
unless (defined $itemId && $itemId =~ m/^[A-Za-z0-9_-]{22}$/) { unless (defined $itemId && $itemId =~ m/^[A-Za-z0-9_-]{22}$/) {
WebGUI::Error::InvalidParam->throw(error=>"Need an itemId."); WebGUI::Error::InvalidParam->throw(error=>"Need an itemId.");
} }
my $id = ref $self;
my $item = WebGUI::Shop::CartItem->new($self, $itemId); my $item = WebGUI::Shop::CartItem->new($self, $itemId);
return $item; return $item;
} }

1
lib/WebGUI/Shop/CartItem.pm
View file

@ -173,7 +173,6 @@ Returns an instanciated WebGUI::Asset::Sku object for this cart item.
sub getSku { sub getSku {
my ($self) = @_; my ($self) = @_;
my $id = ref $self;
my $asset = ''; my $asset = '';
$asset = WebGUI::Asset->newByDynamicClass($self->cart->session, $self->get("assetId")); $asset = WebGUI::Asset->newByDynamicClass($self->cart->session, $self->get("assetId"));
$asset->applyOptions($self->get("options")); $asset->applyOptions($self->get("options"));