oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add short circuiting to deleteField method in FormBuilder.

Browse source
This commit is contained in:
Colin Kuskie 2010-11-28 19:40:43 -08:00
parent e7fcf33a4d
commit ef3cbf3303
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/WebGUI/FormBuilder/Role/HasFields.pm
View file

@ -82,10 +82,11 @@ Delete a field by name. Returns the field deleted.
sub deleteField { sub deleteField {
my ( $self, $name ) = @_; my ( $self, $name ) = @_;
my $field = delete $self->{_fieldsByName}{$name}; my $field = delete $self->{_fieldsByName}{$name};
for ( my $i = 0; $i < scalar @{$self->fields}; $i++ ) { FIELD: for ( my $i = 0; $i < scalar @{$self->fields}; $i++ ) {
my $testField = $self->fields->[$i]; my $testField = $self->fields->[$i];
if ( $testField->get('name') eq $name ) { if ( $testField->get('name') eq $name ) {
splice @{$self->fields}, $i, 1; splice @{$self->fields}, $i, 1;
last FIELD;
} }
} }
return $field; return $field;