oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

These secondary canView checks are not needed, since the whole thing is guarded by the canView at the top of www_manageRevisions.

Browse source
This commit is contained in:
Colin Kuskie 2012-07-11 14:35:02 -07:00
parent a3f5b3ae6c
commit f25e3948fe
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/WebGUI/Operation/VersionTag.pm
View file

@ -613,8 +613,8 @@ sub www_manageVersions {
my $i18n = WebGUI::International->new($session,"VersionTag"); my $i18n = WebGUI::International->new($session,"VersionTag");
my ($icon, $url, $datetime, $user) = $session->quick(qw(icon url datetime user)); my ($icon, $url, $datetime, $user) = $session->quick(qw(icon url datetime user));
$ac->addSubmenuItem($url->page('op=editVersionTag'), $i18n->get("add a version tag")); $ac->addSubmenuItem($url->page('op=editVersionTag'), $i18n->get("add a version tag"));
$ac->addSubmenuItem($url->page('op=managePendingVersions'), $i18n->get("manage pending versions")) if canView($session); $ac->addSubmenuItem($url->page('op=managePendingVersions'), $i18n->get("manage pending versions"));
$ac->addSubmenuItem($url->page('op=manageCommittedVersions'), $i18n->get("manage committed versions")) if canView($session); $ac->addSubmenuItem($url->page('op=manageCommittedVersions'), $i18n->get("manage committed versions"));
my ($tag,$workingTagId) = $session->db->quickArray("select name,tagId from assetVersionTag where tagId=?",[$session->scratch->get("versionTag")]); my ($tag,$workingTagId) = $session->db->quickArray("select name,tagId from assetVersionTag where tagId=?",[$session->scratch->get("versionTag")]);
$tag ||= "None"; $tag ||= "None";
my $rollback = $i18n->get("rollback"); my $rollback = $i18n->get("rollback");
@ -630,9 +630,7 @@ sub www_manageVersions {
my $u = WebGUI::User->new($session,$tag->get("createdBy")); my $u = WebGUI::User->new($session,$tag->get("createdBy"));
$output .= '<tr> $output .= '<tr>
<td>'; <td>';
if (canView($session)) { $output .= $icon->delete("op=rollbackVersionTag;tagId=".$tag->getId,undef,$rollbackPrompt);
$output .= $icon->delete("op=rollbackVersionTag;tagId=".$tag->getId,undef,$rollbackPrompt);
}
$output .= $icon->edit("op=editVersionTag;tagId=".$tag->getId) $output .= $icon->edit("op=editVersionTag;tagId=".$tag->getId)
.'</td> .'</td>
<td><a href="'.$url->page("op=manageRevisionsInTag;tagId=".$tag->getId).'">'.$tag->get("name").'</a></td> <td><a href="'.$url->page("op=manageRevisionsInTag;tagId=".$tag->getId).'">'.$tag->get("name").'</a></td>