Colin Kuskie
182f3ecfae
increment plan for TODO test
2007-12-19 17:00:05 +00:00
Doug Bell
01c6379224
fixed some Gallery tests failing. removed some unnecessary ones. still bunch more to go...
2007-12-19 16:41:39 +00:00
Colin Kuskie
17e815281f
Comment out a test that will always fail, and cannot be trapped.
...
Add assetId and userId to the setComment call that is supposed to succeed.
2007-12-19 00:11:13 +00:00
Colin Kuskie
936e258bcd
Fix class names in tests.
...
Give each test at least 1 test in the plan, otherwise Test::Harness barfs.
2007-12-18 22:20:13 +00:00
Doug Bell
f8901ffe34
added TODO test to ensure that working with WebGUI::Storage doesnt chdir away
2007-12-18 21:26:14 +00:00
Doug Bell
53a1cbc7c2
fixes to the Gallery
2007-12-18 21:17:44 +00:00
Colin Kuskie
99274cd4ee
variables entry needs to be an array ref, not a hash ref
2007-12-18 19:05:39 +00:00
Doug Bell
30f22c9b7a
fixed some bugs in URL/Content handlers. fixed some bugs in Gallery.
2007-12-18 15:38:06 +00:00
Doug Bell
4c70aa4c71
re-integrated photogallery branch
2007-12-18 13:05:41 +00:00
Doug Bell
5222ad6be1
merged with SVN HEAD
2007-12-18 12:22:37 +00:00
Doug Bell
82e9bf8448
Finished? Ready for merge at least.
2007-12-17 22:22:06 +00:00
Colin Kuskie
58dd3e075a
Add fixUrl tests for duplicate assets and generated urls.
2007-12-17 03:10:54 +00:00
Colin Kuskie
8e52096a0a
Re-indent some fixUrl code and realign comments.
...
Add more fixUrl tests for coverage. Leading zeroes are
handled strangely.
2007-12-16 22:59:00 +00:00
Colin Kuskie
de912cf977
testing a different special state
2007-12-16 22:00:36 +00:00
JT Smith
1ce61982ed
some bug fixing
...
added some tests
2007-12-16 18:56:36 +00:00
Colin Kuskie
b70ef9d23a
Add tests to cover the removal of extensions in the "directory"
...
parts of the path. Refactor out the while loop with match and
nested s/// into a single regexp.
2007-12-16 04:13:53 +00:00
Colin Kuskie
cda571c3ef
fix syntax error with using WebGUI::Content::Asset standalone
2007-12-16 00:28:23 +00:00
Colin Kuskie
2de8dbfc9e
remove test for passthruUrls, since they are now handled by pluggable ops
2007-12-16 00:25:00 +00:00
JT Smith
09ac71093b
added a not found handler, and better debug handling
2007-12-14 22:43:08 +00:00
JT Smith
1fc11fbda8
Added pluggable URL and content handlers.
2007-12-14 22:08:09 +00:00
Doug Bell
fb33859cc6
fix: when upgrading, two revisions of same asset in same second broke upgrade
2007-12-13 20:13:27 +00:00
Doug Bell
73f1a3e379
fix: Matrix best/worst now must have 10 or more votes
2007-12-13 19:36:50 +00:00
Colin Kuskie
c5c24852ca
skipping wrong number of tests
2007-12-13 17:54:26 +00:00
Doug Bell
ac1a7dc3a3
fix: CS posts get re-ordered when copy/paste
2007-12-13 17:26:28 +00:00
Doug Bell
d0a97d0bff
fix: Import Package does nothing when re-importing trashed package
2007-12-13 16:19:59 +00:00
Jukka Raimovaara
607fdd25a2
Labels for Check and Radio Lists
2007-12-13 14:01:37 +00:00
Graham Knop
f14c6e4b91
merging 7.4 changes
2007-12-13 10:41:27 +00:00
Colin Kuskie
33ba29b338
add support for writing URL extension tests later
2007-12-13 00:29:25 +00:00
Colin Kuskie
d168c809da
forward porting url extension bugfix from branch
2007-12-12 05:32:28 +00:00
Colin Kuskie
afcc90b130
Documented a regexp in Session/Url.pm
...
Add passthruUrls to the list of URLs that are changed by fixUrl.
Wrote a bunch of POD for fixUrl
Changed the regular expressions related to badUrl so they don't need to copy the data. This
will speed them up.
Fixed a bug where trailing slashes would defeat the badUrl check.
Re-indented according to WGBP.
Added tests to cover all of the changes.
2007-12-11 22:51:31 +00:00
Colin Kuskie
c44a5a1bb6
forward porting secondary admin group access privileges when creating users
2007-12-11 21:04:21 +00:00
Colin Kuskie
ac6651cdcd
forward porting fixUrl bugfix and test
2007-12-11 16:40:05 +00:00
Doug Bell
5d1faff793
added carousel
2007-12-08 09:00:32 +00:00
Doug Bell
337103cb58
a weeks worth of changes
2007-12-08 09:00:15 +00:00
Doug Bell
f966bc572a
fix: Auto Request Commit setting creates extra version tag if asset is commited by another process
2007-12-07 23:02:55 +00:00
Colin Kuskie
a8eb245f2c
Remove debugging code.
...
Only process ->get method calls for existing i18n objects.
Handle the default namespace setup in ->new
Add POD code on how to run this from the command line.
Basically, it's done but needs to be run against more code
to handle variable based i18n calls (which need to be ignored)
and nested scope object creation.
2007-12-06 22:38:33 +00:00
Doug Bell
a30587f7ad
fix: Shouldn't modify $_ in list, PBP p114
2007-12-05 23:49:21 +00:00
Colin Kuskie
e5758898a5
Bareword file handle. See pages 202,204 of PBP. (Severity: 5)
...
Two-argument "open". See page 207 of PBP. (Severity: 5)
2007-12-05 23:09:15 +00:00
Colin Kuskie
be6b2d3e7c
do not modify $_ in list functions. PBP/114
2007-12-05 23:00:58 +00:00
Colin Kuskie
fc6cd26348
Subroutine prototypes are verboten! PBP/194
2007-12-05 17:23:48 +00:00
Colin Kuskie
98863256ea
no code allowed before use strict. PBP/429. This check found a bug in Asset::Wobject::HttpProxy::Parse.pm
2007-12-05 16:55:40 +00:00
Colin Kuskie
08fbd46d28
all loop iterators have to be declared lexical. PBP/108
2007-12-05 16:46:38 +00:00
Colin Kuskie
52132e61f4
Using a lexical loop variable inside recurseFileSystem.
2007-12-05 04:26:37 +00:00
Colin Kuskie
d23db44732
adding use strict to all these, too
2007-12-05 04:21:56 +00:00
Colin Kuskie
b2901f4271
correct punctuation
2007-12-05 04:20:29 +00:00
Colin Kuskie
93ea47a4c0
Perl::Critic has a policy check for putting any code
...
before you apply strictures (use strict, use warnings, etc.)
Add calls to use strict to each Help module. This is probably
an overstrict interpretation of the rule.
2007-12-05 04:16:54 +00:00
Colin Kuskie
4fabea706d
Perl::Critic: no code before strictures are applied
2007-12-05 00:34:46 +00:00
Colin Kuskie
96178fd70c
first round of Perl::Critic cleanups. Do not use return undef, use a bare return instead
2007-12-05 00:30:43 +00:00
Colin Kuskie
75041656ee
adding more debug statements to Storage/Image.t
2007-12-04 21:31:30 +00:00
Colin Kuskie
72906e27fb
fixing handling of http:// calls in the Extras URL
2007-12-04 21:25:32 +00:00
