Commit graph

10473 commits

Author SHA1 Message Date
Patrick Donelan
306502465c Started refactoring nextQuestions in ResponseJSON
Made perlcritic happier
Extracted getQuestionResponses from processGotoExpression
Eliminated getPreviousAnswer
2009-02-06 01:56:54 +00:00
Patrick Donelan
3340a675b7 Updated Survey.pm to use new ResponseJSON.pm methods 2009-02-06 01:56:35 +00:00
Patrick Donelan
345989370f Renamed ResponseJSON branching methods 2009-02-06 01:56:18 +00:00
Patrick Donelan
932a033b58 More ResponseJSON refactoring
Removed unnecessary $session argument from recordResponses
Refactored nextQuestions to return a list rather than an arrayref
Lots more documentation for ResponseJSON
More param validation for ResponseJSON
Refactored recordResponses
Updated tests
2009-02-06 01:55:56 +00:00
Patrick Donelan
90d314d2f1 Refactored next/last response/section related accessors and mutators
(and tests).

Added more documentation.
2009-02-06 01:55:33 +00:00
Patrick Donelan
669e986189 Replaced ResponseJSON's implementation of shuffle with List::Util's
shuffle and updated Colin's ninja shuffle tests
2009-02-04 02:05:44 +00:00
Patrick Donelan
477f014177 Improved createSurveyOrder documentation, and made perlcritic happy 2009-02-04 00:16:44 +00:00
Patrick Donelan
6fb325699f Refactored createSurveyOrder in ResponseJSON
Added lastSectionIndex, lastQuestionIndex, lastAswerIndex convenience
methods to SurveyJSON to simplify iterations over Sections, Questions
and Answers
2009-02-04 00:16:26 +00:00
Patrick Donelan
66a2adcbe5 Moved ResponseJSON data hash to private variable, for security and
consistency with SurveyJSON

Added some more accessors/mutators, and param validation
2009-02-03 08:32:40 +00:00
Patrick Donelan
17dbf7fa66 Updated Survey.pm to use the new SurveyJSON contructor params 2009-02-03 08:32:22 +00:00
Patrick Donelan
57fb3cb238 Refactored SurveyJSON for perlcritic compliance.
Simplified some code, refactored out some C-isms.
2009-02-03 08:32:06 +00:00
Patrick Donelan
821635eb71 Refactored ResponseJSON and SurveyJSON
Added Params::Validate to ResponseJSON.pm
Refactored ResponseJSON constructor and re-ordered params for
consistency
Added new ->session accessor
Updates tests
Removed unnecessary logging methods
Further refactored SurveyJSON, gave private variables underscores,
replaced direct hash access with accessors
2009-02-03 08:31:43 +00:00
Patrick Donelan
8833459c74 Added param validation to all SurveyJSON.pm methods. 2009-02-03 08:31:24 +00:00
Patrick Donelan
d00c8661f3 Made first argument to SurveyJSON contructor $session for consistency
with rest of wg.

Also added Params::Validate validation.
2009-02-03 08:31:07 +00:00
Patrick Donelan
76d677ab4f Updated & cleaned YUI includes in Default Survey Edit template 2009-02-03 08:30:48 +00:00
Patrick Donelan
a1033aeaa2 Replaced all decode/encode_json method calls with to/from_json method
calls now that we've licked the Survey encoding bug (wrong mysql db
field type)
2009-01-27 05:47:36 +00:00
Patrick Donelan
c4eb4e3b57 Refactored updateQuestionAnswers and addAnswersToQuestion in SurveyJSON 2009-01-26 02:20:28 +00:00
Patrick Donelan
a2d01c34da Fixed a bug where newly created questions would not pre-populate answers
(caused by my refactoring)
2009-01-26 02:20:11 +00:00
Patrick Donelan
1376c8ae92 Merge commit WebGUI_7.6.9-beta into survey-rfe
* commit 'tags/WebGUI_7.6.9-beta': (31 commits)
  Release 7.6.9-beta
  preparing for 7.6.9 release
  fixed: Exporting to static files can leak large amounts of memory
  fixed: HTTP Proxy doesn't serve new content to visitors
  use to_json and from_json in more places instead of encode_json and decode_json
  Document the heretofore missing date template variable in
  Qualify a chained method call when getting Workflow instances.  If the
  Attempt to fix IE6 bug
  fixed: ukplayer example is now loaded with swfobject.js released under the MIT licence, see gotcha's and /extras/ukplayer
  Added a style for printing Alumni pages
  Emails sent about low stock should have status unread, not completed.
  Moved draggable.js to extras/yui-webgui/build/layout since it is now a wrapper around YUI dragdrob
  Attributions in the changelog for a patch provided to fix a bug.
  whups, left in console.logs
  Updated draggable.js to wrap the YUI
  fixed #4137: Calendar Search page has extra head tags in body
  Fix a typo typo in the Operation/Workflow POD.
  Forward port Shelf view fix.  Was not displaying child shelves, only self.
  Forward port the PayDriver bug fixes from 7.5 branch.  Labels are always
  fixed #9264: new slideShow.swf uploaded in extras/ukplayer (United Knowledge/Arjan Widlak)
  ...

Conflicts:
	lib/WebGUI/Asset/Wobject/Survey.pm
2009-01-22 04:39:43 +00:00
Graham Knop
4daf774375 preparing for 7.6.9 release 2009-01-22 01:14:40 +00:00
Graham Knop
b255495c02 fixed: Exporting to static files can leak large amounts of memory 2009-01-22 01:14:33 +00:00
Graham Knop
5fe7ffa55c fixed: HTTP Proxy doesn't serve new content to visitors 2009-01-22 01:14:26 +00:00
Graham Knop
315ce0941f use to_json and from_json in more places instead of encode_json and decode_json 2009-01-22 01:14:14 +00:00
Colin Kuskie
b249b98a86 Document the heretofore missing date template variable in
the Syndicated Content item loop.
2009-01-21 23:30:21 +00:00
Colin Kuskie
88973add2f Qualify a chained method call when getting Workflow instances. If the
workflow for an instance is ever deleted, then no existing instances after that
instance will ever be sent to Spectre.
2009-01-21 21:12:26 +00:00
Tabitha Zipperer
af2b83219a Attempt to fix IE6 bug 2009-01-21 18:26:36 +00:00
Arjan Widlak
93297df269 fixed: ukplayer example is now loaded with swfobject.js released under the MIT licence, see gotcha's and /extras/ukplayer 2009-01-21 18:07:01 +00:00
Tabitha Zipperer
5b30a81983 Added a style for printing Alumni pages 2009-01-21 17:59:57 +00:00
Patrick Donelan
8d5e6880c0 More SurveyJSON refactoring (mostly documentation) 2009-01-21 05:34:58 +00:00
Patrick Donelan
102ec0dd25 More SurveyJSON refactoring.. 2009-01-21 05:34:41 +00:00
Patrick Donelan
ef7c0cfaa1 More SurveJSON refactoring (mostly documentation and simple code
changes)
2009-01-21 05:34:23 +00:00
Patrick Donelan
fe32551bca Added totalSections/Questions/Answers helper subs, refactored
getDragDropList to use helper subs, and added extra $address param
documentation.
2009-01-21 03:34:22 +00:00
Patrick Donelan
6d10570fdb Refactored SurveyJSON's new, freeze and addObject for readability 2009-01-20 07:34:55 +00:00
Colin Kuskie
08db6b5036 Emails sent about low stock should have status unread, not completed. 2009-01-19 18:45:05 +00:00
Yung Han Khoe
3a4f90aef6 rfe 9197: Survey timeout handling 2009-01-19 12:51:02 +00:00
Yung Han Khoe
6598ca8854 rfe 9197: Survey timeout handling 2009-01-19 12:49:20 +00:00
Patrick Donelan
c4540a96ee Replaces to_json and from_json with encode_json/decode_json to properly
handle non-ascii user input (e.g. MS Word apostrophe)
2009-01-19 03:33:07 +00:00
Kaleb Murphy
1dc5387e1f Moved draggable.js to extras/yui-webgui/build/layout since it is now a wrapper around YUI dragdrob 2009-01-16 16:20:30 +00:00
Colin Kuskie
329663dff9 Attributions in the changelog for a patch provided to fix a bug. 2009-01-16 16:10:00 +00:00
Yung Han Khoe
2584482fcf applied changes for rfe 9200 to later version of object.js 2009-01-16 14:23:30 +00:00
Kaleb Murphy
4dc51dd879 whups, left in console.logs 2009-01-16 00:36:30 +00:00
Kaleb Murphy
2e47d3b2a1 Updated draggable.js to wrap the YUI 2009-01-16 00:34:50 +00:00
Doug Bell
96662a5f59 fixed #4137: Calendar Search page has extra head tags in body 2009-01-15 20:12:36 +00:00
Colin Kuskie
8cee4f745a Fix a typo typo in the Operation/Workflow POD. 2009-01-15 17:46:39 +00:00
Colin Kuskie
1460618ad4 Forward port Shelf view fix. Was not displaying child shelves, only self. 2009-01-15 16:35:01 +00:00
Yung Han Khoe
f4dab79093 Rfe 9201: Make Survey textAreas yui resizable 2009-01-15 15:51:39 +00:00
Yung Han Khoe
46cca4fae1 rfe 9200: Survey Text/TextArea handling 2009-01-15 14:17:40 +00:00
Patrick Donelan
723d39df79 Removed unused function from editsurvey.js 2009-01-15 09:18:01 +00:00
Patrick Donelan
d5f6d8603e Fixed a few js memory leaks in EditSurvey page (SimpleEditor appears to
have a memory leak of its own which we either need to get fixed or
work-around).
2009-01-15 09:12:06 +00:00
Colin Kuskie
1b6dd7be63 Forward port the PayDriver bug fixes from 7.5 branch. Labels are always
taken consistently from the JSON blob, and not a mixture of the two.
2009-01-15 00:34:34 +00:00