Commit graph

4980 commits

Author SHA1 Message Date
JT Smith
7b414dfd28 - Performance enhancement added to Page Layouts to make them do template
processing twice as fast.
2007-03-05 20:27:17 +00:00
JT Smith
47c65b7d66 changed comma to colon to fix problems with macros that use commas as separators 2007-03-05 19:32:11 +00:00
Colin Kuskie
ecf0450558 update the clipboard docs to talk about the clipboard and uncommitted assets 2007-03-05 17:56:26 +00:00
Colin Kuskie
c3052fcd67 1) Fixed a bad module name that prevented the updated WeatherData from running.
2) Heavy refactor of getAssetsInClipboard to make it use getLineage instead of
custom SQL.

Made Workflow/Activity/TrashClipboard use the same method.

Updated getLineage so that the whereClause key must not only exist, but actually
have something in it.  Otherwise it generates an empty pair of parens, which is
a SQL error.
2007-03-05 17:47:30 +00:00
Colin Kuskie
d948cb4a33 fix typo in expireNotifyOffset method which prevents it from setting this value 2007-03-04 06:22:15 +00:00
Colin Kuskie
b25f80e114 placeholder conversion for the ProfileField module 2007-03-04 05:35:11 +00:00
Colin Kuskie
1412f023f1 Fixed a bug in WebGUI::User::profileField, where the check for whether or not
a profile field existed in the db always passed because it used quickArray in
scalar context.  Since quickArray always returns 1 element, this was always true
and it never returned undef like it was supposed to.

To fix this, I added a new method called quickScalar that returns the first column
from the row as a scalar.  It has a basic test in SQL.t.

Then there's the new test in User.t for coverage that exposed this problem, and
I also removed a whole slew of duplicate tests.
2007-03-04 04:18:59 +00:00
Colin Kuskie
7b97760236 fix a bug in the setting of private object data 2007-03-04 00:14:12 +00:00
Colin Kuskie
e1c69f91d9 fix display of assets in clipboard that cannot be trashed 2007-03-03 22:25:36 +00:00
Colin Kuskie
068f8abd5a fixing bad rendering in time tracker manage projects screen, missing end div tag 2007-03-03 00:42:16 +00:00
Colin Kuskie
be64f0367f add missing SQLForm docs for the super search 2007-03-02 23:02:21 +00:00
Colin Kuskie
ac6116b7a0 Added a dbSlave test to Session.t. It's kind of a hack as it sets up
a slave reference back to the original db from the config.
Bug fixes for the TrashClipboard workflow activity.  The dates were off,
since the interval returns an epoch, and the call to Asset->new didn't
have the session.
2007-03-02 16:51:49 +00:00
Colin Kuskie
d94ca33474 beginning to document the super search template 2007-03-02 06:26:57 +00:00
Colin Kuskie
fcaf782f5b ODBC dsns need long lengths like Oracle 2007-03-01 23:27:24 +00:00
Colin Kuskie
f800a0d8b0 Data::Dumper clean-up 2007-03-01 00:19:15 +00:00
Colin Kuskie
d32e127e8d remove Data::Dumper 2007-03-01 00:16:44 +00:00
Colin Kuskie
211e9bd8a7 fix some bad POD in SQL.pm pertaining to how buildHash* works 2007-02-28 21:26:34 +00:00
Colin Kuskie
3d5763269a Fixed a bug in the Event view where the link to the Calendar Search
was wrong.  Added a new template variable, urlSearch to the Event view
template.  I added a new method to the Calendar to handle this, getUrlSearch.
2007-02-28 20:20:37 +00:00
Colin Kuskie
5fb55ba2de and clean-up the original, dead storageId 2007-02-28 05:42:17 +00:00
Colin Kuskie
85ecb2364a fix thumbnailing of uploaded images via the RTE 2007-02-28 05:35:47 +00:00
Colin Kuskie
218415ad27 fix generic package uploading 2007-02-27 19:05:45 +00:00
JT Smith
ff03aebfd3 Tiny MCE--> Relative Absolute URL for Images IE and Firefox different 2007-02-27 18:41:01 +00:00
Colin Kuskie
1b1804fc16 fixing Calendar/Event add/edit privileges 2007-02-26 23:13:36 +00:00
Colin Kuskie
5aa21faaa3 fixed two outdated doc bugs 2007-02-26 17:31:08 +00:00
JT Smith
2ae31ce34b - fix: WeatherData asset not displaying properly
- rfe: Weather-Data not only for US-Cities
 - rfe: WeatherData Asset - Convert to International format
2007-02-25 18:55:10 +00:00
Colin Kuskie
4469301092 Based on SVN history, put the behavior of the SQL back and fixed the POD and
the tests.
2007-02-25 06:20:54 +00:00
Colin Kuskie
5a379fe91e Add tests for urlExists and fix bugs in the method. It now handles
placeholders correctly and does exactly what the POD says, assetId
requires that the url be with that assetId, rather than not in that
assetId.
2007-02-25 06:18:15 +00:00
JT Smith
0b6c500a16 made the options in urlExists a hashref for future expandability 2007-02-24 17:16:18 +00:00
JT Smith
480cb392eb added a urlExists method which is shared between fixUrl() and the fileImport script 2007-02-24 16:56:45 +00:00
Colin Kuskie
31139678ee Corner cases for User.pm coverage
Converted 2 more queries to use placeholders
2007-02-24 00:37:55 +00:00
Colin Kuskie
2a0eb20bc7 Tests for the canUseAdminMode method of User.pm
Uncovered and fixed a bug where $session->user instead of $self was used in canUseAdminMode
Added an explicit test in Config.pm to make sure that array refs can be passed to ->set.
2007-02-23 23:39:35 +00:00
Colin Kuskie
2803ae520c Ran coverage on User.t and found that we're missing two entire
methods, so I added TODO tests for them.  Overall coverage is low
as well.
Began converting User.pm to use placeholders.
2007-02-23 22:27:23 +00:00
Frank Dillon
6efbad606f fixed getEditableFields so it returns all valid registration fields in addition to editable and required fields 2007-02-23 18:50:30 +00:00
Yung Han Khoe
5c09bbfce8 SQLForm: processing of Macro's in default value didn't work. 2007-02-23 16:32:24 +00:00
Colin Kuskie
6683d27795 clean-up. High code coverage always makes me excited 2007-02-23 05:11:55 +00:00
Colin Kuskie
906775d505 AdSpace has 100% coverage, aside from some conditionals in the set method.
Found and fixed an off by 1 error in displayImpressions that allowed boughtImpressions+1
impressions to be displayed.
2007-02-23 04:59:06 +00:00
Frank Dillon
660868a0b3 fixed API method setCallable to work properly. It wasn't setting the class variable properly 2007-02-22 01:47:36 +00:00
Colin Kuskie
9666dadc82 This set of tests brings overall coverage close to 100% for the Ad module.
Remainnig conditionals in the set subroutine will be tested after 7.4
comes our and ->get can be modified to return the whole set of properties.
Fixed a bug in the Ad module where the priority could not be set to 0.
2007-02-19 04:01:24 +00:00
Colin Kuskie
859886e8f8 fix for importing unsigned ints into the SQL Form from an existing table 2007-02-18 22:50:24 +00:00
Colin Kuskie
4cf11a716f Fix the POD for Storage.pm
Fix for bad calendar day names in the month view.
2007-02-17 16:53:03 +00:00
Colin Kuskie
fd9e2ecd21 A bunch more Ad tests. Need to check the coverage to see if anything has been
missed.
Removed a duplicate alt attribute in the image ad.
2007-02-17 00:36:49 +00:00
Colin Kuskie
ab6d0d2ce6 fix for file uploading problems in File, Image, FilePile, Graphics (font) and FormHelper 2007-02-16 22:31:53 +00:00
Doug Bell
6c8e840fe6 fix: Events are created with no group information 2007-02-16 19:37:39 +00:00
Doug Bell
efb0109465 fix: Creating users with same e-mail address doesn't work 2007-02-16 16:53:50 +00:00
Yung Han Khoe
7a4a0be5d4 fix: Incomplete assets cause manage Trash to fail, added test for valid object creation 2007-02-16 13:52:16 +00:00
Jukka Raimovaara
8bac5fd39a fix: Calendar Next / Previous when startTime was involved 2007-02-16 03:18:24 +00:00
JT Smith
e594cb3d6c - Fixed a problem where you couldn't upgrade directly to 7.3.9 from versions
earlier than 7.3.8.
2007-02-15 23:27:09 +00:00
Doug Bell
126978314f fix: Rich Editor - Add Asset Link doesn't work with images. 2007-02-15 03:42:08 +00:00
JT Smith
717429037d fix: Incomplete asset cause manage Trash to fail 2007-02-15 03:12:35 +00:00
JT Smith
6e451a2b5c fix: SQL Report: Paginate After 2007-02-15 02:54:28 +00:00