Commit graph

96 commits

Author SHA1 Message Date
Colin Kuskie
7ad927092a More POD docs about getAllUsers returning a unique'ed list of userIds. 2009-03-13 23:17:50 +00:00
Graham Knop
24da723629 updating copyright year 2009-02-20 23:47:30 +00:00
Graham Knop
758a321e70 modules, tests, etc shouldn't be set as executable 2008-11-24 04:01:23 +00:00
Frank Dillon
4ff722bd5d Pluggable Account system added to WebGUI with new Profile, Inbox, Friends, User, and Shop interfaces. 2008-11-15 11:39:23 +00:00
Doug Bell
0d9dcbfb12 merge 8376 2008-11-14 23:08:10 +00:00
Frank Dillon
615e0e3746 lots of changes 2008-11-12 23:03:42 +00:00
Colin Kuskie
d6aecc2d90 Admins are in all groups, even group admin groups 2008-10-14 23:15:31 +00:00
Frank Dillon
a253c67018 Fixed an problem in getUsersNotIn which was causing the wrong users to be returned. 2008-09-27 12:18:43 +00:00
Frank Dillon
cde696c767 Added isAdHocMailGroup flag which can be used to build temporary groups of users to send notifications to. Once the users have been added to the mail queue in WebGUI::Mail::send, the group is deleted. 2008-09-22 22:26:59 +00:00
Colin Kuskie
8d561101b5 Add a test to User.t to make sure it isn't leaking groups.
Update POD in User.pm and Group.pm.
2008-08-01 23:06:23 +00:00
Colin Kuskie
f95f3a96f9 more POD for Group.pm 2008-03-07 02:46:11 +00:00
JT Smith
93b5ca16e4 updating copyright year 2008-02-07 23:28:18 +00:00
JT Smith
fa09c41598 replaced return; with return undef; 2008-01-24 21:58:15 +00:00
Colin Kuskie
96178fd70c first round of Perl::Critic cleanups. Do not use return undef, use a bare return instead 2007-12-05 00:30:43 +00:00
Colin Kuskie
8b84ae3e76 Up coverage of addGroups to 100%.
Change tabs to spaces in group diagrams.
Optimize the addGroups membership check so the expensive getGroupsIn
doesn't have to take place.
Add a label to the foreach.
2007-11-26 05:13:32 +00:00
Graham Knop
865c1d315b merging 7.4 changes 2007-11-22 06:09:27 +00:00
Colin Kuskie
17441c13c2 Fixed broken friends method caching. The cache was never populated, so it
would fail every time.
Added a missing DESTROY method to Group.pm.  That way it won't puke when trying
to call an undefined method when the User object is cleaned up.
Added coverage tests for friends method in User.pm
2007-10-31 21:00:54 +00:00
Colin Kuskie
0f3505a46f Group does not use Tie::CPHash (via the dead %group variable) nor WebGUI::Auth 2007-10-30 20:33:48 +00:00
Graham Knop
21b37954c4 finding all groups or users don't fail if one invalid group 2007-09-27 08:49:20 +00:00
Graham Knop
a62a7e0ec1 WebGUI::Group->new didn't check group validity 2007-09-26 11:46:18 +00:00
JT Smith
a7dde82421 updated copyright 2007-07-01 16:09:42 +00:00
JT Smith
1013381c36 fixed an error in the groups/db system where removing a dblink connected to a group would produce a fatal error 2007-04-11 17:24:56 +00:00
JT Smith
e1c86d7f95 - fix: fixed an error in the groups/db system where removing a dblink connected to a group would produce a fatal error 2007-04-05 03:43:37 +00:00
Nik Ogura
cb7f79543a changed pod from 'days' to 'seconds' for expireOffset et al. to reflect what's actually happening 2007-03-27 06:07:50 +00:00
Colin Kuskie
ec3eebda9b remove duplicate code in addUsers, add more tests to Group.t to cover 2007-03-07 00:16:22 +00:00
Colin Kuskie
d948cb4a33 fix typo in expireNotifyOffset method which prevents it from setting this value 2007-03-04 06:22:15 +00:00
JT Smith
67dfefff08 merging 7.1.3 changes 2006-10-31 23:34:55 +00:00
Doug Bell
6d56df1362 Added SQLReport download and Product AddToGroup handler 2006-10-10 18:14:31 +00:00
Colin Kuskie
5dbd9b44c9 Fixed a typo in the POD for Session/Env.pm
Added more docs for find method in Group.pm
Fixed a latent bug that would probably never occur in Macro/GroupAdd.pm
If Group->find is called with the name of a group that doesn't exist,
then Group will return an object with defaults, and the guid of the
group is undef, not ''.  However, since by default autoAdd is off,
the Macro will still do the right thing.
GroupDelete has the same bug, but it shouldn't be patched until there's
a test written for it.
2006-07-24 05:08:17 +00:00
Colin Kuskie
2142186d97 remove old debugging output 2006-07-17 03:29:12 +00:00
Frank Dillon
ec4245a7d8 changes for adding ldap recursive filter 2006-07-12 20:31:02 +00:00
Colin Kuskie
206a294988 Fix bug where groups were being created with no defaults.
Update Group test to check for default values in groups created
with gid "new" and "".
2006-06-30 05:14:28 +00:00
Frank Dillon
6e734b900f LDAP isInGroup changes 2006-06-23 01:49:34 +00:00
JT Smith
41e655b452 - fix: New page layout instead of not found
- fix: Rollback
 - fix: debug output
 - fix: Can't delete images at product asset
fixed a problem with file/image form uploads
rearranged group methods for alphabetical order
removed matt's hack for group caching and replaced it with the right way
2006-05-30 22:35:12 +00:00
Colin Kuskie
7100d1df41 Add a new method called getAllGroupsFor, which recursively returns ALL groups
that a group belongs to.  This is required to properly uncache group settings
for groups with more than 2 levels of hierarchy.

Add 7 tests to verify the working of the new method.

Fix a typo in the POD for Operation/Group.pm
2006-05-26 16:43:47 +00:00
Wouter van Oijen
684f08649d Fixing stuff 2006-05-21 14:49:40 +00:00
Colin Kuskie
aea9ce76f7 Bust group caches and caches of groups containting this group
whenever the group is edited, or when users or groups are added
or deleted.
Add a test to check adding users.
2006-05-17 23:16:11 +00:00
Colin Kuskie
1c6fec6695 Flush cache for User and Group tests to pass.
Add group cache clear to Group.pm
templateId clash due fixed
2006-04-15 02:32:38 +00:00
Colin Kuskie
6726f56af3 remove debug code 2006-04-14 01:50:29 +00:00
Colin Kuskie
2f5dab37d2 finalized Group code with migration and upgrade log 2006-04-14 01:17:39 +00:00
Colin Kuskie
4f60281392 change dbCacheTimeout to groupCacheTimeout 2006-04-13 22:26:11 +00:00
Colin Kuskie
be7a44d4f2 make Group->getUsers fully recursive to remove duplicate code 2006-04-13 21:22:04 +00:00
Colin Kuskie
ad694fb030 Fix User.t so that it assigns IPs in a way that works with the new isInGroup code.
User.pm: Collapse all methods into getUsers(1) inside isInGroup
Group.pm: Disable the cache whenever a scratchFilter or ipFilter is assigned.
Begin updating Group documentation for changes to dbQuery
2006-04-12 23:33:11 +00:00
Colin Kuskie
8b8b4af41b Checkpoint before final conversion.
Added getIpUsers method to Group.pm
Group->getUsers and User->isInGroup both use getIpUsers
Tests added to Group.t to verify that getIpUsers works.
2006-04-11 21:17:30 +00:00
Colin Kuskie
e5e9cd9b51 add tests for scratch users and migrate getUsers,isInGroup to use it 2006-04-07 20:42:36 +00:00
Matthew Wilson
2c60283ba3 first major round of EMS changes. much more to come late tonight. 2006-04-07 00:02:45 +00:00
Colin Kuskie
f9b8582426 Scratch filter tests in prep for WebGUI::Group->getScratchUsers
Small tweaks for User.pm scratch and Group.pm POD
Update scratchFilter docs to show how to place multiple name and value pairs
2006-04-06 22:02:54 +00:00
Colin Kuskie
3e179fa4ad Group.t: group karma tests, better clean-up at end
User.t: better clean-up at end
Scratch.t: no newlines in test output
Session/Scratch.pm: convert to use placeholders
Ad.pm: Add missing line of POD.
Group.pm: add method to get all users in a group by karma.
User.pm: isInGroup to use getKarmaUsers.
2006-04-06 16:52:34 +00:00
Colin Kuskie
510c1f5ca5 Modify User.pm and Group.pm to consider external means of defining users,
such as a dbQuery.  This would happened coincidently before, but required
doing a User->isInGroup and only added members who were searched for rather
than all members.
Modify Group.t to test this.
Update POD in SQL.pm.
2006-04-05 18:35:26 +00:00
Colin Kuskie
c802e4ddad Add tests for database defined groups to Group.t
Clear cache on set of databaseLinkId or dbQuery in WebGUI::Group.pm.
Fix typos, missing module use lines and extra variables in WebGUI::User.pm.
2006-04-03 18:07:09 +00:00