Commit graph

7813 commits

Author SHA1 Message Date
Colin Kuskie
afb67294b8 more coverage tests for getDescendantCount, checking state and status 2007-11-21 18:04:41 +00:00
Graham Knop
599f62163d fix: DataForm doesn't send mail if mail fields in tab 2007-11-21 10:40:09 +00:00
Colin Kuskie
185a582ef9 State and status fix for AssetLineage->getDescendantCount, and tests to
double check it.
2007-11-21 03:43:20 +00:00
Colin Kuskie
80333b1141 add more tests to cover AssetLineage->getChildCount. Optimize the new SQL query in getChildCount 2007-11-20 21:15:06 +00:00
Colin Kuskie
0799d70428 Fix for AssetLineage's getChildCount. It did not consider the
asset's status, only the state.  Change the SQL query to always
look at status, and consider state based on the options passed
to the method.
Add two quick tests to test that.  More to follow.
2007-11-20 04:46:45 +00:00
Colin Kuskie
ced6e64aff forward porting bug fix in upgrade skeleton 2007-11-19 21:22:55 +00:00
Colin Kuskie
d0624b7cf9 no sense looking in the Help and i18n for POD 2007-11-19 04:52:42 +00:00
Colin Kuskie
d9fc434a78 POD documentation for the argument to getChildcount 2007-11-19 04:46:37 +00:00
Graham Knop
6ea2472695 fix: Calendar feed list doesn't display in IE 2007-11-16 07:11:04 +00:00
Colin Kuskie
d566d0db8c add a test for makeArrayTabSafe and add comments to WebGUI::Utility 2007-11-16 05:16:44 +00:00
Colin Kuskie
b07956fa06 forward port of branch work with Utility.pm and isInSubnet 2007-11-16 04:36:08 +00:00
Graham Knop
16aec59d39 merging 7.4 changes 2007-11-15 12:02:02 +00:00
Graham Knop
1be6ea85d9 fix: Site starter style displays incorrectly in IE 2007-11-15 09:16:56 +00:00
Graham Knop
d42f568456 fix: Copy operations create version tags even with auto-commit turned on 2007-11-15 08:23:54 +00:00
Graham Knop
b725e93f35 fix shortcuts not copying overrides with asset or removing them on purge 2007-11-15 07:30:15 +00:00
Graham Knop
20e496d002 fix broken SSL redirection 2007-11-13 18:25:26 +00:00
Colin Kuskie
fd8cff2b8f coverage tests for getFileIconUrl for WebGUI::Storage.pm 2007-11-12 20:58:21 +00:00
Colin Kuskie
484bc40569 leave notes as to future tests that need to be written for getBackToSiteURL 2007-11-12 05:20:52 +00:00
Colin Kuskie
dac78e161c Coverage tests for getBackToSiteURL brings Session/Url coverage
up to 100%.
2007-11-12 05:18:05 +00:00
Colin Kuskie
1cf78f5321 Finish up the file upload handling by PseudoRequest. If you
call $pseudoRequest->uploadFiles with a list of filenames, it will populate
the upload method with upload objects, so that Storage->getFileFromFormPost
will have an object with all the right methods.
t/Storage.t tests this incidently.  It occurs to me that we need tests
for our PseudoRequest module, and it needs POD, and it should probably
be rewritten using Class::InsideOut for good form.
2007-11-10 00:47:17 +00:00
Colin Kuskie
4de53b2de9 enable testing of $session->request->uploads through WebGUI::PseudoRequest. Now we need a good utility method for sending a list of files to a sub and having it return a list of filehandles to those files 2007-11-10 00:02:44 +00:00
Colin Kuskie
175304e915 always, always cleanup after myself in tests. sigh. 2007-11-09 22:43:19 +00:00
Colin Kuskie
57ff4405a6 add a prototype fix for not having InnoDB tables causing test errors 2007-11-09 22:35:58 +00:00
Colin Kuskie
f3b7b1bf8e Start adding coverage to the getBackToSiteURL method.
Remove the old commented out MockObject request code.  It's PseudoRequest or bust.
WGBP indent some of the Session/Url methods.
2007-11-09 21:23:00 +00:00
Colin Kuskie
a894e6a879 internationalized the high group count message 2007-11-09 16:05:11 +00:00
Diona Kidd
fd772980e4 Adding message if group count exceeds 250 2007-11-09 05:14:35 +00:00
Graham Knop
81bb746f9e fix CS posts not allowing new attachments after deleting old ones 2007-11-08 22:50:59 +00:00
Chris Nehren
7f37c20028 Gr. One more attempt at getting the default to work properly. 2007-11-08 19:33:57 +00:00
Colin Kuskie
542fc63f4b forward change notice for earlier commit about removing old templates 2007-11-08 18:02:49 +00:00
Graham Knop
37c6164ac0 merging 7.4 changes 2007-11-08 14:23:04 +00:00
Graham Knop
8df2c9f6b9 fix missing field_loop in SQL Form template 2007-11-08 06:33:40 +00:00
Colin Kuskie
0c2f9f5ec7 fix bad import of help template variables. Loops are now handled correctly. Added a test with supporting collateral to make sure this does not happen again 2007-11-08 05:34:48 +00:00
Chris Nehren
9db0430032 Fix the groupToEditPost field defaulting to the groupIdEdit field. Make sure
that the added collab system in the test has a parent asset as well, to ensure
that the inheritance works properly.
2007-11-07 22:29:21 +00:00
Graham Knop
8b23a6e7cf fix backslash doubling on ical import 2007-11-07 18:53:40 +00:00
Graham Knop
70c557aa10 copy CS sorting fix from branch 2007-11-07 17:36:30 +00:00
Chris Nehren
227c2d90ec duh. Need to *call* the sub I added to the upgrade script. 2007-11-06 23:36:52 +00:00
Chris Nehren
e20e6061f2 Don't delete the groups used in the Post test, they're needed. May want to make
mock groups in the future. Also clean up some commented out things from
Collaboration.t.
2007-11-06 23:06:09 +00:00
Chris Nehren
0d689afa4c Add the groupToEditPost field to the Collaboration system. This allows users
to specify a group of users that will always be able to do edits on posts,
regardless of whether they own those posts and independent of the editTimeout
field.
2007-11-06 22:58:22 +00:00
Graham Knop
e5b7741f75 fix EMS in IE with reset style 2007-11-05 22:32:37 +00:00
Chris Nehren
a7c0ff0dec Fix backwards compatability with existing code. Update the tests accordingly. 2007-11-05 20:10:42 +00:00
Chris Nehren
8688604ea4 Lots of fixes.
1. Restore original getJsonStatus functionality of returning data for just one
site, if sitename is passed.
2. Add a few comments to Spectre::Workflow::getJsonStatus to help explain what's
going on, and also add some whitespace to separate the code into logical pieces.
3. Add tests for this functionality, doubling the number of tests for
getJsonStauts to 20.
4. Per Colin's suggestion, use isa_ok rather than cmp_ok(ref ... , eq 'TYPE',
'...').
5. Fix broken indentation in a for loop.
6. Change for loops to foreach to be consistent with the rest of WebGUI.
2007-11-05 16:56:09 +00:00
Colin Kuskie
b6bab1723a internationalize the warning in the Operation/User.pm for not displaying users when there are more than 250 of them 2007-11-05 16:15:04 +00:00
Diona Kidd
c6948b62d0 Added operation user rfe doc to changelog 2007-11-03 20:46:01 +00:00
Diona Kidd
7c6ba502c6 If there are over 250 users, none are currently displayed. Added message to user in this case. 2007-11-03 20:38:52 +00:00
Colin Kuskie
14e907d589 begin converting Session/Url.t to PseudoRequest 2007-11-02 23:38:45 +00:00
Chris Nehren
dd53243b08 Fixups for the tests. I moved the nested key checking into a TODO block. I'm
not sure how to handle them, as they may / may not exist in the %output hash.
Sometimes they'll pass, sometimes they won't, depending upon the time you run
it and the status of Spectre overall.
2007-11-02 19:12:16 +00:00
Chris Nehren
3e2bad5cb4 Work towards having Spectre::Workflow::getJsonStatus return information about
all sites, needed for munging workflow monitoring into wremonitor.pl.
2007-11-02 18:08:20 +00:00
Colin Kuskie
c7334e2b22 forward port changelog from user session scratch bugfix 2007-11-02 18:03:07 +00:00
Colin Kuskie
45eb45fa3e fix a session bug where, when using noFuss, user session scratch was not cleaned up 2007-11-02 17:50:19 +00:00
Colin Kuskie
980ff3e972 add plan for testing. Fill in with code later 2007-11-02 04:45:10 +00:00