Colin Kuskie
fc6cd26348
Subroutine prototypes are verboten! PBP/194
2007-12-05 17:23:48 +00:00
Colin Kuskie
98863256ea
no code allowed before use strict. PBP/429. This check found a bug in Asset::Wobject::HttpProxy::Parse.pm
2007-12-05 16:55:40 +00:00
Colin Kuskie
08fbd46d28
all loop iterators have to be declared lexical. PBP/108
2007-12-05 16:46:38 +00:00
Colin Kuskie
52132e61f4
Using a lexical loop variable inside recurseFileSystem.
2007-12-05 04:26:37 +00:00
Colin Kuskie
d23db44732
adding use strict to all these, too
2007-12-05 04:21:56 +00:00
Colin Kuskie
b2901f4271
correct punctuation
2007-12-05 04:20:29 +00:00
Colin Kuskie
93ea47a4c0
Perl::Critic has a policy check for putting any code
...
before you apply strictures (use strict, use warnings, etc.)
Add calls to use strict to each Help module. This is probably
an overstrict interpretation of the rule.
2007-12-05 04:16:54 +00:00
Colin Kuskie
4fabea706d
Perl::Critic: no code before strictures are applied
2007-12-05 00:34:46 +00:00
Colin Kuskie
96178fd70c
first round of Perl::Critic cleanups. Do not use return undef, use a bare return instead
2007-12-05 00:30:43 +00:00
Colin Kuskie
75041656ee
adding more debug statements to Storage/Image.t
2007-12-04 21:31:30 +00:00
Colin Kuskie
72906e27fb
fixing handling of http:// calls in the Extras URL
2007-12-04 21:25:32 +00:00
Colin Kuskie
21658d2ffd
Remove debugging code.
...
Add in code to actually check the label in the requested namespace.
Now the problem becomes how to get all the right paths to
the right modules.
2007-12-03 05:47:35 +00:00
Colin Kuskie
ba1f686920
ran perlcritic -stern on Session.pm. Fixed a few things that it recommends. Session.pm was clean for -gentle
2007-12-03 02:00:28 +00:00
Colin Kuskie
ad661f2a70
Rewrite the adjustMaxFilesize test to be data driven.
...
Check the original sizes, and resized sizes exactly.
Hoping that this fixes last night's Image.t test failure.
2007-12-02 04:01:07 +00:00
Colin Kuskie
225590fa33
Add tests for the tempspace node.
2007-12-01 05:24:30 +00:00
Colin Kuskie
1c02551bd6
Perl::Critic module for checking illegal i18n labels
2007-12-01 04:48:55 +00:00
Colin Kuskie
d40ea62894
avoid running this test unless we have WRE installed
2007-12-01 00:12:10 +00:00
Doug Bell
8975ef5ef2
added url.raw for Post assets to get a URL without the #id stuff at the end
2007-11-30 19:34:38 +00:00
Colin Kuskie
241bb7ebac
Storage/Image.t tests failing due to being run as root user. Add SKIP to enable test for non-users only
2007-11-30 16:26:22 +00:00
Graham Knop
377386f239
Merged revisions 5062 via svnmerge from
...
https://svn.webgui.org/plainblack/branch/WebGUI_7.4
........
r5062 | graham | 2007-11-29 09:45:32 -0600 (Thu, 29 Nov 2007) | 1 line
fix: double width characters encoded incorrectly in Collaboration RSS feed
........
2007-11-29 15:50:56 +00:00
Graham Knop
c091192f47
merging 7.4 changes
2007-11-29 05:56:46 +00:00
Colin Kuskie
871042ee75
grrrr. Mistyped an i18n table key
2007-11-28 16:38:22 +00:00
Colin Kuskie
350d698441
forward porting another batch of Event getTemplateVar tests
2007-11-28 05:45:11 +00:00
Colin Kuskie
a1ea1ec2de
add menuTitle to the Folder templates
2007-11-28 05:00:11 +00:00
Colin Kuskie
0a1974ba4c
forward porting Event dateSpan display fix and Event.t test
2007-11-28 04:47:30 +00:00
Colin Kuskie
92c3652406
Adding previously forgotten testing collateral
2007-11-28 04:35:01 +00:00
JT Smith
338efd3df3
merging 7.4.16 bugfix
2007-11-27 16:17:42 +00:00
JT Smith
1934132002
merging 7.4.16 bugfix
2007-11-27 15:59:22 +00:00
Colin Kuskie
6b9272984c
Previous conditional will always cover this case. If true, then
...
$self is returned. If false, then previous conditional is ignored,
and this line is also ignored.
Removing dead code.
2007-11-26 05:26:18 +00:00
Colin Kuskie
8b84ae3e76
Up coverage of addGroups to 100%.
...
Change tabs to spaces in group diagrams.
Optimize the addGroups membership check so the expensive getGroupsIn
doesn't have to take place.
Add a label to the foreach.
2007-11-26 05:13:32 +00:00
Colin Kuskie
1b3d7f0c2b
Refactor out the copied code to resize images based on the max file
...
size from the Admin Settings and create a new method in
Storage::Image.
Build a test to verify that it works correctly.
2007-11-24 05:30:15 +00:00
Colin Kuskie
41a8524daf
remove mocking, since we new use PseudoRequest
2007-11-22 20:52:26 +00:00
Colin Kuskie
256b52a0d7
Final state and status fixes.
...
In these three files, any check for status=archived was removed, since
in each case it is possible that the Asset may want to be viewable
when it is archived, like Files, Posts, etc.
Updated Session/Url.t to remove tests for status=archived.
2007-11-22 18:46:17 +00:00
Graham Knop
865c1d315b
merging 7.4 changes
2007-11-22 06:09:27 +00:00
Colin Kuskie
afb67294b8
more coverage tests for getDescendantCount, checking state and status
2007-11-21 18:04:41 +00:00
Graham Knop
599f62163d
fix: DataForm doesn't send mail if mail fields in tab
2007-11-21 10:40:09 +00:00
Colin Kuskie
185a582ef9
State and status fix for AssetLineage->getDescendantCount, and tests to
...
double check it.
2007-11-21 03:43:20 +00:00
Colin Kuskie
80333b1141
add more tests to cover AssetLineage->getChildCount. Optimize the new SQL query in getChildCount
2007-11-20 21:15:06 +00:00
Colin Kuskie
0799d70428
Fix for AssetLineage's getChildCount. It did not consider the
...
asset's status, only the state. Change the SQL query to always
look at status, and consider state based on the options passed
to the method.
Add two quick tests to test that. More to follow.
2007-11-20 04:46:45 +00:00
Colin Kuskie
ced6e64aff
forward porting bug fix in upgrade skeleton
2007-11-19 21:22:55 +00:00
Colin Kuskie
d0624b7cf9
no sense looking in the Help and i18n for POD
2007-11-19 04:52:42 +00:00
Colin Kuskie
d9fc434a78
POD documentation for the argument to getChildcount
2007-11-19 04:46:37 +00:00
Graham Knop
6ea2472695
fix: Calendar feed list doesn't display in IE
2007-11-16 07:11:04 +00:00
Colin Kuskie
d566d0db8c
add a test for makeArrayTabSafe and add comments to WebGUI::Utility
2007-11-16 05:16:44 +00:00
Colin Kuskie
b07956fa06
forward port of branch work with Utility.pm and isInSubnet
2007-11-16 04:36:08 +00:00
Graham Knop
16aec59d39
merging 7.4 changes
2007-11-15 12:02:02 +00:00
Graham Knop
1be6ea85d9
fix: Site starter style displays incorrectly in IE
2007-11-15 09:16:56 +00:00
Graham Knop
d42f568456
fix: Copy operations create version tags even with auto-commit turned on
2007-11-15 08:23:54 +00:00
Graham Knop
b725e93f35
fix shortcuts not copying overrides with asset or removing them on purge
2007-11-15 07:30:15 +00:00
Graham Knop
20e496d002
fix broken SSL redirection
2007-11-13 18:25:26 +00:00
