oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7095 commits 2 branches 2 tags 120 MiB
Commit graph

119 commits

Author SHA1 Message Date
Colin Kuskie
7d5e6ae526 remove debug code from User.pm and fix slave handling in Session 2007-03-08 22:54:20 +00:00
Colin Kuskie
1412f023f1 Fixed a bug in WebGUI::User::profileField, where the check for whether or not 
a profile field existed in the db always passed because it used quickArray in
scalar context.  Since quickArray always returns 1 element, this was always true
and it never returned undef like it was supposed to.

To fix this, I added a new method called quickScalar that returns the first column
from the row as a scalar.  It has a basic test in SQL.t.

Then there's the new test in User.t for coverage that exposed this problem, and
I also removed a whole slew of duplicate tests.
 2007-03-04 04:18:59 +00:00
Colin Kuskie
31139678ee Corner cases for User.pm coverage 
Converted 2 more queries to use placeholders
 2007-02-24 00:37:55 +00:00
Colin Kuskie
2a0eb20bc7 Tests for the canUseAdminMode method of User.pm 
Uncovered and fixed a bug where $session->user instead of $self was used in canUseAdminMode
Added an explicit test in Config.pm to make sure that array refs can be passed to ->set.
 2007-02-23 23:39:35 +00:00
Colin Kuskie
2803ae520c Ran coverage on User.t and found that we're missing two entire 
methods, so I added TODO tests for them.  Overall coverage is low
as well.
Began converting User.pm to use placeholders.
 2007-02-23 22:27:23 +00:00
Colin Kuskie
5f36fbb30f fix typo for session->warn 2007-01-05 23:57:52 +00:00
Drake
e795f06fd8 Rollback r3340 since it broke specialState:init. 2006-12-06 17:49:22 +00:00
Drake
aa3b8b6d24 Profile field defaulting fixes. 2006-12-06 16:45:52 +00:00
Drake
cc88ddbd09 Fix bug with WebGUI::User not using getIp for canUseAdminMode. 2006-12-05 15:49:09 +00:00
JT Smith
bc4125204a - fix: Bug in "Article with Files" 
- fix: SQLReport pagination retains op= parameter
 - fix: Invalid MIME type set for images
 2006-11-15 22:30:50 +00:00
Martin Kamerbeek
ce447fdbd9 Fixed a bug where the adminbar would not show up if adminModeSubnets is missing in the config file. 2006-11-10 14:39:32 +00:00
JT Smith
899e9754b6 - karma rfe: Limiting access to admin mode to set of ip's 2006-11-08 17:43:44 +00:00
JT Smith
aeba6ec83c merging 7.1.4 changes 2006-11-03 04:36:13 +00:00
JT Smith
58b3128a3a Fixed the search function that broke in 7.0.7. 
also fixed a user profile problemm
 2006-09-26 20:34:59 +00:00
JT Smith
90cb569bb5 - fix: deleting workflows did not delete related instances and crons 
- Added a "run" link to the scheduler and the running workflows listings to
   aid in debugging workflow errors.
 - fix: profile fields not validated by WebGUI::User
 2006-09-15 06:08:30 +00:00
Colin Kuskie
ba87ea3380 Fix a bug where a User's object cached lastModified time and the time in the 
db can be off by 1 second.  This is pretty rare but can be found during testing.
 2006-07-17 00:37:32 +00:00
Frank Dillon
6e734b900f LDAP isInGroup changes 2006-06-23 01:49:34 +00:00
Wouter van Oijen
684f08649d Fixing stuff 2006-05-21 14:49:40 +00:00
Matthew Wilson
0732eef9ce $u->status('Deactivated') does not expire existing sessions 2006-05-19 02:41:03 +00:00
JT Smith
6f397be60b fix [ 1490336 ] all versions - deleting a user fails to existing sessions 2006-05-18 03:16:23 +00:00
JT Smith
d089539ddd add email posting without subscription 2006-05-17 20:04:33 +00:00
Colin Kuskie
2f5dab37d2 finalized Group code with migration and upgrade log 2006-04-14 01:17:39 +00:00
Colin Kuskie
4f60281392 change dbCacheTimeout to groupCacheTimeout 2006-04-13 22:26:11 +00:00
Colin Kuskie
ad694fb030 Fix User.t so that it assigns IPs in a way that works with the new isInGroup code. 
User.pm: Collapse all methods into getUsers(1) inside isInGroup
Group.pm: Disable the cache whenever a scratchFilter or ipFilter is assigned.
Begin updating Group documentation for changes to dbQuery
 2006-04-12 23:33:11 +00:00
Colin Kuskie
91c4083d8a Roll all checks into 1 massive recursive getUsers call on the 
requested group.  LDAP work is TBD, but would look exactly
like any of the other get*Users methods in Group.pm.  Then
the LDAP code would be removed from Users->isInGroup.
 2006-04-11 22:38:41 +00:00
Colin Kuskie
8b8b4af41b Checkpoint before final conversion. 
Added getIpUsers method to Group.pm
Group->getUsers and User->isInGroup both use getIpUsers
Tests added to Group.t to verify that getIpUsers works.
 2006-04-11 21:17:30 +00:00
JT Smith
ee62336a77 we officially support attachments on our cs mail posts 2006-04-10 13:36:12 +00:00
JT Smith
a15795519d and we officially have email to discussion working 2006-04-10 13:21:46 +00:00
JT Smith
6c6d36c981 readding mail footer to email messages 
removed some old settings that don't apply any longer
 2006-04-09 16:12:32 +00:00
Colin Kuskie
e5e9cd9b51 add tests for scratch users and migrate getUsers,isInGroup to use it 2006-04-07 20:42:36 +00:00
Colin Kuskie
f9b8582426 Scratch filter tests in prep for WebGUI::Group->getScratchUsers 
Small tweaks for User.pm scratch and Group.pm POD
Update scratchFilter docs to show how to place multiple name and value pairs
 2006-04-06 22:02:54 +00:00
Colin Kuskie
3e179fa4ad Group.t: group karma tests, better clean-up at end 
User.t: better clean-up at end
Scratch.t: no newlines in test output
Session/Scratch.pm: convert to use placeholders
Ad.pm: Add missing line of POD.
Group.pm: add method to get all users in a group by karma.
User.pm: isInGroup to use getKarmaUsers.
 2006-04-06 16:52:34 +00:00
Colin Kuskie
510c1f5ca5 Modify User.pm and Group.pm to consider external means of defining users, 
such as a dbQuery.  This would happened coincidently before, but required
doing a User->isInGroup and only added members who were searched for rather
than all members.
Modify Group.t to test this.
Update POD in SQL.pm.
 2006-04-05 18:35:26 +00:00
Colin Kuskie
c802e4ddad Add tests for database defined groups to Group.t 
Clear cache on set of databaseLinkId or dbQuery in WebGUI::Group.pm.
Fix typos, missing module use lines and extra variables in WebGUI::User.pm.
 2006-04-03 18:07:09 +00:00
JT Smith
955293ecc7 fixing error reported by smoke tests 2006-03-24 14:31:25 +00:00
Colin Kuskie
e8a364f526 New user and group tests for caching and membership and default group settings. 
Cache busting in User.pm.
Allow Visitor to be formally added to groups 2 and 7.
More placeholder work.
Update Help for Secondary Admins.
 2006-03-18 05:36:04 +00:00
Colin Kuskie
528d0deaa5 bad stow methods fixed 2006-03-17 19:06:12 +00:00
Colin Kuskie
248f77f3a9 Added more test in preparation for changing Group SQL query work. 
Update documentation in User.pm and Group.pm.
Refactor Group.pm to use placholders.
Fix typo in getGroupsIn where wrong key in hash was accessed.
 2006-03-13 04:43:05 +00:00
Colin Kuskie
a991401a6a User.pm: fixed a type Group->group should be group->get 
Template documentation for EMS and another i18n label.
 2006-02-20 20:37:27 +00:00
JT Smith
6ee05b85af first round of changes to create the ui for building workflows, more to come 
a few small bug fixes
 2006-02-15 21:23:22 +00:00
Colin Kuskie
cd6759f311 Modify WebGUI IP fields to use CIDR format instead of a regular expression. 
Multiple IPs are separated by commas, whitespace is ignored.
In groups, that affects the ipFilter field,  User::isInGroup.
In settings, that affects Settings::debugIp and Session::ErrorHandler::canShowDebug.

Fixed a bug in WebGUI::Utility::isInSubnet where Net::Subnets->check needs a scalar.

Modified t/User.t to use addresses in CIDR format.
 2006-02-14 22:35:21 +00:00
Colin Kuskie
0c69c93f41 forward port of becoming illegal userId bugfix 2006-02-14 06:50:14 +00:00
Colin Kuskie
62a841ced9 Move 6.8's Group ipFilter test into User.t since isInGroup was moved into WebGUI::User.pm 
forward port of ipFilter bugfix, typo
 2006-02-10 20:31:26 +00:00
JT Smith
7731a32559 fixed some pod errors 
removed futile inbox attempt
 2006-01-31 23:10:10 +00:00
JT Smith
518a65df78 the beginnings of the message log replacement 2006-01-31 21:45:17 +00:00
Matthew Wilson
4a3121960f removal of dumpSession. 2006-01-26 05:39:16 +00:00
JT Smith
2ea770bd05 merging 6.8.6 bugfix 2006-01-19 23:07:54 +00:00
Matthew Wilson
6eb252d907 removing debug. 2006-01-17 16:05:47 +00:00
Matthew Wilson
4b4ddd768c finally fixed the dang User.pm bug. 2006-01-16 23:07:56 +00:00
Matthew Wilson
09483e18c5 a ton of $session fixes (thanks to Colin), and a new $session checker, that supposedly, shouldn't be needed now. It can be backed out, however, easily. 2006-01-16 22:45:21 +00:00