Commit graph

158 commits

Author SHA1 Message Date
Colin Kuskie
eab3417396 Add POD to bring POD coverage up to 100% 2009-04-01 03:11:06 +00:00
Colin Kuskie
fa15f92b68 Fix POD for User.pm
Add POD for HTML.pm
2009-03-31 03:20:57 +00:00
Colin Kuskie
eff2d5295b Don't make the 2nd Friend object unless it is needed. 2009-03-29 04:13:33 +00:00
Doug Bell
a58300f8d5 fixed #9852: Users can accept private messages from Visitor, but Visitor cannot send messages 2009-03-04 03:28:48 +00:00
Graham Knop
24da723629 updating copyright year 2009-02-20 23:47:30 +00:00
Doug Bell
30158b7f8d fixed: Collab groupToEditPost shouldn't be empty
fixed: WebGUI::User->isInGroup has bad defaulting behavior
2009-02-17 23:21:30 +00:00
Colin Kuskie
41da738e0e Fix handling of multi-form and multiple select form elements by emitting
a hidden form variable to make sure the form element was in the generated form.
Changes in User and ProfileField to support this.
2009-01-26 21:03:23 +00:00
Frank Dillon
18dd11345c Fixed a bug that wouldn't allow admins to save a user profile if email address is required 2008-12-23 03:35:58 +00:00
Colin Kuskie
6455b1b85c fix a syntax warning in User.pm 2008-11-21 16:48:20 +00:00
Martin Kamerbeek
06b65b7e4b Reapplying 7.6 specific changes. 2008-11-21 14:01:12 +00:00
Martin Kamerbeek
fd73f98e4e Fixed a bug where WG::User would not check whether the friends group exists or not. As a result it was not possible
to eg. delete such users.
2008-11-21 13:30:16 +00:00
Frank Dillon
6eff997f81 rfe: User Profile Privacy Settings (#507) - users now have granular control of whether or not their profile fields are viewable - admin settings still apply 2008-11-19 05:18:58 +00:00
Frank Dillon
70bd363814 fixed a bug which would allow visitors to be added to your friends list. 2008-11-18 03:35:27 +00:00
Frank Dillon
4ff722bd5d Pluggable Account system added to WebGUI with new Profile, Inbox, Friends, User, and Shop interfaces. 2008-11-15 11:39:23 +00:00
Frank Dillon
11d18075fa Account release candidate - final changes before merge 2008-11-15 02:39:23 +00:00
Doug Bell
0d9dcbfb12 merge 8376 2008-11-14 23:08:10 +00:00
Doug Bell
2f8869292f merging 8374 2008-11-14 22:19:15 +00:00
Frank Dillon
615e0e3746 lots of changes 2008-11-12 23:03:42 +00:00
JT Smith
ef120fb06b Added isVisitor, isAdmin, and isRegistered methods to User object instead
of hard coding checks everywhere with group ids. And updated the code base 
   to match.
2008-09-16 22:32:36 +00:00
Graham Knop
82d7ae944e prevent excessive checks for profile field existence 2008-08-15 15:49:33 +00:00
Colin Kuskie
ef56d94eaf Update tests for new profile field handling.
Change how the profileField method works in User.pm
Reindent some User.pm method according to WGBP.
2008-08-07 20:30:56 +00:00
Graham Knop
ad3c236f47 oops 2008-08-07 19:11:13 +00:00
Graham Knop
f4f6d19e96 fixed: user profile defaults can contain arbitrary perl code 2008-08-07 18:44:17 +00:00
Colin Kuskie
fd62170df6 Change getGroups to always return safe copies of data.
Add tests to check for safe copies.
Add a test for getGroupIdsRecursive.
2008-08-02 22:48:32 +00:00
Colin Kuskie
8d561101b5 Add a test to User.t to make sure it isn't leaking groups.
Update POD in User.pm and Group.pm.
2008-08-01 23:06:23 +00:00
Doug Bell
afea092a97 exposed a form variable for Gallery Album Others Can Add asset property
checkin missing WebGUI::User method
2008-07-29 17:11:13 +00:00
JT Smith
93b5ca16e4 updating copyright year 2008-02-07 23:28:18 +00:00
JT Smith
fa09c41598 replaced return; with return undef; 2008-01-24 21:58:15 +00:00
Colin Kuskie
1989242c8e remove double sigil and dereference instead 2007-12-24 04:23:32 +00:00
Colin Kuskie
96178fd70c first round of Perl::Critic cleanups. Do not use return undef, use a bare return instead 2007-12-05 00:30:43 +00:00
Colin Kuskie
17441c13c2 Fixed broken friends method caching. The cache was never populated, so it
would fail every time.
Added a missing DESTROY method to Group.pm.  That way it won't puke when trying
to call an undefined method when the User object is cleaned up.
Added coverage tests for friends method in User.pm
2007-10-31 21:00:54 +00:00
Colin Kuskie
b8a4033036 Add more coverage tests for methods added to User.pm
for Friends.
Fix a bug in the isOnline method, which was looking sessions
exactly 600 seconds old.
2007-10-26 02:54:47 +00:00
Colin Kuskie
383a0ea632 remove extra whitespace that was interfering with POD parsing. 2007-10-24 22:15:51 +00:00
Doug Bell
587443b801 add: Friends network 2007-10-22 19:42:11 +00:00
Graham Knop
a62a7e0ec1 WebGUI::Group->new didn't check group validity 2007-09-26 11:46:18 +00:00
Colin Kuskie
0c9d1f4332 RFE for a new user access method, lookup by username and return
an object.   Includes tests for validating the code.
2007-07-06 17:53:18 +00:00
JT Smith
a7dde82421 updated copyright 2007-07-01 16:09:42 +00:00
Colin Kuskie
4f570b67c9 Forward port of inactive user group email fix, and user status documentation. 2007-06-28 20:03:22 +00:00
Doug Bell
07a40788bb add: User profile data table is now a flat table. 2007-05-28 21:35:34 +00:00
Colin Kuskie
7d5e6ae526 remove debug code from User.pm and fix slave handling in Session 2007-03-08 22:54:20 +00:00
Colin Kuskie
1412f023f1 Fixed a bug in WebGUI::User::profileField, where the check for whether or not
a profile field existed in the db always passed because it used quickArray in
scalar context.  Since quickArray always returns 1 element, this was always true
and it never returned undef like it was supposed to.

To fix this, I added a new method called quickScalar that returns the first column
from the row as a scalar.  It has a basic test in SQL.t.

Then there's the new test in User.t for coverage that exposed this problem, and
I also removed a whole slew of duplicate tests.
2007-03-04 04:18:59 +00:00
Colin Kuskie
31139678ee Corner cases for User.pm coverage
Converted 2 more queries to use placeholders
2007-02-24 00:37:55 +00:00
Colin Kuskie
2a0eb20bc7 Tests for the canUseAdminMode method of User.pm
Uncovered and fixed a bug where $session->user instead of $self was used in canUseAdminMode
Added an explicit test in Config.pm to make sure that array refs can be passed to ->set.
2007-02-23 23:39:35 +00:00
Colin Kuskie
2803ae520c Ran coverage on User.t and found that we're missing two entire
methods, so I added TODO tests for them.  Overall coverage is low
as well.
Began converting User.pm to use placeholders.
2007-02-23 22:27:23 +00:00
Colin Kuskie
5f36fbb30f fix typo for session->warn 2007-01-05 23:57:52 +00:00
Drake
e795f06fd8 Rollback r3340 since it broke specialState:init. 2006-12-06 17:49:22 +00:00
Drake
aa3b8b6d24 Profile field defaulting fixes. 2006-12-06 16:45:52 +00:00
Drake
cc88ddbd09 Fix bug with WebGUI::User not using getIp for canUseAdminMode. 2006-12-05 15:49:09 +00:00
JT Smith
bc4125204a - fix: Bug in "Article with Files"
- fix: SQLReport pagination retains op= parameter
 - fix: Invalid MIME type set for images
2006-11-15 22:30:50 +00:00
Martin Kamerbeek
ce447fdbd9 Fixed a bug where the adminbar would not show up if adminModeSubnets is missing in the config file. 2006-11-10 14:39:32 +00:00